From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id B8DADA00E6 for ; Mon, 10 Jun 2019 19:52:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 407881C1AF; Mon, 10 Jun 2019 19:52:13 +0200 (CEST) Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 0AB3F1C18F for ; Mon, 10 Jun 2019 19:52:06 +0200 (CEST) Received: by mail-pg1-f195.google.com with SMTP id l19so2824384pgh.9 for ; Mon, 10 Jun 2019 10:52:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MaX/9U1VKQDRlwJP1eh9LKqP+HAkhTNljy8r1/SknpU=; b=hIvjCiWQYNPBc9jHxV6ypMMauQl+MwhXQziimacjCDO/UVfsavYjONek6p+xRa7cQJ N7zYKRBa7XYUp4sythvbZiiXZz6BJLxlFdrYMCucBIW0GSTniCl0BdNKjnnxPSEOkgXD ck39/mTrbIJ5iwTTLRi9QGsUKJo5NK5QJlGj7qpV+FshVt/R5XxeY02DCbycvl3rPSrS T6hihyHqh1Io3Ww+K/FR8yqsdY53KReJ0jv2AK00FFLjoyOoLl1VOnsj1EzWLjZFcce3 cIcO8hOaWpb9wxkyIeLGjm4CEO70ugGUo26wVerb66gIg/GOZjpO/TMtZGCdg3wzLGsl Y1Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MaX/9U1VKQDRlwJP1eh9LKqP+HAkhTNljy8r1/SknpU=; b=FZBR8ppc2dYmXZyIuBI9B+Ot5Cgydb2rIvMrSYDPViD3dJuDefp/4j+XQNz0E6dOKE YPl85d4wuK/J9SmZFCa5yD9Ym8R+jNIZ5WDi/GivjrMTzSgQK05c+buBtnIbQBf+Mwua 2kSf9obgrLPNwei99Qt9jj4/OEuMFbIKTeldMU0bKWyXsYSbBqQm42GHlezsZYajo65v HzHzOWMDJPgLMFAvjEuPSsIjq3+1fERBtEZsADOvwSOvP8QwwzqDWQsm8xxmfLlSN2vT 4HLxq1hCNfl3155CRVX3Qmz9suNVi0q3sRpMXV35KokVqaDuNAmT8zjY1bqRs2gLPhLu w/KQ== X-Gm-Message-State: APjAAAUsVFuPFBt8XdntZz5Tf2HYTr3krHOD5ODLwDIL67+785vtf7pG XePYV06dwKwhGJL83iiJPPJyMMf4zCM= X-Google-Smtp-Source: APXvYqxdnXYMpsvwGRCEgnbF5n69f+6YmKd67hT/yNp/+5AkWFplqBH/OWBiPEbMcJhqouubSXbnRQ== X-Received: by 2002:a17:90a:270f:: with SMTP id o15mr10315930pje.56.1560189125189; Mon, 10 Jun 2019 10:52:05 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id l38sm131656pje.12.2019.06.10.10.52.04 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 10 Jun 2019 10:52:04 -0700 (PDT) From: Stephen Hemminger To: ferruh.yigit@intel.com Cc: dev@dpdk.org, Stephen Hemminger Date: Mon, 10 Jun 2019 10:51:53 -0700 Message-Id: <20190610175155.21374-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190610175155.21374-1-stephen@networkplumber.org> References: <20190610175155.21374-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2 5/7] kni: use proper type for kni fifo's X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Using void * instead of proper type is unsafe practice. Signed-off-by: Stephen Hemminger --- kernel/linux/kni/kni_dev.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/kernel/linux/kni/kni_dev.h b/kernel/linux/kni/kni_dev.h index f3e6c3ca4efa..ceba5f73c1d9 100644 --- a/kernel/linux/kni/kni_dev.h +++ b/kernel/linux/kni/kni_dev.h @@ -51,22 +51,22 @@ struct kni_dev { struct net_device *net_dev; /* queue for packets to be sent out */ - void *tx_q; + struct rte_kni_fifo *tx_q; /* queue for the packets received */ - void *rx_q; + struct rte_kni_fifo *rx_q; /* queue for the allocated mbufs those can be used to save sk buffs */ - void *alloc_q; + struct rte_kni_fifo *alloc_q; /* free queue for the mbufs to be freed */ - void *free_q; + struct rte_kni_fifo *free_q; /* request queue */ - void *req_q; + struct rte_kni_fifo *req_q; /* response queue */ - void *resp_q; + struct rte_kni_fifo *resp_q; void *sync_kva; void *sync_va; -- 2.20.1