From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D9E8CA00E6 for ; Tue, 11 Jun 2019 16:25:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 490C41C3DE; Tue, 11 Jun 2019 16:25:13 +0200 (CEST) Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id 098FB2C6A for ; Tue, 11 Jun 2019 16:25:12 +0200 (CEST) Received: by mail-pf1-f193.google.com with SMTP id i189so7534988pfg.10 for ; Tue, 11 Jun 2019 07:25:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=F/5GlBlpXF0D2FrZfcVpUKvQSv5fhJcqtnVIfIqqetg=; b=Xi7w/Czx4TUnBTsHmMp4Yg/1rad7l+qBj0cg59wjCt9oOG6MM6CRz7f/pajC9Q/y4T WgXZQ7bSur+FD7r/5cvt0u3YiTA99z/1marTkpsWyNbSllOo1bJ2+2OZA8DwIU3skkIi 1OudNpoy4WFMIlUibl9iFum21gRuGZbIUgQfRQIfNxzaeWAL2/FdRapTzd+j90exrrAe lQMu8qPaGa6icjH9ldFgIUzn/5DtWlKjYQyhXof6wPD+r5xSaRNAKfevZibuY+7KUCEg 2lKoY3wdrakyl2WVn0n0V8PGiKNn6ac/8jrfpBnlb+ovGg0Yt/CeX6UFcEaBDFnHb3+d y0qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=F/5GlBlpXF0D2FrZfcVpUKvQSv5fhJcqtnVIfIqqetg=; b=a5bED9woh8H0OTWFmcL0o87B0AEBpDh1qYMoFxmNS8UUztC4vUCkWVwkjgBsoWTKW0 EYWe/ALk4nTsRy4DKLAlMJmhzrB9ZhgYeIq97UiuVG7/0YdAhGALhzV6HkoEj0PaEqID NYhv+vUji0fNPtSiFyjKBCwRJ95+ZBo8E6xFuUzzOpufZ4XzoMogXNWPbVEYCgyItRY5 bwrz+pLk3/Tt27YOElMpPkeE4NQn/x5dUPy19w4H7FNQTJ2utMuXxKvNleLQSunmga06 fz4evpZju70y2qTM7lP7kxE84eH86lF1z6gSIfgn6PaJuLqq3clA4Z3VxMj6x2rtXx3r lxIg== X-Gm-Message-State: APjAAAVfZ3YSy87V/YMaj449SNN1aRQz2OpPEVXiq5lpzYSvTjG62Wc/ D0wEW2yYr/7Sry1vbDB2bWRyHw== X-Google-Smtp-Source: APXvYqzI+BZWv2vG6S8qsrSaEsuI9c5YbvB3lC58fYiDGUnNPTQGarTiScHLRRdegr+yykEZDzGdvQ== X-Received: by 2002:a17:90a:ab0c:: with SMTP id m12mr27549145pjq.87.1560263111160; Tue, 11 Jun 2019 07:25:11 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id z14sm17647039pgs.79.2019.06.11.07.25.10 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 11 Jun 2019 07:25:11 -0700 (PDT) Date: Tue, 11 Jun 2019 07:25:09 -0700 From: Stephen Hemminger To: Bruce Richardson Cc: David Marchand , Ilya Maximets , dev , Ian Stokes , Aaron Conole , "ovs-dev@openvswitch.org" , "Yigit, Ferruh" Message-ID: <20190611072509.736ba3be@hermes.lan> In-Reply-To: <20190611101822.GB457@bricha3-MOBL.ger.corp.intel.com> References: <20190611101822.GB457@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] Forcing inlining for igb_uio and kni X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 11 Jun 2019 11:18:22 +0100 Bruce Richardson wrote: > On Tue, Jun 11, 2019 at 11:44:01AM +0200, David Marchand wrote: > > On Tue, Jun 11, 2019 at 11:31 AM Ilya Maximets > > <[1]i.maximets@samsung.com> wrote: > > > > On 11.06.2019 11:45, David Marchand wrote: > > > I noticed that OVS CI [1] patches the dpdk sources to force some > > inlining parameters and get kni and igb_uio to build fine. > > > > > > Looking at it in dpdk, meson support dropped this. > > > In the makefiles, I can't find a reason in the git history (we go > > back to 1.3.0rX version). > > > > > > [dmarchan@dmarchan dpdk]$ git grep max-inline-insns-single > > > kernel/linux/igb_uio/Makefile:MODULE_CFLAGS += -I$(SRCDIR) --param > > max-inline-insns-single=100 > > > kernel/linux/kni/Makefile:MODULE_CFLAGS += -I$(SRCDIR) --param > > max-inline-insns-single=50 > > > [dmarchan@dmarchan dpdk]$ git blame origin/master -- > > kernel/linux/igb_uio/Makefile |grep max-inline-insns-single > > > 13dc56a6 lib/librte_eal/linuxapp/igb_uio/Makefile (Intel > > 2012-12-20 00:00:00 +0100 15) MODULE_CFLAGS += -I$(SRCDIR) --param > > max-inline-insns-single=100 > > > [dmarchan@dmarchan dpdk]$ git blame origin/master -- > > kernel/linux/kni/Makefile |grep max-inline-insns-single > > > 3fc5ca2f lib/librte_eal/linuxapp/kni/Makefile (Intel > > 2012-12-20 00:00:00 +0100 14) MODULE_CFLAGS += -I$(SRCDIR) --param > > max-inline-insns-single=50 > > > > > > Is there a valid reason to keep this? > > > 1: > > [2]https://github.com/openvswitch/ovs/blob/master/.travis/linux-buil > > d.sh#L81 > > <[3]https://protect2.fireeye.com/url?k=b7de159c45b1fa79.b7df9ed3-c48 > > 06461f28ecaf5&u=https://github.com/openvswitch/ovs/blob/master/.trav > > is/linux-build.sh#L81> > > Hi, David. > > I don't know the reason for these in OVS travis config, But we don't > > need to know them, actually. I have a patch to drop all the kernel > > related stuff from the DPDK build in OVS Travis checks, just didn't > > send it yet. Will send soon, probably. > > > > I had this in mind since we don't need those kmods in the CI. > > Thanks Ilya. > > The question on dpdk side remains open :-). > > -- > > David Marchand > > I know that previously we did have issues with the modules not compiling > due to errors about maximum levels of inlines. Whether that was because of > the compiler, or the kernel makefiles at the time, I'm not sure. The kmods > seem to build fine for me now without the parameters, and the fact that > there has never been a problem reported with building using meson either, > probably indicates that the extra compiler flags can be dropped. > > /Bruce I really doubt forcing inlining makes any difference to the performance.