From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 820BCA00E6 for ; Tue, 11 Jun 2019 16:27:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5C23D1C3EA; Tue, 11 Jun 2019 16:27:30 +0200 (CEST) Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by dpdk.org (Postfix) with ESMTP id 738B51C3E9 for ; Tue, 11 Jun 2019 16:27:28 +0200 (CEST) Received: by mail-pf1-f176.google.com with SMTP id c85so7564040pfc.1 for ; Tue, 11 Jun 2019 07:27:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KEZn74YAt6b2OIHFU+bnKHd1BEJyXcW0lLk7f3r/qpI=; b=EpGLWH+oBy8d6DCNk0WlIlCCosWu4PrYpYn1Zbq5VOXsfx4DUmHdNfnEXTmzkJhQFM rBWYWFa2nL1lISihZWc0z+Pi5Dg3WWL02Yvaiq12qpcm4pg0okLCGKRf/ie5brSXpPaC xheX1YlaS/vdAQGTFjn7iFk69Z3Wonda+MbqI+3JLf19e5DQxCVZAj26MofVh3jo/KK+ jWtwwsm4m/b/ejRgYHRpk1uzm5Kt5Kbe4CeNak+MFj7XGn+XGeE7h14fIIr3QM0gbxIf FltwzYQ8E33z3u1F0S361aZKe5lpSHPUh/q9hrnOL+ds7hxWmVJON2KacBg5ujadvKTr 0oWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KEZn74YAt6b2OIHFU+bnKHd1BEJyXcW0lLk7f3r/qpI=; b=eWMIY/DuFgCKm6jrNcQrmghpvnSMWbb/VurUTezKZaMifF6HM0bNzyjkR5ANoPqBc6 rxxuVT3wezU9tt7ZVG7P9UU/OS7JQO5YxRkdqBsilMBponXjuCBkg5gva3/S6x7NVXyq v8BoT17r0ZU5qUxgG5PEr2lcK1V4SIYghrRQq9awTBkEJfebLfKczbbhg8bryWMkfNFP zWemVjl1MbUb0zIlpBH1Q5wrAilzjLPndrOU+4N8BGk/ZhLrN8xSEF4OrG58XIm0ZFYG 4JhP0LO3Wg7cm4/U11oeK6rzTNa0xm7V8jHJ7m/Ao+fbOXbZt+QlkxKfSXQJj7+c01sZ nCAA== X-Gm-Message-State: APjAAAVeILwxo+h2l6nhhRNLYbGkaErD/Q16WSwgZtyvFvKH3Vg2o78Z IAgbrystnuPV0ghavrdCSuM8hw== X-Google-Smtp-Source: APXvYqwGppmo5Xw773DOgCevco3U83jkXGBZ2diF/YxwySUrl5VCBiJ3MQ9ePJR1JW4Y+S0uW4ol5Q== X-Received: by 2002:a62:5e06:: with SMTP id s6mr82957241pfb.193.1560263247678; Tue, 11 Jun 2019 07:27:27 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id r9sm12678154pgv.24.2019.06.11.07.27.27 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 11 Jun 2019 07:27:27 -0700 (PDT) Date: Tue, 11 Jun 2019 07:27:26 -0700 From: Stephen Hemminger To: "Sanford, Robert" Cc: "erik.g.carrillo@intel.com" , "dev@dpdk.org" Message-ID: <20190611072726.0350a663@hermes.lan> In-Reply-To: <83AA51E6-C1D2-4E09-B240-88326ECFD853@akamai.com> References: <20190610224441.5461-1-stephen@networkplumber.org> <83AA51E6-C1D2-4E09-B240-88326ECFD853@akamai.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC] rte_timer: add rte_timer_next_ticks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 11 Jun 2019 13:37:33 +0000 "Sanford, Robert" wrote: > Hi Stephen, > > The code seems fine. My only comment is that there is not a blank line before the new code, in both the .c and .h. > > -- > Regards Where, I see the blank line between functions and checkpatch is happy.