From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 82DFCA00E6 for ; Tue, 11 Jun 2019 23:30:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B7E291D073; Tue, 11 Jun 2019 23:30:14 +0200 (CEST) Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id C1D531D070 for ; Tue, 11 Jun 2019 23:30:12 +0200 (CEST) Received: by mail-pg1-f194.google.com with SMTP id 20so7677570pgr.4 for ; Tue, 11 Jun 2019 14:30:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=spQSv03uzUOOUFd5byW7Teh81GXe7URMPeSGe4rdfN8=; b=Iym5dsXkrVp9sdRQej27rCmTWlKWJPmfUv4u8iM8Sr9SmRjjh/7nNofdbBMb0aKEwe JowGRdstFU+3g3a8jvITNEdG54bvaUSDKvFuC+Vv1cO2V9TJ7rKHpQijcMxXS+X8rCPp 15Crrow284ZadwVgnbCIEUjTPC9Atv44/dGKeX8hzkGmmdpuQJEuN5azmvqv7PD27T95 u+V2Mt+UZhBSe8zW2K0Ix5Zz9/6bZGk7L78s3kPs4U6kYHN80xJaX9baIKij00cozn5M OesxsSPPaG/OXd56EqPTPkpjDu4b/AAYkpvZHawNScRiX4g7QDLeQxiWkQN/lo6Ne8dQ lXEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=spQSv03uzUOOUFd5byW7Teh81GXe7URMPeSGe4rdfN8=; b=lJjfo2W71K8PBE1JF+/dB+QNKlIhNarLltBu2iadhmKbGAnjdpzT/Rb7A7rSQy035H eI6PIcbX/DW3Lh4fX9fOLMem5SfTHcUVtbQN4iE+/y4LGJEuVgBFCYW8JjI9XLsW8g7A mQsnQj+3DmzU7kUwIrIuhj4Py7Rvqt21N093p2qkc6TZytDTK92mVZ9+qNR8L0aZyLLZ Aa6xwrJw3T9pwCejS5PLkFzGian6SV4qpryxbmdQNxsuoST4MDffAHmkq163dKGc7ZAs TBkmiZcuoJtyEBxbo7usFgd7OsLWWygXS0J3GxWnxsam8ZAwfAb0Ak174AU6YsXWjTK9 aDMA== X-Gm-Message-State: APjAAAWh/vIp525S62lnuzIDJE1/SnjFgKnOWeq8CROtY76YCdCu2FBN HiR2WYvqDt0sRemFiGb42v6J9A== X-Google-Smtp-Source: APXvYqwOPNC+E9Vh/RBHNwj1zd0xMtIQnm5t/DK+BYWUjoT71VKb4f4OXlsKCxqkREvO0N2Cwu7bow== X-Received: by 2002:aa7:956d:: with SMTP id x13mr43216621pfq.132.1560288611684; Tue, 11 Jun 2019 14:30:11 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id d6sm13143992pgv.4.2019.06.11.14.30.11 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 11 Jun 2019 14:30:11 -0700 (PDT) Date: Tue, 11 Jun 2019 14:30:09 -0700 From: Stephen Hemminger To: Lance Richardson Cc: Ferruh Yigit , dev@dpdk.org Message-ID: <20190611143009.23a34b98@hermes.lan> In-Reply-To: References: <20190610175155.21374-1-stephen@networkplumber.org> <20190611135416.01f6dffc@hermes.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2 0/7] kni: cleanups and improvements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 11 Jun 2019 17:18:42 -0400 Lance Richardson wrote: > On Tue, Jun 11, 2019 at 4:54 PM Stephen Hemminger > wrote: > > > > On Mon, 10 Jun 2019 10:51:48 -0700 > > Stephen Hemminger wrote: > > =20 > > > While testing KNI with netvsc, saw lots of places more code > > > could be safely removed from KNI kernel driver. > > > > > > This is still mostly "putting lipstick on a pig" all users > > > would be better off using virtio_user rather than KNI. > > > > > > v2 - get rid of unnecessary padding, combine the unused field patches > > > > > > Stephen Hemminger (7): > > > kni: don't need stubs for rx_mode or ioctl > > > kni: use netdev_alloc_skb > > > kni: don't keep stats in kni_net > > > kni: drop unused fields > > > kni: use proper type for kni fifo's > > > kni: return -EFAULT if copy_from_user fails > > > doc: update KNI documentation > > > > > > .../sample_app_ug/kernel_nic_interface.rst | 18 ++--- > > > kernel/linux/kni/kni_dev.h | 21 ++--- > > > kernel/linux/kni/kni_misc.c | 17 ++-- > > > kernel/linux/kni/kni_net.c | 79 +++++------------= -- > > > 4 files changed, 38 insertions(+), 97 deletions(-) > > > =20 > > > > Don't believe patchwork the patch is fine, it is getting falsely blamed > > for failures caused by other changes in ice, bnxt which fail > > FreeBSD build. =20 >=20 > Do you mean failures like the ones below? If so, I think think they > might be an unintended > consequence of commit a385972c3 "mk: disable warning for packed member po= inter". >=20 > Lance >=20 > OS: FreeBSD12-64 > Target: x86_64-native-bsdapp-gcc > CC ice_rxtx.o > CC ice_ethdev.o > cc1: error: unrecognized command line option > '-Wno-address-of-packed-member' [-Werror] > cc1: all warnings being treated as errors > gmake[6]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc= /e6c3bc062b1045128114bdf0cfdd236b/dpdk/mk/internal/rte.compile-pre.mk:114: > bnxt_ethdev.o] Error 1 > gmake[5]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc= /e6c3bc062b1045128114bdf0cfdd236b/dpdk/mk/rte.subdir.mk:37: > bnxt] Error 2 > gmake[5]: *** Waiting for unfinished jobs.... More than just that *Build Failed Build #1: OS: FreeBSD12-64 Target: x86_64-native-bsdapp-gcc+debug CC ipn3ke_flow.o CC lio_23xx_vf.o cc1: error: unrecognized command line option '-Wno-address-of-packed-member= ' [-Werror] cc1: all warnings being treated as errors gmake[6]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+d= ebug/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/internal/rte.compile-pre.mk:1= 16: bnxt_ethdev.o] Error 1 gmake[5]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+d= ebug/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.subdir.mk:37: bnxt] Error= 2 gmake[5]: *** Waiting for unfinished jobs.... CC i40e_flow.o CC rte_eth_null.o -- LD ixgbe_ethdev.o AR librte_pmd_ixgbe.a INSTALL-LIB librte_pmd_ixgbe.a gmake[4]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+d= ebug/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.subdir.mk:35: net] Error 2 gmake[3]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+d= ebug/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkbuild.mk:46: drivers] = Error 2 gmake[2]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+d= ebug/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkroot.mk:99: all] Error= 2 gmake[1]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+d= ebug/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkinstall.mk:61: pre_ins= tall] Error 2 gmake: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+debu= g/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkroot.mk:77: install] Erro= r 2 *Build Failed Build #2: OS: FreeBSD12-64 Target: x86_64-native-bsdapp-gcc+shared CC rte_eth_null.o.pmd.o LD rte_eth_null.o cc1: error: unrecognized command line option '-Wno-address-of-packed-member= ' [-Werror] cc1: all warnings being treated as errors gmake[6]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+s= hared/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/internal/rte.compile-pre.mk:= 116: bnxt_ethdev.o] Error 1 gmake[6]: *** Waiting for unfinished jobs.... CC ice_rxtx.o =3D=3D Build drivers/net/ring -- LD ice_ethdev.o CC ice_rxtx_vec_sse.o CC octeontx_pkovf.o gmake[5]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+s= hared/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.subdir.mk:35: bnxt] Erro= r 2 gmake[5]: *** Waiting for unfinished jobs.... CC i40e_tm.o CC ice_rxtx_vec_avx2.o -- INSTALL-LIB librte_pmd_ixgbe.so.2.1 LD librte_pmd_qede.so.1.1 INSTALL-LIB librte_pmd_qede.so.1.1 gmake[4]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+s= hared/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.subdir.mk:35: net] Error= 2 gmake[3]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+s= hared/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkbuild.mk:46: drivers]= Error 2 gmake[2]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+s= hared/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkroot.mk:99: all] Erro= r 2 gmake[1]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+s= hared/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkinstall.mk:61: pre_in= stall] Error 2 gmake: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc+shar= ed/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkroot.mk:77: install] Err= or 2 *Build Failed Build #3: OS: FreeBSD12-64 Target: x86_64-native-bsdapp-gcc CC ice_dcb.o LD rte_eth_null.o cc1: error: unrecognized command line option '-Wno-address-of-packed-member= ' [-Werror] cc1: all warnings being treated as errors gmake[6]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc/0= 25b54b548ed4ca894cbf5e754039b68/dpdk/mk/internal/rte.compile-pre.mk:114: bn= xt_ethdev.o] Error 1 gmake[5]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc/0= 25b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.subdir.mk:37: bnxt] Error 2 gmake[5]: *** Waiting for unfinished jobs.... CC ixgbe_phy.o CC octeontx_rxtx.o -- LD qede_ethdev.o AR librte_pmd_qede.a INSTALL-LIB librte_pmd_qede.a gmake[4]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc/0= 25b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.subdir.mk:35: net] Error 2 gmake[3]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc/0= 25b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkbuild.mk:46: drivers] Error 2 gmake[2]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc/0= 25b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkroot.mk:99: all] Error 2 gmake[1]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc/0= 25b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkinstall.mk:61: pre_install] = Error 2 gmake: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc/025b= 54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkroot.mk:77: install] Error 2 *Build Failed Build #4: OS: FreeBSD12-64 Target: x86_64-native-bsdapp-clang #define roundup(x, y) ((((x)+((y)-1))/(y))*(y)) /* to any y */ ^ 1 error generated. gmake[6]: *** [/tmp/FreeBSD12-64_K19.02_Clang6.0.1/x86_64-native-bsdapp-cla= ng/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/internal/rte.compile-pre.mk:114= : bnxt_ethdev.o] Error 1 CC ice_flex_pipe.o gmake[5]: *** [/tmp/FreeBSD12-64_K19.02_Clang6.0.1/x86_64-native-bsdapp-cla= ng/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.subdir.mk:35: bnxt] Error 2 gmake[5]: *** Waiting for unfinished jobs.... CC lio_mbox.o AR librte_pmd_null.a -- LD ixgbe_ethdev.o AR librte_pmd_ixgbe.a INSTALL-LIB librte_pmd_ixgbe.a gmake[4]: *** [/tmp/FreeBSD12-64_K19.02_Clang6.0.1/x86_64-native-bsdapp-cla= ng/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.subdir.mk:35: net] Error 2 gmake[3]: *** [/tmp/FreeBSD12-64_K19.02_Clang6.0.1/x86_64-native-bsdapp-cla= ng/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkbuild.mk:46: drivers] Er= ror 2 gmake[2]: *** [/tmp/FreeBSD12-64_K19.02_Clang6.0.1/x86_64-native-bsdapp-cla= ng/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkroot.mk:99: all] Error 2 gmake[1]: *** [/tmp/FreeBSD12-64_K19.02_Clang6.0.1/x86_64-native-bsdapp-cla= ng/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkinstall.mk:61: pre_insta= ll] Error 2 gmake: *** [/tmp/FreeBSD12-64_K19.02_Clang6.0.1/x86_64-native-bsdapp-clang/= 025b54b548ed4ca894cbf5e754039b68/dpdk/mk/rte.sdkroot.mk:77: install] Error 2 *Meson Failed Build #1: OS: UB1604-32 Target:build-gcc-static FAILED: examples/c590b3c@@dpdk-rxtx_callbacks at exe/rxtx_callbacks_main.c.= o=20 gcc -Iexamples/c590b3c@@dpdk-rxtx_callbacks at exe -Iexamples -I../examples= -Iexamples/rxtx_callbacks -I../examples/rxtx_callbacks -I. -I../ -Iconfig = -I../config -Ilib/librte_eal/common/include -I../lib/librte_eal/common/incl= ude -I../lib/librte_eal/linux/eal/include -Ilib/librte_eal/common -I../lib/= librte_eal/common -Ilib/librte_eal/common/include/arch/x86 -I../lib/librte_= eal/common/include/arch/x86 -Ilib/librte_eal -I../lib/librte_eal -Ilib/libr= te_kvargs -I../lib/librte_kvargs -Ilib/librte_mempool -I../lib/librte_mempo= ol -Ilib/librte_ring -I../lib/librte_ring -Ilib/librte_net -I../lib/librte_= net -Ilib/librte_mbuf -I../lib/librte_mbuf -Ilib/librte_ethdev -I../lib/lib= rte_ethdev -Ilib/librte_cmdline -I../lib/librte_cmdline -Ilib/librte_meter = -I../lib/librte_meter -fdiagnostics-color=3Dalways -pipe -D_FILE_OFFSET_BIT= S=3D64 -Wall -Winvalid-pch -Werror -O3 -include rte_config.h -Wunused-param= eter -Wsign-compare -Wcast-qual -Wno-pointer-to-int-cast -march=3Dnative -D= _GNU_SOURCE -DALLOW_EXPERIMENTAL_API -MD -MQ 'examples/c590b3c@@dpdk-rxtx_c= allbacks at exe/rxtx_callbacks_main.c.o' -MF 'examples/c590b3c@@dpdk-rxtx_c= allbacks at exe/rxtx_callbacks_main.c.o.d' -o 'examples/c590b3c@@dpdk-rxtx_= callbacks at exe/rxtx_callbacks_main.c.o' -c ../examples/rxtx_callbacks/mai= n.c ../examples/rxtx_callbacks/main.c: In function =E2=80=98port_init=E2=80=99: ../examples/rxtx_callbacks/main.c:172:10: error: format =E2=80=98%lu=E2=80= =99 expects argument of type =E2=80=98long unsigned int=E2=80=99, but argum= ent 2 has type =E2=80=98uint64_t {aka long long unsigned int}=E2=80=99 [-We= rror=3Dformat=3D] printf("TSC Freq ~=3D %lu\nHW Freq ~=3D %lu\nRatio : %f\n", ^ ../examples/rxtx_callbacks/main.c:172:10: error: format =E2=80=98%lu=E2=80= =99 expects argument of type =E2=80=98long unsigned int=E2=80=99, but argum= ent 3 has type =E2=80=98uint64_t {aka long long unsigned int}=E2=80=99 [-We= rror=3Dformat=3D] cc1: all warnings being treated as errors [1531/1549] Linking target examples/dpdk-vdpa. [1532/1549] Linking target examples/dpdk-timer. [1533/1549] Linking target examples/dpdk-tep_termination. [1534/1549] Compiling C object 'examples/c590b3c@@dpdk-vhost_crypto at exe/= vhost_crypto_main.c.o'. [1535/1549] Compiling C object 'examples/c590b3c@@dpdk-vhost at exe/vhost_m= ain.c.o'. ninja: build stopped: subcommand failed