From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 1D847A0471 for ; Mon, 17 Jun 2019 10:54:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F0CA01BE7F; Mon, 17 Jun 2019 10:54:00 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id E241E1BE6B; Mon, 17 Jun 2019 10:53:58 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jun 2019 01:53:57 -0700 X-ExtLoop1: 1 Received: from npg-dpdk-virtio-tbie-2.sh.intel.com (HELO ___) ([10.67.104.151]) by fmsmga006.fm.intel.com with ESMTP; 17 Jun 2019 01:53:56 -0700 Date: Mon, 17 Jun 2019 16:52:45 +0800 From: Tiwei Bie To: Andrew Rybchenko Cc: Maxime Coquelin , Zhihong Wang , dev@dpdk.org, Dilshod Urazov , stable@dpdk.org Message-ID: <20190617085245.GB17273@___> References: <1559587805-1637-1-git-send-email-arybchenko@solarflare.com> <1560680229-8166-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1560680229-8166-1-git-send-email-arybchenko@solarflare.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/virtio: add Tx preparation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Jun 16, 2019 at 11:17:08AM +0100, Andrew Rybchenko wrote: > From: Dilshod Urazov > > Virtio requires pseudo-header checksum in TCP/UDP checksum to do > offload, but it was lost when Tx prepare is introduced. Also > rte_validate_tx_offload() should be used to validate Tx offloads. > > Also it is incorrect to do virtio_tso_fix_cksum() after prepend > to mbuf without taking prepended size into account, since layer 2/3/4 > lengths provide incorrect offsets after prepend. > > Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation") > Cc: stable@dpdk.org > > Signed-off-by: Dilshod Urazov > Signed-off-by: Andrew Rybchenko > --- Reviewed-by: Tiwei Bie Thanks, Tiwei