From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 1A58AA0471 for ; Mon, 17 Jun 2019 13:17:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BEC341BEEE; Mon, 17 Jun 2019 13:17:20 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id CA3B51BEE3 for ; Mon, 17 Jun 2019 13:17:18 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jun 2019 04:17:17 -0700 Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jun 2019 04:17:16 -0700 Date: Mon, 17 Jun 2019 12:17:13 +0100 From: Bruce Richardson To: David Marchand Cc: dev , Thomas Monjalon , Aaron Conole , Michael Santana Message-ID: <20190617111713.GD527@bricha3-MOBL.ger.corp.intel.com> References: <1559638792-8608-1-git-send-email-david.marchand@redhat.com> <1560580950-16754-1-git-send-email-david.marchand@redhat.com> <20190617100027.GA527@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH v2 00/15] Unit tests fixes for CI X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jun 17, 2019 at 12:46:03PM +0200, David Marchand wrote: > On Mon, Jun 17, 2019 at 12:02 PM Bruce Richardson > <[1]bruce.richardson@intel.com> wrote: > > On Sat, Jun 15, 2019 at 08:42:15AM +0200, David Marchand wrote: > > This is a joint effort to make the unit tests ready for CI. > > The first patches are fixes that I had accumulated. > > Then the second part of the series focuses on skipping tests when > some > > requirements are not fulfilled so that we can start them in a > restrained > > environment like Travis virtual machines that gives us two cores > and does > > not have specific hw devices. > > > > We are still not ready for enabling those tests in Travis. > > At least, the following issues remain: > > - some fixes on librte_acl have not been merged yet [1], > > - the tests on --file-prefix are still ko, and have been isolated > in a > > test that we could disable while waiting for the fixes, > > - rwlock_autotest and hash_readwrite_lf_autotest are taking a > little more > > than 10s, > > - librte_table unit test crashes on ipv6 [2], > > - the "perf" tests are taking way too long for my taste, > > - the shared build unit tests all fail when depending on mempool > since > > the mempool drivers are not loaded, > > > For the autotest app shared builds, it is probably worthwhile > linking in > all drivers explicitly to avoid issues like this. > > Yes, I'll look into this. > While at it, do you know why the i40e and ixgbe drivers are linked to > app/test in meson? > -- There are unit tests for the device-specific functions in those drivers, so they need to be given at link time. /Bruce