From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 5EA12A0471 for <public@inbox.dpdk.org>; Mon, 17 Jun 2019 13:57:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 54BAC1BF16; Mon, 17 Jun 2019 13:57:02 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id CB4341BED5 for <dev@dpdk.org>; Mon, 17 Jun 2019 13:57:00 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jun 2019 04:56:59 -0700 Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jun 2019 04:56:57 -0700 Date: Mon, 17 Jun 2019 12:56:54 +0100 From: Bruce Richardson <bruce.richardson@intel.com> To: David Marchand <david.marchand@redhat.com> Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>, Aaron Conole <aconole@redhat.com>, Michael Santana <msantana@redhat.com> Message-ID: <20190617115654.GE527@bricha3-MOBL.ger.corp.intel.com> References: <1559638792-8608-1-git-send-email-david.marchand@redhat.com> <1560580950-16754-1-git-send-email-david.marchand@redhat.com> <20190617100027.GA527@bricha3-MOBL.ger.corp.intel.com> <CAJFAV8zYaoB4TSNVK85CVwLPx4hbs1XdQfKgE7vj=bpsMrH=iA@mail.gmail.com> <20190617111713.GD527@bricha3-MOBL.ger.corp.intel.com> <CAJFAV8zZQrPK6xj_S=s7JrNHS+Urrx-r2wbQCO+8LS8DjrSN-A@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <CAJFAV8zZQrPK6xj_S=s7JrNHS+Urrx-r2wbQCO+8LS8DjrSN-A@mail.gmail.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH v2 00/15] Unit tests fixes for CI X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Mon, Jun 17, 2019 at 01:41:21PM +0200, David Marchand wrote: > On Mon, Jun 17, 2019 at 1:18 PM Bruce Richardson > <[1]bruce.richardson@intel.com> wrote: > > On Mon, Jun 17, 2019 at 12:46:03PM +0200, David Marchand wrote: > > On Mon, Jun 17, 2019 at 12:02 PM Bruce Richardson > > <[1][2]bruce.richardson@intel.com> wrote: > > > > On Sat, Jun 15, 2019 at 08:42:15AM +0200, David Marchand > wrote: > > > This is a joint effort to make the unit tests ready for CI. > > > The first patches are fixes that I had accumulated. > > > Then the second part of the series focuses on skipping > tests when > > some > > > requirements are not fulfilled so that we can start them in > a > > restrained > > > environment like Travis virtual machines that gives us two > cores > > and does > > > not have specific hw devices. > > > > > > We are still not ready for enabling those tests in Travis. > > > At least, the following issues remain: > > > - some fixes on librte_acl have not been merged yet [1], > > > - the tests on --file-prefix are still ko, and have been > isolated > > in a > > > test that we could disable while waiting for the fixes, > > > - rwlock_autotest and hash_readwrite_lf_autotest are taking > a > > little more > > > than 10s, > > > - librte_table unit test crashes on ipv6 [2], > > > - the "perf" tests are taking way too long for my taste, > > > - the shared build unit tests all fail when depending on > mempool > > since > > > the mempool drivers are not loaded, > > > > > For the autotest app shared builds, it is probably worthwhile > > linking in > > all drivers explicitly to avoid issues like this. > > > > Yes, I'll look into this. > > While at it, do you know why the i40e and ixgbe drivers are > linked to > > app/test in meson? > > -- > There are unit tests for the device-specific functions in those > drivers, so > they need to be given at link time. > > For testpmd, I can understand. > But I can't see code for driver specific apis in app/test. > It looks like a copy/paste error when adding meson support. > -- Ok, could be. Simple question is does it still build ok if you remove them? /Bruce