From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 61029A0471 for ; Wed, 19 Jun 2019 20:22:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C09851D0AD; Wed, 19 Jun 2019 20:22:21 +0200 (CEST) Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id D6C701D0AC for ; Wed, 19 Jun 2019 20:22:20 +0200 (CEST) Received: by mail-pg1-f195.google.com with SMTP id s21so108316pga.12 for ; Wed, 19 Jun 2019 11:22:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=q+Q6MAxgd9tsp+BMX2JovvyyiplL5hBURAqLmdP7ELM=; b=0KeBWp6lwIC2cFZiZ3dBPXO66jcyZFqCbC9/6Q/01ep92mwIstQ+3p35ECs2UpmzLa 6eZgoYxkGtopqt8my8r3gPuvnI7QngB8CKEbR1rCYe+DpbSnNdihj+oYYnB/mj+eLCZX mvmpDrQxf78JAJBUhIns27feY6Bl6KQ7FwLCtwDtregw1sjuL4pBJ2s94KpiU+l+z+vA z19BGNBslEaFri/tD84GsiU8HVw39tF6Q4ERczcC8WZlzSzfvXPP99eBX9jTe/kxqseW goDCKPlCM05W9tHB9zYDVuZnUh/C+/TWZBFwaXybBS+sGkatJdh4+PafMFnPdnlusk24 Xb7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=q+Q6MAxgd9tsp+BMX2JovvyyiplL5hBURAqLmdP7ELM=; b=H4O7CMEXcvuRIjL4YUT8Io2+61Nicqcy7jVDbgzvWgqkPIN+acQV3v/DI9kVYM5daP xdcUuD/vrVbrSBvDY3eChK0+OwbwoyyvGix5B+2p20bPpgi/JfWdeiqmpmzY2XTLpreq IDL3SThvi94zfax0U/r8TOGUSAA9fP9PN8dcCqS8WzSAFP2ponY/lA1zq/TKliyv3bWu a/ErI/pI93N/xs2lsnbFEea800ljV1xaCLj8tN2wqQqzjG5H+9GEeictWPzKksQK50TC XdgRB4OM6m2tlpmIsYgSBQ9atRiO+kqTHjFgZ6BetRiNVUipehT7Nao4IlWWbvFuiGFQ wWzg== X-Gm-Message-State: APjAAAVDl5K/k+lshJuOg39vk0mF7nFoKUk4nNmh/wfDz30AMtqpu6yK 57CywqMKbY4us2flMM7RxaTz56La+/s= X-Google-Smtp-Source: APXvYqwJuDtvyHXUT8udTrCioIlfdVvxykLXMr8luu6TXcIYdtaxsPfsDFoTLd4ocM4VX+J8SzRGUQ== X-Received: by 2002:a17:90a:206a:: with SMTP id n97mr12573858pjc.10.1560968539128; Wed, 19 Jun 2019 11:22:19 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id t11sm16212016pgp.1.2019.06.19.11.22.18 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 19 Jun 2019 11:22:18 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Wed, 19 Jun 2019 11:22:16 -0700 Message-Id: <20190619182217.8482-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 1/2] net/bnx2x: fix warnings from invalid assert X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This driver had a bogus assert which could never happen. This triggers "expression is always false warnings" with some compilers which causes build failure. Just remove it. Fixes: 6041aa619f9a ("net/bnx2x: fix poll link status") Signed-off-by: Stephen Hemminger --- drivers/net/bnx2x/bnx2x_ethdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c index 45c6c363c077..0ee35e4e4d8e 100644 --- a/drivers/net/bnx2x/bnx2x_ethdev.c +++ b/drivers/net/bnx2x/bnx2x_ethdev.c @@ -150,7 +150,6 @@ static void bnx2x_periodic_start(void *param) if (ret) { PMD_DRV_LOG(ERR, sc, "Unable to start periodic" " timer rc %d", ret); - assert(false && "Unable to start periodic timer"); } } } -- 2.20.1