From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 4EE6DA0471 for ; Wed, 19 Jun 2019 20:58:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 36A991D123; Wed, 19 Jun 2019 20:58:10 +0200 (CEST) Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id ACA351D0DB for ; Wed, 19 Jun 2019 20:58:00 +0200 (CEST) Received: by mail-pg1-f195.google.com with SMTP id l19so164579pgh.9 for ; Wed, 19 Jun 2019 11:58:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eVpCCGqv4anpgjgB0iS05xOJSNV5B1c7nQVpCcdAfXk=; b=atsHReJYzXpoQFMvRpotc9wVx2cZLyeWhPC75abwttbG6pjn8FLOaVC1Z5zoylvB/c gxHzYv8eAhCi4bjwPu3aJ62mSd7tr++bcgYZwybejEKeM6UacKZ9+jhkSJ8gx+LSeksV nViQDzf4HYQnAFDvgfRuquSLhal238AZAB5D3r78y24u/L7efpgU/QbxDGcN8mmjMyNu TNpbAyeuMXFuvjHd7fPfgUf9xOC/6co+O1B8SbnUAlrxyWZR5wwt1pi9t082KWKRZcxx sh+vXbxKm5vNTNjsvcGO77IdXWLJW+YH63YrX1ZylY9IDq5kKm5iTl4T7qC/cdbp+AD0 Z1mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eVpCCGqv4anpgjgB0iS05xOJSNV5B1c7nQVpCcdAfXk=; b=d3OYmz5u4P66SFSuTA203KvoalebbQjdyDF+/GeZIRxEyKG/W1IUX/g+DvvOCvzF4Y rKQYsvnA2rlaJOIojLJxrJWMAovM8gQi5stjO9Fng3AY7LY8bcy/xntXGoWW8ieh7Vn3 ScVYjMhh8L16bV31paC3hCrJgZ1Hs5VhO/oSp68CJgNOsqhwqpri4kwfLyr+SjgfC/7G CzcP1g7l6kgdl3I0MJRRC6YjFMmlDjkjO2If7PGmrldcs0qFBmnbIdnQZPo8Tup50l++ YblnzQKZJybbrWASEn6LquuD9UlGm9JNfzyLzRwzgxc1DHcTugaijAqZMFSEVNtSUmK3 29zA== X-Gm-Message-State: APjAAAXRRJ+ZaBZFUANjirqvFAcRc40dpWRTHDR/cZSwQc14/EGBJjeI 4BOR6xmpJeALbZSehfheR1/PYDbGg28= X-Google-Smtp-Source: APXvYqyjSA5UrXRYt8vXDN85knX4ok2QBNFHWNs7qTuLJ3wXkfxZrpAAQJXblbRg6ipm8Ymcyzc+IQ== X-Received: by 2002:a63:2a0f:: with SMTP id q15mr9219608pgq.163.1560970679631; Wed, 19 Jun 2019 11:57:59 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id b8sm24774858pff.20.2019.06.19.11.57.58 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 19 Jun 2019 11:57:58 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Stephen Hemminger Date: Wed, 19 Jun 2019 11:57:42 -0700 Message-Id: <20190619185746.26866-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190619185746.26866-1-stephen@networkplumber.org> References: <20190610175155.21374-1-stephen@networkplumber.org> <20190619185746.26866-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v3 4/8] kni: drop unused fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Stephen Hemminger The kni net structure only exists in driver no API/ABI. Several fields were either totally unused or set and never used. The fields in dev_info do need to stay in the ABI but kernel can ignore them. Signed-off-by: Stephen Hemminger kni: drop unused status element Yet another ethtool leftover. Signed-off-by: Stephen Hemminger --- kernel/linux/kni/kni_dev.h | 5 ----- kernel/linux/kni/kni_misc.c | 1 - 2 files changed, 6 deletions(-) diff --git a/kernel/linux/kni/kni_dev.h b/kernel/linux/kni/kni_dev.h index 21e4b0d92368..f3e6c3ca4efa 100644 --- a/kernel/linux/kni/kni_dev.h +++ b/kernel/linux/kni/kni_dev.h @@ -39,8 +39,6 @@ struct kni_dev { /* kni list */ struct list_head list; - int status; - uint16_t group_id; /* Group ID of a group of KNI devices */ uint32_t core_id; /* Core ID to bind */ char name[RTE_KNI_NAMESIZE]; /* Network device name */ struct task_struct *pthread; @@ -79,9 +77,6 @@ struct kni_dev { /* mbuf size */ uint32_t mbuf_size; - /* synchro for request processing */ - unsigned long synchro; - /* buffers */ void *pa[MBUF_BURST_SZ]; void *va[MBUF_BURST_SZ]; diff --git a/kernel/linux/kni/kni_misc.c b/kernel/linux/kni/kni_misc.c index 1fc5eeb9c8ca..b59cf24c2184 100644 --- a/kernel/linux/kni/kni_misc.c +++ b/kernel/linux/kni/kni_misc.c @@ -346,7 +346,6 @@ kni_ioctl_create(struct net *net, uint32_t ioctl_num, kni = netdev_priv(net_dev); kni->net_dev = net_dev; - kni->group_id = dev_info.group_id; kni->core_id = dev_info.core_id; strncpy(kni->name, dev_info.name, RTE_KNI_NAMESIZE); -- 2.20.1