From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 7533BA0471 for ; Wed, 19 Jun 2019 20:58:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AA1891D12D; Wed, 19 Jun 2019 20:58:12 +0200 (CEST) Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by dpdk.org (Postfix) with ESMTP id ACEC81D0EF for ; Wed, 19 Jun 2019 20:58:01 +0200 (CEST) Received: by mail-pl1-f194.google.com with SMTP id p1so202209plo.2 for ; Wed, 19 Jun 2019 11:58:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KIWdTWngvMzOCsjHwiLdXVCXjGw42l15HHKsPengMUk=; b=AEYEP+/jcnGHAoSfpSnYnMKABq+0iYKCVr5B+JAqIVl17MxLo0/6KEYdJqt5s37puv FqWdRYkJnQ0DbSJXn5WLfUizrNxGqiiZYfrYvv6+ghcyJz4UFjA7Uu6cUdwoSvTLD1lY PjhmAl7h2ESf8rKZokNyd/WRFKZQd6nrSfnl+SJ1/fnDfi8q1eVDV6dE/RdKaX7pYujd EtiAIR/jCMkiN3+HESPzJzsg7ZR1Uv2s6uqfholjBwomS4z73NPASvlzy6IKh23uhpYv aqLJbIXx+G8k6aKBwtsFPqi+ZBRKrArt+OMUBCa2hBBn7fRHjn2ADzs7K27E9xtSaNRx WRkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KIWdTWngvMzOCsjHwiLdXVCXjGw42l15HHKsPengMUk=; b=MT02QoGeiQulsaNgnQxfRVBThCZsHUGdZjncN5hMMNROoEZKhVYaUm9AoBD03JWAr9 Xk/6zl7yLBx+4RdJPa0l18ArYgU69oKqZkJvjJxapycCDHo3O1XUnDf0BHSszxJ6cKiL T5jNZCeR4Y0bubyMl6mDTkgQDMhoSKs8rhDjD4cevjNDzQCZdxmYFQi/AQlTI1DRxSSa hDrFMFOgbi+k5v5lC5i6PIeagZ4hfgWB/Dxr09DovXvOA39NxcD2D+mY4XsVziTDLTzA XRyxDUsZLWMmMgKb3hH7rkvHhtatp9rKloc5am62fVLLq90uz7hDV2vOTQkP+kGUqJXG B9Ig== X-Gm-Message-State: APjAAAXdKeTJLCts1OGm5f9AwhCEL+Z8E5TJMyEbnmgA6SConXvGgfSw foXilWE+qxBugdgSG5C9veAS8JBUREc= X-Google-Smtp-Source: APXvYqxIPKay/XCWBAU3BnnLnzY0gy6zD+5f17YuuRQor3Sfv424/gUWMwv1mj1r0WxkOuYiYOK2LQ== X-Received: by 2002:a17:902:f087:: with SMTP id go7mr94492745plb.330.1560970680712; Wed, 19 Jun 2019 11:58:00 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id b8sm24774858pff.20.2019.06.19.11.57.59 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 19 Jun 2019 11:57:59 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Stephen Hemminger Date: Wed, 19 Jun 2019 11:57:43 -0700 Message-Id: <20190619185746.26866-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190619185746.26866-1-stephen@networkplumber.org> References: <20190610175155.21374-1-stephen@networkplumber.org> <20190619185746.26866-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v3 5/8] kni: use proper type for kni fifo's X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Stephen Hemminger Using void * instead of proper type is unsafe practice. Signed-off-by: Stephen Hemminger --- kernel/linux/kni/kni_dev.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/kernel/linux/kni/kni_dev.h b/kernel/linux/kni/kni_dev.h index f3e6c3ca4efa..ceba5f73c1d9 100644 --- a/kernel/linux/kni/kni_dev.h +++ b/kernel/linux/kni/kni_dev.h @@ -51,22 +51,22 @@ struct kni_dev { struct net_device *net_dev; /* queue for packets to be sent out */ - void *tx_q; + struct rte_kni_fifo *tx_q; /* queue for the packets received */ - void *rx_q; + struct rte_kni_fifo *rx_q; /* queue for the allocated mbufs those can be used to save sk buffs */ - void *alloc_q; + struct rte_kni_fifo *alloc_q; /* free queue for the mbufs to be freed */ - void *free_q; + struct rte_kni_fifo *free_q; /* request queue */ - void *req_q; + struct rte_kni_fifo *req_q; /* response queue */ - void *resp_q; + struct rte_kni_fifo *resp_q; void *sync_kva; void *sync_va; -- 2.20.1