From: Tiwei Bie <tiwei.bie@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: Noa Ezra <noae@mellanox.com>, matan@mellanox.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] net/vhost: support TSO disabling
Date: Thu, 20 Jun 2019 10:26:09 +0800 [thread overview]
Message-ID: <20190620022609.GA4168@___> (raw)
In-Reply-To: <59325f03-2a0a-27a9-5995-bb60f22a98b5@redhat.com>
On Wed, Jun 19, 2019 at 11:53:05AM +0200, Maxime Coquelin wrote:
> On 6/19/19 8:13 AM, Noa Ezra wrote:
> > TSO (TCP Segmentation Offload) is enabled by default on vhost.
> > Add the ability to disable TSO on vhost.
> > The user should also disable the feature on the virtual machine's xml.
>
> For TSO, I think it make sense to have the option to disable it,
> as it requires the application to support it.
>
> I even wonder whether it should not be disabled by default.
> Any thoughts?
Agree, it looks better to disable it by default.
Thanks,
Tiwei
next prev parent reply other threads:[~2019-06-20 2:27 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 6:13 [dpdk-dev] [PATCH 0/2] support tso and mrg-rxbuf disabling Noa Ezra
2019-06-19 6:13 ` [dpdk-dev] [PATCH 1/2] net/vhost: support TSO disabling Noa Ezra
2019-06-19 9:53 ` Maxime Coquelin
2019-06-20 2:26 ` Tiwei Bie [this message]
2019-06-20 6:08 ` Matan Azrad
2019-06-20 7:25 ` Maxime Coquelin
2019-08-30 8:44 ` Maxime Coquelin
2019-09-30 9:02 ` Maxime Coquelin
2019-06-19 6:13 ` [dpdk-dev] [PATCH 2/2] net/vhost: support mrg-rxbuf disabling Noa Ezra
2019-06-19 9:10 ` Maxime Coquelin
2019-06-20 5:57 ` Noa Ezra
2019-06-20 6:52 ` Matan Azrad
2019-06-20 7:19 ` Maxime Coquelin
2019-06-20 7:55 ` Matan Azrad
2019-06-26 7:50 ` Matan Azrad
2019-06-26 10:27 ` Maxime Coquelin
2019-06-26 11:18 ` Matan Azrad
2019-06-26 12:05 ` Maxime Coquelin
2019-06-26 13:24 ` Matan Azrad
2019-06-26 14:17 ` Maxime Coquelin
2019-06-27 5:04 ` Matan Azrad
2019-08-30 8:48 ` Maxime Coquelin
2019-06-20 7:27 ` Maxime Coquelin
2019-09-30 9:04 ` Maxime Coquelin
2019-06-19 14:20 ` [dpdk-dev] [PATCH 0/2] support tso and " Aaron Conole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190620022609.GA4168@___ \
--to=tiwei.bie@intel.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=maxime.coquelin@redhat.com \
--cc=noae@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).