From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id CD548A0471 for ; Thu, 20 Jun 2019 04:27:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2D4C91D06D; Thu, 20 Jun 2019 04:27:25 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 227BA1D06B for ; Thu, 20 Jun 2019 04:27:23 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jun 2019 19:27:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,395,1557212400"; d="scan'208";a="186665635" Received: from npg-dpdk-virtio-tbie-2.sh.intel.com (HELO ___) ([10.67.104.151]) by fmsmga002.fm.intel.com with ESMTP; 19 Jun 2019 19:27:21 -0700 Date: Thu, 20 Jun 2019 10:26:09 +0800 From: Tiwei Bie To: Maxime Coquelin Cc: Noa Ezra , matan@mellanox.com, dev@dpdk.org Message-ID: <20190620022609.GA4168@___> References: <1560924825-220648-1-git-send-email-noae@mellanox.com> <1560924825-220648-2-git-send-email-noae@mellanox.com> <59325f03-2a0a-27a9-5995-bb60f22a98b5@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <59325f03-2a0a-27a9-5995-bb60f22a98b5@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH 1/2] net/vhost: support TSO disabling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jun 19, 2019 at 11:53:05AM +0200, Maxime Coquelin wrote: > On 6/19/19 8:13 AM, Noa Ezra wrote: > > TSO (TCP Segmentation Offload) is enabled by default on vhost. > > Add the ability to disable TSO on vhost. > > The user should also disable the feature on the virtual machine's xml. > > For TSO, I think it make sense to have the option to disable it, > as it requires the application to support it. > > I even wonder whether it should not be disabled by default. > Any thoughts? Agree, it looks better to disable it by default. Thanks, Tiwei