From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 71A0EA0471 for ; Thu, 20 Jun 2019 12:30:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 018D81D363; Thu, 20 Jun 2019 12:30:11 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 24FC01D189 for ; Thu, 20 Jun 2019 12:30:08 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jun 2019 03:30:08 -0700 X-IronPort-AV: E=Sophos;i="5.63,396,1557212400"; d="scan'208";a="150886516" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jun 2019 03:30:04 -0700 Date: Thu, 20 Jun 2019 11:30:01 +0100 From: Bruce Richardson To: Aaron Conole Cc: Nikos Dragazis , dev@dpdk.org, Maxime Coquelin , Tiwei Bie , Zhihong Wang , Stefan Hajnoczi , Wei Wang , Stojaczyk Dariusz , Vangelis Koukis Message-ID: <20190620103001.GD728@bricha3-MOBL.ger.corp.intel.com> References: <1560957293-17294-1-git-send-email-ndragazis@arrikto.com> <1560957293-17294-2-git-send-email-ndragazis@arrikto.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH 01/28] vhost: introduce vhost transport operations structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jun 19, 2019 at 04:14:09PM -0400, Aaron Conole wrote: > Nikos Dragazis writes: > > > This is the first of a series of patches, whose purpose is to add > > support for the virtio-vhost-user transport. This is a vhost-user > > transport implementation that is different from the default AF_UNIX > > transport. It uses the virtio-vhost-user PCI device in order to tunnel > > vhost-user protocol messages over virtio. This lets guests act as vhost > > device backends for other guests. > > > > File descriptor passing is specific to the AF_UNIX vhost-user protocol > > transport. In order to add support for additional transports, it is > > necessary to extract transport-specific code from the main vhost-user > > code. > > > > This patch introduces struct vhost_transport_ops and associates each > > device with a transport. Core vhost-user code calls into > > vhost_transport_ops to perform transport-specific operations. > > > > Notifying callfd is a transport-specific operation, so it belongs to > > trans_af_unix.c. > > > > Several more patches follow this one to complete the task of moving > > AF_UNIX transport code out of core vhost-user code. > > > > Signed-off-by: Nikos Dragazis > > Signed-off-by: Stefan Hajnoczi > > --- > > You'll need to also accommodate the meson build - probably with > something like: > > diff --git a/lib/librte_vhost/meson.build b/lib/librte_vhost/meson.build > index 3090bbe08..81b70683b 100644 > --- a/lib/librte_vhost/meson.build > +++ b/lib/librte_vhost/meson.build > @@ -14,6 +14,6 @@ allow_experimental_apis = true > cflags += '-fno-strict-aliasing' > sources = files('fd_man.c', 'iotlb.c', 'socket.c', 'vdpa.c', > 'vhost.c', 'vhost_user.c', > - 'virtio_net.c', 'vhost_crypto.c') > + 'virtio_net.c', 'vhost_crypto.c', 'trans_af_unix.c') > headers = files('rte_vhost.h', 'rte_vdpa.h', 'rte_vhost_crypto.h') > deps += ['ethdev', 'cryptodev', 'hash', 'pci'] > > Yep, except I think we should try and keep the files in alphabetical order, with only a couple of entries per line [so place trans_af_unix.c on a new line with vdpa.c].