From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D32AAA0471 for ; Thu, 20 Jun 2019 21:21:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 505B01D468; Thu, 20 Jun 2019 21:21:01 +0200 (CEST) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 9EA771D453 for ; Thu, 20 Jun 2019 21:20:58 +0200 (CEST) Received: by mail-pg1-f196.google.com with SMTP id s27so2090574pgl.2 for ; Thu, 20 Jun 2019 12:20:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lx7mNNtKZOJfi54i/SUlINrC4myA0zQHh+IpidBgz5c=; b=ivERizRALsy4X62qu2PCD3LkmDNxomhLFrrnU1prfmG+hyCS0qgVUGwMd5w4WUnAK7 pc4FEN7gZ0Szfzp+fo0xZkHY2/wVEkEgTwlY6Xjr10dWXWjtEs4n9dKHyzmg5r7rG1cm ha7b6Ej5Pf8Rc8bCvs29K/p0zZSql2UsLakJ9xFbCzDe608fDJSRg9POVeRTqdX5Vb3V KD9UxmhOM3muEdykiP6rlVC1LV9NwIYcSizwzZAW7Y+PZQkn3NDv7naZhBNmK0zEgSQ3 NeE53kUkrtC/Wi/tO7JfJIp4CyV3qmRmMetqq/tP4KZDL5gdpMB4Rpv5XCBDRNKgVduN 8o4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lx7mNNtKZOJfi54i/SUlINrC4myA0zQHh+IpidBgz5c=; b=AT0GZkIDa30VGwNPbfKHpiYYJxMV4N/OPgbHgxBY5AFWiVGoyYXTLjf8v0jcnPWpSm n0ok0zTnVKqm4lAa+Yhkzf2a/WCjSqNKolu/yVeLW1BL7oUFarG8fb54Nca005QjJ/12 nMgPVu88qJbYz0bCRUbtfhddSg/L5iXwArRFa64rAOH885Pt90g//vT3xPBOFb/Ors1Y weC+eAAdgqS0jrYuG5UJxJ9XFB29QxpLDYAzUicxVD8lExk2me/k9aquySaAYttLpfFE wrEXUpXUlSZW2Bd5kTvLbCaHV7uQECv2b9vzctvpOz+qR4FRZ0n+Ve7XoHOkFOqSkXBf v0wg== X-Gm-Message-State: APjAAAW/r605RjM5ySIHn3HCR5faQutYy6kwP2sZEvSDzr+VS3FpVCkt yl9SetTA1SY0djtWLMuajZ1oot+aRdQ= X-Google-Smtp-Source: APXvYqwKg0QX4PFoEXuDwqmIl5kNhN6Vf+p8fM78NdR+tYaIwvdSx+d8oJiLk56nWEGWIOq+H9Hi5A== X-Received: by 2002:a63:9d43:: with SMTP id i64mr13174848pgd.404.1561058457451; Thu, 20 Jun 2019 12:20:57 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id j11sm255703pfa.2.2019.06.20.12.20.55 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 20 Jun 2019 12:20:56 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Thu, 20 Jun 2019 12:20:40 -0700 Message-Id: <20190620192048.13814-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190620192048.13814-1-stephen@networkplumber.org> References: <20190610175155.21374-1-stephen@networkplumber.org> <20190620192048.13814-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v5 1/9] kni: don't need stubs for rx_mode or ioctl X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The netdev subsystem already handles case where network sevice does not support ioctl. If device has no rx_mode hook it is not called. Signed-off-by: Stephen Hemminger --- kernel/linux/kni/kni_net.c | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c index ad8365877cda..c86337d099ab 100644 --- a/kernel/linux/kni/kni_net.c +++ b/kernel/linux/kni/kni_net.c @@ -593,23 +593,6 @@ kni_net_tx_timeout(struct net_device *dev) netif_wake_queue(dev); } -/* - * Ioctl commands - */ -static int -kni_net_ioctl(struct net_device *dev, struct ifreq *rq, int cmd) -{ - pr_debug("kni_net_ioctl group:%d cmd:%d\n", - ((struct kni_dev *)netdev_priv(dev))->group_id, cmd); - - return -EOPNOTSUPP; -} - -static void -kni_net_set_rx_mode(struct net_device *dev) -{ -} - static int kni_net_change_mtu(struct net_device *dev, int new_mtu) { @@ -758,8 +741,6 @@ static const struct net_device_ops kni_net_netdev_ops = { .ndo_change_rx_flags = kni_net_set_promiscusity, .ndo_start_xmit = kni_net_tx, .ndo_change_mtu = kni_net_change_mtu, - .ndo_do_ioctl = kni_net_ioctl, - .ndo_set_rx_mode = kni_net_set_rx_mode, .ndo_get_stats = kni_net_stats, .ndo_tx_timeout = kni_net_tx_timeout, .ndo_set_mac_address = kni_net_set_mac, -- 2.20.1