From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 54184A046B for ; Mon, 24 Jun 2019 17:23:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1BAF61BD74; Mon, 24 Jun 2019 17:23:47 +0200 (CEST) Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id 3263E1BD26 for ; Mon, 24 Jun 2019 17:23:46 +0200 (CEST) Received: by mail-pg1-f194.google.com with SMTP id 196so7293600pgc.6 for ; Mon, 24 Jun 2019 08:23:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MXz3yu12huQ36gAw/Y/9kbGZAagt+5O3w2Q/cv4NTV4=; b=1E1GOhMOC2NTmGYJzBva21MHPR1l/hkn8LFD2cS9RxfCiwdNux6wJ8tnLoa2ozZioJ KGiMJQxSdOlST+IYnsk0RI5vaMkIGT2QmrvMto2rGnskbA/Kyt/S/mRBSUdCMIXsN2mR 9rg/KG3GqHc4WNj2WgB44iAm34Mp54NsXZ2dJNw2nJkLUZuSGhulAvVz1P+tYoDAZQ6O GWdLB/hLbTONps0VbWeDn3uBl2vYj13LQxA3UwXF3IY7r9Eh9wgZ9Y/ct68wdkMGB4pp cFFFVmUj3Qx8FS91LfXAP+6iAhIjBipqd2ywLPepxyritvVlBYNCjMg6M+SZCOPbMeJY p1Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MXz3yu12huQ36gAw/Y/9kbGZAagt+5O3w2Q/cv4NTV4=; b=WB0xBSe+moU1os8PTJwzSP3g4lE/iD8KbOXJb68O+WRgfhR6BNkpxBb3GDy49H67sX jCewzZhrub1fv8wrN2PlSPmkCnWNzaU1kUuw9BRPVGTDaIF3rnKQIU17pBbcWu0iNhRm PvwPlRObYvpUgX04lCQ4wiRZZDFzO57ASZl/ov3rPSpygoka5Di+JdEUklpgFPiwxcb6 qTpUQzY+x5XvPO6k5cimYX5eB5UKw2IMqyoaeB/UqNWU2gUOe/sOFVPS7y751qqLm+mC liWRCMDlajUEI0B8BlvOASeIuJ+D2LzlSpglKvuSum/yK9XYTV8aulhZ+4nEEYwBVgpy uaHg== X-Gm-Message-State: APjAAAVIth/nLLDC/qR66UlWSmdKd79Eii4A9FSANxTuW8l8QpTkxkzv 8V9ogaenD5eiC5WmH+IJzfix52ZU7UY= X-Google-Smtp-Source: APXvYqw9jFNVHYUCBrUbVgCE0sD4R0/R/0dmXn2CmEsAivaLXqkYEo4JXhCuulecEI07oOTy0cRYtQ== X-Received: by 2002:a63:205b:: with SMTP id r27mr33946822pgm.330.1561389825240; Mon, 24 Jun 2019 08:23:45 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id r1sm13845144pfq.100.2019.06.24.08.23.44 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 24 Jun 2019 08:23:44 -0700 (PDT) Date: Mon, 24 Jun 2019 08:23:38 -0700 From: Stephen Hemminger To: =?UTF-8?B?R2HDq3Rhbg==?= Rivet Cc: dev@dpdk.org Message-ID: <20190624082338.3ddfc6fa@hermes.lan> In-Reply-To: <20190624081558.bsu3j2inahwumlzj@bidouze.vm.6wind.com> References: <20190621220824.18073-1-stephen@networkplumber.org> <20190624081558.bsu3j2inahwumlzj@bidouze.vm.6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] failsafe: skip devargs if not present in secondary X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 24 Jun 2019 10:15:58 +0200 Ga=C3=ABtan Rivet wrote: > Hello Stephen, >=20 > On Fri, Jun 21, 2019 at 03:08:24PM -0700, Stephen Hemminger wrote: > > When secondary process is run was noticing that the log always > > contained complaints about unable to parse devargs. > >=20 > > It turns out that an empty devargs turns into "" and this > > value is not parsable. Change the failsafe secondary to just > > skip doing devargs if it empty. > > =20 >=20 > Commit log needs a little rework, a few typos. >=20 > > Signed-off-by: Stephen Hemminger > > --- > > drivers/net/failsafe/failsafe.c | 4 ++++ > > 1 file changed, 4 insertions(+) > >=20 > > diff --git a/drivers/net/failsafe/failsafe.c b/drivers/net/failsafe/fai= lsafe.c > > index e91c274d8059..04ca0cab0d78 100644 > > --- a/drivers/net/failsafe/failsafe.c > > +++ b/drivers/net/failsafe/failsafe.c > > @@ -364,6 +364,10 @@ rte_pmd_failsafe_probe(struct rte_vdev_device *vde= v) > > * A sub-device can be plugged later. > > */ > > FOREACH_SUBDEV(sdev, i, eth_dev) { > > + /* skip empty devargs */ > > + if (sdev->devargs.name[0] =3D=3D '\0') > > + continue; > > + =20 >=20 > An empty devargs being named "" is part of the internals of rte_devargs. > The clean solution would be to add a `bool rte_devargs_empty()` function > and test the devargs with it. >=20 > The simple solution is your proposition. >=20 > Clean seems a little heavy-handed, but it would be more stable. If you > agree, you can add the helper. I'm ok with keeping it simple otherwise. >=20 > > /* rebuild devargs to be able to get the bus name. */ > > ret =3D rte_devargs_parse(&devargs, > > sdev->devargs.name); > > --=20 > > 2.20.1 > > =20 >=20 Simpler is better. Sorry, after working with failsafe my impression is that it is not built with that in mind.