From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id E060DA046B
	for <public@inbox.dpdk.org>; Mon, 24 Jun 2019 22:45:45 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 17A501BCA0;
	Mon, 24 Jun 2019 22:45:04 +0200 (CEST)
Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com
 [209.85.214.195]) by dpdk.org (Postfix) with ESMTP id 80F771BC00
 for <dev@dpdk.org>; Mon, 24 Jun 2019 22:44:52 +0200 (CEST)
Received: by mail-pl1-f195.google.com with SMTP id g4so7534955plb.5
 for <dev@dpdk.org>; Mon, 24 Jun 2019 13:44:52 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=i8sEf2BqVxRRW7Hf5r4EMIM/xDPKtZVL0Pik8O21io8=;
 b=LeEFFLCSvl0BIbMHmWZblM2v2I8Oy4QWcuD7n9WRsZ2caBuk1ogjkEAqE+E9+ogycM
 xCUA4CdQQ2XELQAbQwIAKeeZMyfBF1l4wChMcabICi4qpiWHRQst4j5mtPu/FmuvjBdm
 VbuIQ2HNiNti2OsBCtw9F9Zt2wugk8WsD8A2Xzqwam2YYrHG/IHtcTKwviAr7GkSw7TI
 eind4+3MYBFGpKVP6xpf7JJrVpJmsooyZChtwaBGjzN/aWUkNv8k50ZKpL/OYG7EYEBc
 nyrQxse1QBYywNzLD894S+OH75WUuBhdGw5V/LpGK7ifju/I1FBY4sOmpbPXFNXw9fdH
 rslA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=i8sEf2BqVxRRW7Hf5r4EMIM/xDPKtZVL0Pik8O21io8=;
 b=HBf6a/pVPX6t7upuT5+p1EX4aQbiBzgorcKFcSbGuQQx4YKuTT5Nc8GQzdWXWpHi0l
 KxiNr/E4eT+D7bAe0IAcGfMmePjnqVBj7Yb7ewumxPiZZs1xB4POorVOAFCPXcjvCsJ9
 vycEPuhO69b1u08bJxpsas4q95H1QEH0/JhGjs2r5WFGmMqTwOR2GUk4+EpIBiU8uKsp
 U0CLQ+8Zmxc6kozvGdiIzyTuUK2o0HbuIKfTlSMVtHZXJH9LxiGapZGMJz5BFKHrWVYu
 v9urEpL+vtHlBg1uf12TNgJTPvfpJ/bTpTEvivf4MlwOlFtHfXHeP+i5muiDddHYjbOA
 ncQg==
X-Gm-Message-State: APjAAAVB/ZsyoeWgqrfhAUfesd9DNtgbI5StveWQgSyjuJda13MI+1uh
 3i0vehnwkkUJ9sLmqwkjU2KvmmivDFI=
X-Google-Smtp-Source: APXvYqyEcI/97PaPqq1lAJ578BMBDL81LmFUZOScc02qE/hXPB+NbyRWiPm5GWcwKowWb3zZ1r1IAw==
X-Received: by 2002:a17:902:704a:: with SMTP id
 h10mr41854781plt.337.1561409091399; 
 Mon, 24 Jun 2019 13:44:51 -0700 (PDT)
Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])
 by smtp.gmail.com with ESMTPSA id q144sm22061498pfc.103.2019.06.24.13.44.50
 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);
 Mon, 24 Jun 2019 13:44:50 -0700 (PDT)
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Date: Mon, 24 Jun 2019 13:44:34 -0700
Message-Id: <20190624204435.29452-8-stephen@networkplumber.org>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20190624204435.29452-1-stephen@networkplumber.org>
References: <20190516180427.17270-1-stephen@networkplumber.org>
 <20190624204435.29452-1-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: [dpdk-dev] [PATCH v5 7/8] net/bonding: use new ethernet address
	parser
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

The cmdline library used to be the only way to parse a
mac address. Now there is rte_ether_unformat_addr.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/bonding/Makefile            | 2 +-
 drivers/net/bonding/meson.build         | 2 +-
 drivers/net/bonding/rte_eth_bond_args.c | 6 +-----
 3 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/net/bonding/Makefile b/drivers/net/bonding/Makefile
index 1893e3cad313..26c1782554cd 100644
--- a/drivers/net/bonding/Makefile
+++ b/drivers/net/bonding/Makefile
@@ -12,7 +12,7 @@ CFLAGS += -DALLOW_EXPERIMENTAL_API
 CFLAGS += -O3
 CFLAGS += $(WERROR_FLAGS)
 LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
-LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs -lrte_cmdline
+LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs
 LDLIBS += -lrte_pci -lrte_bus_pci
 LDLIBS += -lrte_bus_vdev
 
diff --git a/drivers/net/bonding/meson.build b/drivers/net/bonding/meson.build
index 00374edb2a9d..6267210adf5f 100644
--- a/drivers/net/bonding/meson.build
+++ b/drivers/net/bonding/meson.build
@@ -8,6 +8,6 @@ sources = files('rte_eth_bond_api.c', 'rte_eth_bond_pmd.c', 'rte_eth_bond_flow.c
 	'rte_eth_bond_args.c', 'rte_eth_bond_8023ad.c', 'rte_eth_bond_alb.c')
 
 deps += 'sched' # needed for rte_bitmap.h
-deps += ['ip_frag', 'cmdline']
+deps += ['ip_frag']
 
 install_headers('rte_eth_bond.h', 'rte_eth_bond_8023ad.h')
diff --git a/drivers/net/bonding/rte_eth_bond_args.c b/drivers/net/bonding/rte_eth_bond_args.c
index 01bbb06c1a84..936440fb8491 100644
--- a/drivers/net/bonding/rte_eth_bond_args.c
+++ b/drivers/net/bonding/rte_eth_bond_args.c
@@ -7,9 +7,6 @@
 #include <rte_bus_pci.h>
 #include <rte_kvargs.h>
 
-#include <cmdline_parse.h>
-#include <cmdline_parse_etheraddr.h>
-
 #include "rte_eth_bond.h"
 #include "rte_eth_bond_private.h"
 
@@ -281,8 +278,7 @@ bond_ethdev_parse_bond_mac_addr_kvarg(const char *key __rte_unused,
 		return -1;
 
 	/* Parse MAC */
-	return cmdline_parse_etheraddr(NULL, value, extra_args,
-		sizeof(struct rte_ether_addr));
+	return rte_ether_unformat_addr(value, extra_args);
 }
 
 int
-- 
2.20.1