From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C055AA046B for ; Thu, 27 Jun 2019 01:09:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3C80F2C5E; Thu, 27 Jun 2019 01:09:19 +0200 (CEST) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id AEE412BF7 for ; Thu, 27 Jun 2019 01:09:17 +0200 (CEST) Received: by mail-pg1-f196.google.com with SMTP id v9so60870pgr.13 for ; Wed, 26 Jun 2019 16:09:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=r1Cc39E86RiS52sYYqc/k/RAReNKPeoccbaqtA8cAGY=; b=MxKDbBrms2EoIuk7w+XvUMlyGovGFyJag+U+bjc3JomcEpM5NnvvtVdzWo4CiJkS+9 3cLo8eOX7ALwUr8MkN34cRSgHwTp0ljzgb49XFNsf0XAu2cmI1qEnmSCq4lZg/uHmlPi r22d9D5e49clvIP+0y6aMvNgS33p5NQVyBlJBfaXw22AyZMGETkb2PsljI/hd52FI5e+ Kq+zgIEOnN2/j+b93YtPbKxYoOrv6yfgC9kaBWF9fUhelNSb53TkE5JZldUauw1NTGB3 0mwpL+mIE9xVIP5C/slPt0M+wsCUpULdd0CkDJ2GomzQY6KboiC2Gt4cfLVJpEm9zi7V Wh2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=r1Cc39E86RiS52sYYqc/k/RAReNKPeoccbaqtA8cAGY=; b=cWEDAf8aH4REeONUgIpQYOXu+2v31uC9fh55cGXZeOzVqMu2sluaSnOx7njmEoMG0v 0RgjmYFct8QWKctarDSRpHvRW19JkHeXDQZMEcW0PEj/pBRCszzVLHV57rL+M6rsCooP w2q3a/79hNhqKmOjMHX6aSbPcQg+jl5tvU/xp+zhkMXCR9Xsgynq4syMIpDCMp2/b35e KNoClAzUqDM7dFBdQ+0iA5wgCjvkGXu8Mh7aijbBsCQsROPt13jdB/QtfnXypOz1S+Uz +tcuauGK1zDM1X/Yyud+Opv6PI6bxK4AMa3MaOm+Q3vbCDv1SsnPK+U7+SQh33e8uOEz 7K/w== X-Gm-Message-State: APjAAAVlMg0bZ/SXnz64Gmho9YpZM8uL23ZT98L3EF/2DgMZWFyPoG8T FF2EoSDKJLfN5Z0u5LST5yRxxAEknNo= X-Google-Smtp-Source: APXvYqw4kM3MTZRbACF2hx7oD8GBs/Gwkn84Lw0ED8sEv1mjb9By4UHi2OT4iBpFfm2/33GbOoI4zg== X-Received: by 2002:a65:62c2:: with SMTP id m2mr421719pgv.413.1561590556861; Wed, 26 Jun 2019 16:09:16 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id a21sm334464pfi.27.2019.06.26.16.09.16 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 26 Jun 2019 16:09:16 -0700 (PDT) Date: Wed, 26 Jun 2019 16:09:10 -0700 From: Stephen Hemminger To: Thomas Monjalon Cc: dev@dpdk.org, david.marchand@redhat.com, stable@dpdk.org Message-ID: <20190626160910.5cb109fe@hermes.lan> In-Reply-To: <20190626140234.12394-1-thomas@monjalon.net> References: <20190626104056.26829-1-thomas@monjalon.net> <20190626140234.12394-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] eal/linux: fix return after alarm registration failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 26 Jun 2019 16:02:34 +0200 Thomas Monjalon wrote: > When adding an alarm, if an error happen when registering > the common alarm callback, it is not considered as a major failure. > The alarm is then inserted in the list. > However it was returning an error code after inserting the alarm. > > The error code is not set anymore to be consistent with the behaviour. > > Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org > > Signed-off-by: Thomas Monjalon > --- > v2: do not use variable ret Acked-by: Stephen Hemminger