From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CFE8DA046B for <public@inbox.dpdk.org>; Thu, 27 Jun 2019 17:36:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9DA84325F; Thu, 27 Jun 2019 17:36:12 +0200 (CEST) Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id 335CC2BF7 for <dev@dpdk.org>; Thu, 27 Jun 2019 17:36:11 +0200 (CEST) Received: by mail-pf1-f196.google.com with SMTP id d126so1426957pfd.2 for <dev@dpdk.org>; Thu, 27 Jun 2019 08:36:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hbRmRgTcqHYC76XTaDQ8qxJIp5jVSVtG7QL/G1P3J+0=; b=q+7p5NTGe/VjqJ/Znl0hfKdDj4uWW4l7zhQ3FAIJbSE9tRfE71KCh4Rr5gcjP97kLe JsPdDPFD6rPdjI8EfEg4CTBmjaiqql/AkiUJtYZj8igLv5oXos8/jAmYG83O2DhMI5Ar OWLBQyspBWQyGBS6H3/cQ7B9/MSM2+OyV0MnFOeflyKszZCrBgUET7VZ3yAPlnR2QkJz YLZdh7RXxIfzZbW+AQ0eNhnVYQkJujtLpRuxsqr107muBg8bE61lRmo6S5C+Lgb55Yvw fxNkMn7aI4TIXFvU+5iRlbTSkD+Z01o5ia+C/Qj5YSuCaplXG5KUCb0EL4tp3wqMCBB8 IJ6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hbRmRgTcqHYC76XTaDQ8qxJIp5jVSVtG7QL/G1P3J+0=; b=lNjWGx+xv/YUC7QB/8HKltc4QmWYM82BGe40xZskELrRGZrtcsC24aMS2mrQVoOpM4 kBDENyZXwVAWDKA7kaG6Q2g6oOnO79SsQ3cHSvJGBdy7wakUiqZUCKcnlEnmQPN9pOhp uQqvfExvhGXzihu/YO6f7ui3m4iS+ZqoV/Tg0ne/Bf8oVfR1EXsCqko2iwj7Wvp4klw2 /r812e0++gtQdgiEn3123o/da/HchecfQKiYtPdpYv+rR66aZQAJPFFe7jxmzoWTiRsQ NRS3E6ktCdqMHlZtPqZZYaCclmVmwgvbfGWPOL+ROIBSyDe7G4/AGmtjJK5ulat5sNMt Lh3g== X-Gm-Message-State: APjAAAUofOTEnxaWrvw0niAe5moyvK0KnqGSFiendoFHbed+2Rjy3FOm hUbu/urbBbpp4/1Cv55NQh2R2A== X-Google-Smtp-Source: APXvYqxAZfPlpPdB2KakjR0nhPjel4QBgPYZNevOfn1RwEI+oGTysjDKSfDKE6ishY3SANnmhGYSqA== X-Received: by 2002:a63:5202:: with SMTP id g2mr4356120pgb.386.1561649770179; Thu, 27 Jun 2019 08:36:10 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id t96sm5682026pjb.1.2019.06.27.08.36.09 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 27 Jun 2019 08:36:10 -0700 (PDT) Date: Thu, 27 Jun 2019 08:36:03 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: Anatoly Burakov <anatoly.burakov@intel.com> Cc: dev@dpdk.org, david.marchand@redhat.com, thomas@monjalon.net Message-ID: <20190627083603.3ee1e172@hermes.lan> In-Reply-To: <cover.1561635481.git.anatoly.burakov@intel.com> References: <cover.1561478388.git.anatoly.burakov@intel.com> <cover.1561635481.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 00/14] Make shared memory config non-public X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Thu, 27 Jun 2019 12:38:55 +0100 Anatoly Burakov <anatoly.burakov@intel.com> wrote: > This patchset removes the shared memory config from public > API, and replaces all usages of said config with new API > calls. > > A lot of the patchset is a search-and-replace job and should > be pretty easy to review. The rest are pretty trivial EAL > changes. > > This patchset depends on FreeBSD fixes patchset: > > http://patches.dpdk.org/project/dpdk/list/?series=5196 > > v3: > - Rebase on top of latest master > > v2: > - Collapsed all changes into fewer patches > - Addressed review comments > - Created a new file to store the code > - Changed namespace to "rte_mcfg_" > - Added some unification around config init > - Removed "packed" attribute from mem config > - Removed unnecessary inlining > - Added a check to explicitly forbid running multiprocess > applications that differ in their DPDK versions > > Anatoly Burakov (14): > eal: add API to lock/unlock memory hotplug > drivers: use new memory locking API > lib: use new memory locking API > eal: add EAL tailq list lock/unlock API > lib: use new tailq locking API > eal: add new API to lock/unlock mempool list > mempool: use new mempool list locking API > eal: remove unused macros > eal: hide shared memory config > eal: remove packed attribute from mcfg structure > eal: uninline wait for mcfg complete function > eal: unify and move mcfg complete function > eal: unify internal config initialization > eal: prevent different primary/secondary process versions > > app/test/test_memzone.c | 1 + > app/test/test_tailq.c | 1 + > doc/guides/rel_notes/deprecation.rst | 3 - > doc/guides/rel_notes/release_19_08.rst | 8 +- > drivers/bus/fslmc/fslmc_vfio.c | 8 +- > drivers/bus/pci/linux/pci_vfio.c | 1 + > drivers/net/mlx4/mlx4_mr.c | 11 +- > drivers/net/mlx5/mlx5_mr.c | 11 +- > .../net/virtio/virtio_user/virtio_user_dev.c | 7 +- > lib/librte_acl/rte_acl.c | 20 +-- > lib/librte_distributor/rte_distributor.c | 5 +- > lib/librte_distributor/rte_distributor_v20.c | 5 +- > lib/librte_eal/common/eal_common_mcfg.c | 149 ++++++++++++++++++ > lib/librte_eal/common/eal_common_memory.c | 44 +++--- > lib/librte_eal/common/eal_common_memzone.c | 1 + > lib/librte_eal/common/eal_common_tailqs.c | 5 +- > lib/librte_eal/common/eal_memcfg.h | 93 +++++++++++ > lib/librte_eal/common/include/rte_eal.h | 10 -- > .../common/include/rte_eal_memconfig.h | 143 +++++++++-------- > lib/librte_eal/common/malloc_heap.c | 16 +- > lib/librte_eal/common/malloc_mp.c | 1 + > lib/librte_eal/common/meson.build | 1 + > lib/librte_eal/common/rte_malloc.c | 33 ++-- > lib/librte_eal/freebsd/eal/Makefile | 3 +- > lib/librte_eal/freebsd/eal/eal.c | 22 ++- > lib/librte_eal/freebsd/eal/eal_memory.c | 1 + > lib/librte_eal/linux/eal/Makefile | 3 +- > lib/librte_eal/linux/eal/eal.c | 42 ++--- > lib/librte_eal/linux/eal/eal_memalloc.c | 1 + > lib/librte_eal/linux/eal/eal_memory.c | 1 + > lib/librte_eal/linux/eal/eal_vfio.c | 17 +- > lib/librte_eal/meson.build | 2 +- > lib/librte_eal/rte_eal_version.map | 12 ++ > lib/librte_efd/rte_efd.c | 15 +- > lib/librte_eventdev/rte_event_ring.c | 16 +- > lib/librte_hash/rte_cuckoo_hash.c | 17 +- > lib/librte_hash/rte_fbk_hash.c | 15 +- > lib/librte_kni/rte_kni.c | 16 +- > lib/librte_lpm/rte_lpm.c | 25 +-- > lib/librte_lpm/rte_lpm6.c | 15 +- > lib/librte_member/rte_member.c | 17 +- > lib/librte_mempool/rte_mempool.c | 27 ++-- > lib/librte_reorder/rte_reorder.c | 15 +- > lib/librte_ring/rte_ring.c | 19 +-- > lib/librte_stack/rte_stack.c | 18 +-- > 45 files changed, 566 insertions(+), 330 deletions(-) > create mode 100644 lib/librte_eal/common/eal_common_mcfg.c > create mode 100644 lib/librte_eal/common/eal_memcfg.h > This looks good thanks. Acked-by: Stephen Hemminger <stephen@networkplumber.org>