From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35331A046B for ; Fri, 28 Jun 2019 23:22:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B855E4CC0; Fri, 28 Jun 2019 23:22:05 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 330014CA9 for ; Fri, 28 Jun 2019 23:22:03 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Jun 2019 14:22:03 -0700 X-IronPort-AV: E=Sophos;i="5.63,429,1557212400"; d="scan'208";a="167877232" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.21.39]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Jun 2019 14:22:01 -0700 Date: Fri, 28 Jun 2019 22:21:58 +0100 From: Bruce Richardson To: "Pattan, Reshma" Cc: "dev@dpdk.org" , "thomas@monjalon.net" , "jerinj@marvell.com" Message-ID: <20190628212158.GE366@bricha3-MOBL.ger.corp.intel.com> References: <20190530212525.40370-1-bruce.richardson@intel.com> <20190627104055.8244-1-bruce.richardson@intel.com> <20190627104055.8244-7-bruce.richardson@intel.com> <3AEA2BF9852C6F48A459DA490692831F2A48844C@irsmsx110.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A48844C@irsmsx110.ger.corp.intel.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH v3 6/8] raw/ioat: add configure, start and stop functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jun 27, 2019 at 05:37:33PM +0100, Pattan, Reshma wrote: > > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson > > Sent: Thursday, June 27, 2019 11:41 AM > > To: dev@dpdk.org > > Cc: thomas@monjalon.net; jerinj@marvell.com; Richardson, Bruce > > > > Subject: [dpdk-dev] [PATCH v3 6/8] raw/ioat: add configure, start and stop > > functions > > > > > +int ioat_rawdev_test(uint16_t dev_id); > > + > > static int > > ioat_rawdev_create(const char *name, struct rte_pci_device *dev) { > > static const struct rte_rawdev_ops ioat_rawdev_ops = { > > + .dev_configure = ioat_dev_configure, > > + .dev_start = ioat_dev_start, > > + .dev_stop = ioat_dev_stop, > > .dev_info_get = ioat_dev_info_get, > > + .dev_selftest = ioat_rawdev_test, > > Build fail for ./devtools/test-build.sh x86_64-native-linux-gcc+next+shared > /drivers/raw/ioat/ioat_rawdev.c: In function 'ioat_rawdev_create': > drivers/raw/ioat/ioat_rawdev.c:163:20: error: initialization of 'int (*)(void)' from incompatible pointer type 'int (*)(uint16_t)' {aka 'int (*)(short unsigned int)'} [-Werror=incompatible-pointer-types] > 163 | .dev_selftest = ioat_rawdev_test, > Apologies, I forgot to put in the cover letter that this depends upon the rawdev patchset I previously upstreamed: http://patches.dpdk.org/project/dpdk/list/?series=5120