From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7BBC9A0487 for ; Mon, 1 Jul 2019 10:15:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8B2A82AB; Mon, 1 Jul 2019 10:15:22 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id F21F323D for ; Mon, 1 Jul 2019 10:15:20 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Jul 2019 01:15:19 -0700 X-IronPort-AV: E=Sophos;i="5.63,438,1557212400"; d="scan'208";a="168393431" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Jul 2019 01:15:18 -0700 Date: Mon, 1 Jul 2019 09:15:14 +0100 From: Bruce Richardson To: Slava Ovsiienko Cc: "Iremonger, Bernard" , "dev@dpdk.org" , "Yigit, Ferruh" Message-ID: <20190701081514.GA380@bricha3-MOBL.ger.corp.intel.com> References: <1561553317-16777-1-git-send-email-viacheslavo@mellanox.com> <20190626125732.GC862@bricha3-MOBL.ger.corp.intel.com> <20190626132124.GD862@bricha3-MOBL.ger.corp.intel.com> <8CEF83825BEC744B83065625E567D7C260DBE4EB@IRSMSX108.ger.corp.intel.com> <20190628142012.GA366@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH] app/testpmd: add profiling for Rx/Tx burst routines X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jul 01, 2019 at 04:57:30AM +0000, Slava Ovsiienko wrote: > I think we should compromise: keep existing RTE_TEST_PMD_RECORD_CORE_CYCLES > and extend with runtime switch under this build-time option: > > #ifdef RTE_TEST_PMD_RECORD_CORE_CYCLES > if (record_tx) > .. gather tx related stats... > if (record_rx) > .. gather rx related stats... > #endif > > This is very specific feature, it is needed while debugging and testing datapath > routines, and It seems this feature with appropriate overhead should not be always enabled. > existing build-time configuration options looks OK as for me. > > Bruce, if proposed runtime extension is acceptable - I will update the patch. > Ok for me. Thanks, /Bruce