From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E64ECA0487 for ; Mon, 1 Jul 2019 15:10:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C52491B9A3; Mon, 1 Jul 2019 15:10:49 +0200 (CEST) Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 99A5F5B3C for ; Mon, 1 Jul 2019 15:10:48 +0200 (CEST) Received: from lfbn-lil-1-176-160.w90-45.abo.wanadoo.fr ([90.45.26.160] helo=droids-corp.org) by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hhw7y-0007qX-1m; Mon, 01 Jul 2019 15:13:51 +0200 Received: by droids-corp.org (sSMTP sendmail emulation); Mon, 01 Jul 2019 15:10:44 +0200 Date: Mon, 1 Jul 2019 15:10:44 +0200 From: Olivier Matz To: Ivan Malov Cc: dev@dpdk.org, "Ananyev, Konstantin" , Andrew Rybchenko Message-ID: <20190701131044.ifakclavrrs6an3s@platinum> References: <20190412150542.12026-1-ivan.malov@oktetlabs.ru> <20190627210618.22205-1-ivan.malov@oktetlabs.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190627210618.22205-1-ivan.malov@oktetlabs.ru> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v3] mbuf: outer offsets are undefined for non-tunnel packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jun 28, 2019 at 12:06:18AM +0300, Ivan Malov wrote: > The default policy for offload-specific fields is that > they are undefined unless the corresponding offloads are > requested in mbuf ol_flags. This is also the case for outer > L2 and L3 length fields which must not be assumed to contain > zeros for non-tunnel packets. The patch clarifies this behaviour > in the comments and also adds appropriate checks to the PMDs which > do not check any tunnel-related offloads before using the said fields. > > Signed-off-by: Ivan Malov > Reviewed-by: Andrew Rybchenko > Acked-by: Konstantin Ananyev Acked-by: Olivier Matz