* [dpdk-dev] [PATCH] net: fix definition of ipv6 traffic class mask
@ 2019-07-01 13:25 Morten Brørup
2019-07-01 13:38 ` Morten Brørup
0 siblings, 1 reply; 5+ messages in thread
From: Morten Brørup @ 2019-07-01 13:25 UTC (permalink / raw)
To: olivier.matz, shahafs, yskoh; +Cc: dev, Morten Brørup
Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
---
lib/librte_net/rte_ip.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/librte_net/rte_ip.h b/lib/librte_net/rte_ip.h
index ae3b7e7..059ec80 100644
--- a/lib/librte_net/rte_ip.h
+++ b/lib/librte_net/rte_ip.h
@@ -355,7 +355,7 @@ struct rte_ipv6_hdr {
#define RTE_IPV6_HDR_FL_SHIFT 0
#define RTE_IPV6_HDR_TC_SHIFT 20
#define RTE_IPV6_HDR_FL_MASK ((1u << RTE_IPV6_HDR_TC_SHIFT) - 1)
-#define RTE_IPV6_HDR_TC_MASK (0xf << RTE_IPV6_HDR_TC_SHIFT)
+#define RTE_IPV6_HDR_TC_MASK (0xff << RTE_IPV6_HDR_TC_SHIFT)
/**
* Process the pseudo-header checksum of an IPv6 header.
--
1.5.6
^ permalink raw reply [flat|nested] 5+ messages in thread* [dpdk-dev] [PATCH] net: fix definition of ipv6 traffic class mask
2019-07-01 13:25 [dpdk-dev] [PATCH] net: fix definition of ipv6 traffic class mask Morten Brørup
@ 2019-07-01 13:38 ` Morten Brørup
2019-07-01 14:00 ` Olivier Matz
0 siblings, 1 reply; 5+ messages in thread
From: Morten Brørup @ 2019-07-01 13:38 UTC (permalink / raw)
To: olivier.matz, shahafs, yskoh; +Cc: dev, Morten Brørup
IPv6 header TC field is 8 bits, not 4.
Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
---
lib/librte_net/rte_ip.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/librte_net/rte_ip.h b/lib/librte_net/rte_ip.h
index ae3b7e7..059ec80 100644
--- a/lib/librte_net/rte_ip.h
+++ b/lib/librte_net/rte_ip.h
@@ -355,7 +355,7 @@ struct rte_ipv6_hdr {
#define RTE_IPV6_HDR_FL_SHIFT 0
#define RTE_IPV6_HDR_TC_SHIFT 20
#define RTE_IPV6_HDR_FL_MASK ((1u << RTE_IPV6_HDR_TC_SHIFT) - 1)
-#define RTE_IPV6_HDR_TC_MASK (0xf << RTE_IPV6_HDR_TC_SHIFT)
+#define RTE_IPV6_HDR_TC_MASK (0xff << RTE_IPV6_HDR_TC_SHIFT)
/**
* Process the pseudo-header checksum of an IPv6 header.
--
1.5.6
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] net: fix definition of ipv6 traffic class mask
2019-07-01 13:38 ` Morten Brørup
@ 2019-07-01 14:00 ` Olivier Matz
2019-07-02 9:38 ` Olivier Matz
0 siblings, 1 reply; 5+ messages in thread
From: Olivier Matz @ 2019-07-01 14:00 UTC (permalink / raw)
To: Morten Brørup; +Cc: shahafs, yskoh, dev
On Mon, Jul 01, 2019 at 03:38:05PM +0200, Morten Brørup wrote:
> IPv6 header TC field is 8 bits, not 4.
>
> Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
Thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] net: fix definition of ipv6 traffic class mask
2019-07-01 14:00 ` Olivier Matz
@ 2019-07-02 9:38 ` Olivier Matz
2019-07-02 19:00 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
0 siblings, 1 reply; 5+ messages in thread
From: Olivier Matz @ 2019-07-02 9:38 UTC (permalink / raw)
To: Morten Brørup; +Cc: shahafs, yskoh, dev, stable
On Mon, Jul 01, 2019 at 04:00:44PM +0200, Olivier Matz wrote:
> On Mon, Jul 01, 2019 at 03:38:05PM +0200, Morten Brørup wrote:
> > IPv6 header TC field is 8 bits, not 4.
> >
> > Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
>
> Thanks
CC: stable@dpdk.org
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] net: fix definition of ipv6 traffic class mask
2019-07-02 9:38 ` Olivier Matz
@ 2019-07-02 19:00 ` Ferruh Yigit
0 siblings, 0 replies; 5+ messages in thread
From: Ferruh Yigit @ 2019-07-02 19:00 UTC (permalink / raw)
To: Olivier Matz, Morten Brørup; +Cc: shahafs, yskoh, dev, stable
On 7/2/2019 10:38 AM, Olivier Matz wrote:
> On Mon, Jul 01, 2019 at 04:00:44PM +0200, Olivier Matz wrote:
>> On Mon, Jul 01, 2019 at 03:38:05PM +0200, Morten Brørup wrote:
>>> IPv6 header TC field is 8 bits, not 4.
>>>
>>> Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
>>
>> Acked-by: Olivier Matz <olivier.matz@6wind.com>
>>
>> Thanks
>
> CC: stable@dpdk.org
>
Fixes: 9b20c6e9028e ("net: add IPv6 header fields macros")
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-07-02 19:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-01 13:25 [dpdk-dev] [PATCH] net: fix definition of ipv6 traffic class mask Morten Brørup
2019-07-01 13:38 ` Morten Brørup
2019-07-01 14:00 ` Olivier Matz
2019-07-02 9:38 ` Olivier Matz
2019-07-02 19:00 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).