From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1681CA0487 for ; Tue, 2 Jul 2019 16:36:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7F8BA1B999; Tue, 2 Jul 2019 16:36:02 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 380CE23D for ; Tue, 2 Jul 2019 16:36:01 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Jul 2019 07:36:00 -0700 X-IronPort-AV: E=Sophos;i="5.63,443,1557212400"; d="scan'208";a="157658619" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Jul 2019 07:35:58 -0700 Date: Tue, 2 Jul 2019 15:35:55 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, bluca@debian.org Message-ID: <20190702143555.GC405@bricha3-MOBL.ger.corp.intel.com> References: <20190503133537.58712-1-bruce.richardson@intel.com> <20190517114734.7072-1-bruce.richardson@intel.com> <20190517114734.7072-5-bruce.richardson@intel.com> <1843519.YIzr3x4FOW@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <1843519.YIzr3x4FOW@xps> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH v2 4/5] examples/vdpa: support building from pkg-config info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jul 02, 2019 at 09:57:48AM +0200, Thomas Monjalon wrote: > 17/05/2019 13:47, Bruce Richardson: > > The vdpa example app did not check for a libdpdk pkg-config file and > > attempt to build using that. Add support for that method of compile to > > align the app with the other examples. >=20 > I see an issue with the experimental tag: >=20 > clang -Wp,-MD,./.main.o.d.tmp -m64 -pthread -fPIC -Ilib/librte_eal/linux= /eal/include -march=3Dnative -DRTE_MACHINE_CPUFLAG_SSE -DRTE_MACHINE_CPUFL= AG_SSE2 -DRTE_MACHINE_CPUFLAG_SSE3 -DRTE_MACHINE_CPUFLAG_SSSE3 -DRTE_MACHIN= E_CPUFLAG_SSE4_1 -DRTE_MACHINE_CPUFLAG_SSE4_2 -DRTE_MACHINE_CPUFLAG_AES -DR= TE_MACHINE_CPUFLAG_PCLMULQDQ -DRTE_MACHINE_CPUFLAG_AVX -DRTE_MACHINE_CPUFLA= G_RDRAND -DRTE_MACHINE_CPUFLAG_RDSEED -DRTE_MACHINE_CPUFLAG_FSGSBASE -DRTE_= MACHINE_CPUFLAG_F16C -DRTE_MACHINE_CPUFLAG_AVX2 -Ix86_64-native-linux-clan= g+shared+next+debug+ASSERT/examples/vdpa/x86_64-native-linux-clang+shared+n= ext+debug+ASSERT/include -Ix86_64-native-linux-clang+shared+next+debug+ASSE= RT/include -include x86_64-native-linux-clang+shared+next+debug+ASSERT/incl= ude/rte_config.h -D_GNU_SOURCE -O2 -D_FILE_OFFSET_BITS=3D64 -W -Wall -Wstri= ct-prototypes -Wmissing-prototypes -Wmissing-declarations -Wold-style-defin= ition -Wpointer-arith -Wnested-externs -Wcast-qual -Wformat-nonliteral -Wfo= rmat-security -Wundef -Wwrite-strings -Wdeprecated -Werror -Wno-missing-fie= ld-initializers -Wno-address-of-packed-member -D_GNU_SOURCE -o main.o -c= examples/vdpa/main.c=20 > examples/vdpa/main.c:172:8: error: 'rte_vhost_driver_attach_vdpa_device' = is deprecated: Symbol is not yet part of stable ABI [-Werror,-Wdeprecated-d= eclarations] >=20 > It seems "CFLAGS +=3D -DALLOW_EXPERIMENTAL_API" > is reset by the call to pkg-config. > No, it's not, it's reset by the call to the DPDK make build system in the other leg of the code. I'll fix this in the Makefile in v3. =20 > > +build/$(APP)-shared: $(SRCS-y) Makefile $(PC_FILE) | build >=20 > Better to use the real directory name as prerequisite, > instead of "build". >=20 Not sure what you mean here, build is the name of the directory. [This is also consistent with what is done in all the other example makefiles. If it needs updating, then it should be done as a general patch to all examples in 19.11 release timeframe.] /Bruce