From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4510FA0487 for ; Wed, 3 Jul 2019 00:04:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3F7181BDF1; Wed, 3 Jul 2019 00:04:01 +0200 (CEST) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id C9E151BDED for ; Wed, 3 Jul 2019 00:03:59 +0200 (CEST) Received: by mail-pg1-f196.google.com with SMTP id s27so81152pgl.2 for ; Tue, 02 Jul 2019 15:03:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kX+U03+r9Qsg6idhB62nTVRP2eUkfvN8Wy0tJ7E4mGg=; b=oA86UTCeVK8HwXOpNp7kj+94FM1KCF4FwPgeIGSuxBdCEouZvQZkl9JWJTf6iOq/FM kXf+aAUTTZQ5oq283F9qzSiG/tFumLGwnSvZbm+vrk8XCH/MpiOqLMfGsY13uykDJOZw 5hZsd0Spt+1cLBRqdvg60XMNtmZMYIythjvI/9bZ1ETwplDbAA7KT/bRrLpKC6dAITRC TnKMOYBaZgMnnFRoqxrNKR20xTJSfe58HJuOsRRkBj6zpzQsqVpmwV++f3Dq4WyNZ8pu RFPRuT6NUNR/cQpX7GMYtNtzyN+wzh1NciZ2g5CRrc2vx272Wyhncox9xOH3v2iId25m TjUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kX+U03+r9Qsg6idhB62nTVRP2eUkfvN8Wy0tJ7E4mGg=; b=KcEvfNxOmZn2ta8uLQaupOPoSB+MGUtCWorntYVDSpNE0mPWm3a2b6Z5v9okl8IXLT R3edVQhx5tmQM7BHokHwD6ylkLwu1Q4MBKZEDItbvfeI/K/JLCIg35hKghZuzwTZJPZy Yoywld0+3ak43AOcyf5B4Pbzc6UWbnJCWSR67bux/GviYMJT9RWuhRtBWpGtPddiNuSy /00qV+39Xt8Avtt6HduNvNI9lnLJzL1+E26ULLiNNOHb2+rD2DC4GSFb6FOXcDSjcTTB YY1uifuGulc2mVJgQYf/cnv2cK+3KJD5ice3MK3llFkQKoPqigPjw6iPBRmZwCVvWgln PROw== X-Gm-Message-State: APjAAAVgk6/2XTDBn4ZkyYRJNaSm3P0kbV6XRYOfTHI8wgQpDCN/QFOM uUUZgKCpPOnJMIQ356gXSrA= X-Google-Smtp-Source: APXvYqwCyg6xeVkbSO9pqIJxqexbUs56Q1BEVhTysoIx3ieGaGifw48/+yZ7wZV8iFFJ/ZL0yzR/pw== X-Received: by 2002:a17:90a:db52:: with SMTP id u18mr8174287pjx.107.1562105038878; Tue, 02 Jul 2019 15:03:58 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id m101sm29930pjb.7.2019.07.02.15.03.57 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 02 Jul 2019 15:03:58 -0700 (PDT) Date: Tue, 2 Jul 2019 15:03:50 -0700 From: Stephen Hemminger To: Thomas Monjalon Cc: dev@dpdk.org, gaetan.rivet@6wind.com, Matan Azrad , Jakub Grajciar Message-ID: <20190702150350.36292289@hermes.lan> In-Reply-To: <2596330.9ZLSrDPUW1@xps> References: <20190516180427.17270-1-stephen@networkplumber.org> <20190702165017.3802-1-stephen@networkplumber.org> <2596330.9ZLSrDPUW1@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 0/8] net/ether: enhancements and optimizations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 02 Jul 2019 23:37:29 +0200 Thomas Monjalon wrote: > > Stephen Hemminger (7): > > net/rte_ether: deinline non-critical functions > > net/ether: add function to convert string to ethernet address > > ethdev: use new ethernet parsing function > > net/ether: use bitops to speedup comparison > > cmdline: use new ethernet address parser > > net/bonding: use new ethernet address parser > > app/testpmd: use new ethernet address parser > > There are other MAC parsing code: > drivers/net/failsafe/failsafe_args.c - fs_get_mac_addr_arg() > drivers/net/memif/rte_eth_memif.c - memif_set_mac() > drivers/net/vdev_netvsc/vdev_netvsc.c - vdev_netvsc_netvsc_probe() > drivers/net/virtio/virtio_user/virtio_user_dev.c - parse_mac() > Should they be replaced? > > Sure, I can add these to v7