From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C945AA10D6 for ; Wed, 3 Jul 2019 00:13:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BE6AE1BE1D; Wed, 3 Jul 2019 00:13:00 +0200 (CEST) Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by dpdk.org (Postfix) with ESMTP id 08D681BE08 for ; Wed, 3 Jul 2019 00:12:56 +0200 (CEST) Received: by mail-pg1-f173.google.com with SMTP id g15so86539pgi.4 for ; Tue, 02 Jul 2019 15:12:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8fFcBaPZKjQQPsKQQeFeSAG72mshjjR9mGZfTCJM/8s=; b=Ob863wrLrea/do6oATNAEkKwiVQPoH7bSOMXAA2VjG3T2iTjEGE/SM4HmP3krpKaeg zvslInw3Y/DQBapVnNN8aBuc963M2YbKWdqDx5OtCQnaBHSwoBz1F8XXj5I5K7Zqf6R5 cEGgGsKpoTSpd7RJYDfPqTSfMiymJGQXq71BEdHQ3aDfDkEZcWyCyCL52lsc9y9bmidg PzVrDOuUs+ose0C+/PXCsQiiChS6QsGi43KAaouRqRIWAbsHXRCSLexXdSjdytLKgrid DS/yX7yLGTS0IZ8OG2se8q7DrKNGJAs9DxyFlOB3JhekF2u+xF70p8XZvaPAyMmeJy2G Kr9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8fFcBaPZKjQQPsKQQeFeSAG72mshjjR9mGZfTCJM/8s=; b=H0zqJN6Q16ZG2QCekrhU2MK8b0lKXyPTWWcbgGDr/i7/ObzGAhiFzwJGVPVhCiwZ82 EF6oJ5r87IdU1E2mZqZ/wOZzOzy+lFp0Yur8Bz7LYc9Yg4EOk0gZ2Jct5gkcICt3nppb fpgrPHR6qRqpSXgA4lrR3JRyTGc9B+sHZhBMesHEJHNJIRD8zLyqVN8Q3pWkbqOpxDtc LUt1QckZFsGFgZbE/m40sNxtY0enK/x07i6Z9hzZseKZvXj+rXr8Bf/Pkd9b7rt9JHNt b+sK7m+mO1ySExAoCMPvggVwjv/2ywMUGeB3NvDqrIGdoQma5cg5ln2E1C6Dfc1FYoed Uzig== X-Gm-Message-State: APjAAAXlvUiZaGkgReGC0eSnPcfT7utmFcMkrruOcjVMDkQjFg3PRmhl 30VnT35Y7mGvcv3YaFJ585CJVoUaJx8= X-Google-Smtp-Source: APXvYqwU2GcwUoe61yzuv6R8FE469CwdqGQIl6lTfeLV8FkHRQN6FtRvpxiC3dRHCKJb9UgQj1OTYg== X-Received: by 2002:a65:45c1:: with SMTP id m1mr34252358pgr.260.1562105575757; Tue, 02 Jul 2019 15:12:55 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id q4sm25035pjq.27.2019.07.02.15.12.54 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 02 Jul 2019 15:12:54 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Andrew Rybchenko Date: Tue, 2 Jul 2019 15:12:39 -0700 Message-Id: <20190702221247.28391-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190702221247.28391-1-stephen@networkplumber.org> References: <20190516180427.17270-1-stephen@networkplumber.org> <20190702221247.28391-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v7 04/12] net/ether: use bitops to speedup comparison X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Using bit operations like or and xor is faster than a loop on all architectures. Really just explicit unrolling. Similar cast to uint16 unaligned is already done in other functions here. Signed-off-by: Stephen Hemminger Reviewed-by: Andrew Rybchenko --- lib/librte_net/rte_ether.h | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h index 8edc7e217b25..feb35a33c94b 100644 --- a/lib/librte_net/rte_ether.h +++ b/lib/librte_net/rte_ether.h @@ -81,11 +81,10 @@ struct rte_ether_addr { static inline int rte_is_same_ether_addr(const struct rte_ether_addr *ea1, const struct rte_ether_addr *ea2) { - int i; - for (i = 0; i < RTE_ETHER_ADDR_LEN; i++) - if (ea1->addr_bytes[i] != ea2->addr_bytes[i]) - return 0; - return 1; + const unaligned_uint16_t *w1 = (const uint16_t *)ea1; + const unaligned_uint16_t *w2 = (const uint16_t *)ea2; + + return ((w1[0] ^ w2[0]) | (w1[1] ^ w2[1]) | (w1[2] ^ w2[2])) == 0; } /** @@ -100,11 +99,9 @@ static inline int rte_is_same_ether_addr(const struct rte_ether_addr *ea1, */ static inline int rte_is_zero_ether_addr(const struct rte_ether_addr *ea) { - int i; - for (i = 0; i < RTE_ETHER_ADDR_LEN; i++) - if (ea->addr_bytes[i] != 0x00) - return 0; - return 1; + const unaligned_uint16_t *w = (const uint16_t *)ea; + + return (w[0] | w[1] | w[2]) == 0; } /** -- 2.20.1