From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA9E6A0487 for ; Wed, 3 Jul 2019 00:13:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F14711BE31; Wed, 3 Jul 2019 00:13:06 +0200 (CEST) Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id 190451BE08 for ; Wed, 3 Jul 2019 00:13:02 +0200 (CEST) Received: by mail-pf1-f196.google.com with SMTP id p184so123516pfp.7 for ; Tue, 02 Jul 2019 15:13:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=i8sEf2BqVxRRW7Hf5r4EMIM/xDPKtZVL0Pik8O21io8=; b=zNZXi5qh4M+5WdMAkBdNnNKkm15LWGc9L4lgUF2sbRVE6NeF7qPEOz5cZSptQO8XZM A3TAmCwmcfLBvBGNvnrcsOFY9GYMmfSsEb7Ygr+q+X7G/8G3LyZG2r4mRkeiIvl/8Y5a +uuYLje8my+ZWghroR/L6BKENfGNYFTVRHDNsOZRU4mvFqCzmJOfJTrbaFkhN7hd6UzI IHMIYg36RdGcyLEoOpZmNEjOhpP1e1Bc8+uA9FS7OshdDYgfZwTTe/MvOMGql7x8AzuN d1D9/hySjq0HDI5aGbUygy0GakteiMzozY+QNmM76e2q27kqp2PBLKnI8gkEqzcWwj/0 ++Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=i8sEf2BqVxRRW7Hf5r4EMIM/xDPKtZVL0Pik8O21io8=; b=i9nMbe+kBERkqgDTKNA3aC3fENeq0PARobH2h/FBobofFnN9J/Ehg/dE5eNf5JCkBH LSJSUWm+0WLRtX9as3Qi/lS9FOJ6ZVxjGqXew+j7CH1J+olN6yPLtsutXjSntrk1Tv5m gVn0J80s9eNmsOUTOHhgh9EB6HE4bQdUG9XWZ7OyxD4nSeUpkLedVRdzcqizfSrDLg23 R4RaOyjBDAnisOmWS0kboz6/+Lmlu1LlFWEARfcL2Tvp+EJLU5MsRx5sP0W2Du8pNrk8 k+OvGtHNwvls4WEqzn67E9twwszSB2bdqIlaT9M7BxwchODZYtF/a0EiO4ujSJHlakuR HMgg== X-Gm-Message-State: APjAAAWAwrOlDHTKzyB3/pWRvnNbpzhpSqfvh9Yzhr//AiBhLVzK6n6I qWrGxMw3cfkYkI88uv/1hjAZMwUc X-Google-Smtp-Source: APXvYqw63rps8r2NK+6QwHXioJZrMBqs2l0trbdicn7rGk1Ju2xM2F76pQv1rressF2k4BXBmTra9g== X-Received: by 2002:a17:90a:3086:: with SMTP id h6mr8379381pjb.14.1562105581042; Tue, 02 Jul 2019 15:13:01 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id q4sm25035pjq.27.2019.07.02.15.12.59 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 02 Jul 2019 15:13:00 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Tue, 2 Jul 2019 15:12:42 -0700 Message-Id: <20190702221247.28391-8-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190702221247.28391-1-stephen@networkplumber.org> References: <20190516180427.17270-1-stephen@networkplumber.org> <20190702221247.28391-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v7 07/12] net/bonding: use new ethernet address parser X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The cmdline library used to be the only way to parse a mac address. Now there is rte_ether_unformat_addr. Signed-off-by: Stephen Hemminger --- drivers/net/bonding/Makefile | 2 +- drivers/net/bonding/meson.build | 2 +- drivers/net/bonding/rte_eth_bond_args.c | 6 +----- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/net/bonding/Makefile b/drivers/net/bonding/Makefile index 1893e3cad313..26c1782554cd 100644 --- a/drivers/net/bonding/Makefile +++ b/drivers/net/bonding/Makefile @@ -12,7 +12,7 @@ CFLAGS += -DALLOW_EXPERIMENTAL_API CFLAGS += -O3 CFLAGS += $(WERROR_FLAGS) LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring -LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs -lrte_cmdline +LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs LDLIBS += -lrte_pci -lrte_bus_pci LDLIBS += -lrte_bus_vdev diff --git a/drivers/net/bonding/meson.build b/drivers/net/bonding/meson.build index 00374edb2a9d..6267210adf5f 100644 --- a/drivers/net/bonding/meson.build +++ b/drivers/net/bonding/meson.build @@ -8,6 +8,6 @@ sources = files('rte_eth_bond_api.c', 'rte_eth_bond_pmd.c', 'rte_eth_bond_flow.c 'rte_eth_bond_args.c', 'rte_eth_bond_8023ad.c', 'rte_eth_bond_alb.c') deps += 'sched' # needed for rte_bitmap.h -deps += ['ip_frag', 'cmdline'] +deps += ['ip_frag'] install_headers('rte_eth_bond.h', 'rte_eth_bond_8023ad.h') diff --git a/drivers/net/bonding/rte_eth_bond_args.c b/drivers/net/bonding/rte_eth_bond_args.c index 01bbb06c1a84..936440fb8491 100644 --- a/drivers/net/bonding/rte_eth_bond_args.c +++ b/drivers/net/bonding/rte_eth_bond_args.c @@ -7,9 +7,6 @@ #include #include -#include -#include - #include "rte_eth_bond.h" #include "rte_eth_bond_private.h" @@ -281,8 +278,7 @@ bond_ethdev_parse_bond_mac_addr_kvarg(const char *key __rte_unused, return -1; /* Parse MAC */ - return cmdline_parse_etheraddr(NULL, value, extra_args, - sizeof(struct rte_ether_addr)); + return rte_ether_unformat_addr(value, extra_args); } int -- 2.20.1