From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id E7ECDA0487
for <public@inbox.dpdk.org>; Wed, 3 Jul 2019 09:58:25 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id A83063DC;
Wed, 3 Jul 2019 09:58:24 +0200 (CEST)
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
by dpdk.org (Postfix) with ESMTP id 574352AB
for <dev@dpdk.org>; Wed, 3 Jul 2019 09:58:23 +0200 (CEST)
X-Amp-Result: UNKNOWN
X-Amp-Original-Verdict: FILE UNKNOWN
X-Amp-File-Uploaded: False
Received: from orsmga003.jf.intel.com ([10.7.209.27])
by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
03 Jul 2019 00:58:22 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.63,446,1557212400"; d="scan'208";a="166448773"
Received: from npg-dpdk-virtio-tbie-2.sh.intel.com (HELO ___) ([10.67.104.151])
by orsmga003.jf.intel.com with ESMTP; 03 Jul 2019 00:58:21 -0700
Date: Wed, 3 Jul 2019 15:56:58 +0800
From: Tiwei Bie <tiwei.bie@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, "Burakov, Anatoly" <anatoly.burakov@intel.com>
Message-ID: <20190703075657.GA20458@___>
References: <20190703054508.22824-1-tiwei.bie@intel.com>
<CAJFAV8xnN5nDjDn+PngYHheP0un2tPS+RGx_AX36cMUCYGXmOg@mail.gmail.com>
<20190703073314.GA18868@___>
<CAJFAV8ytwXgV5w_URsB8ZQJ-irKMyfXuyxTQRDY+9sDbrqxr4w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAJFAV8ytwXgV5w_URsB8ZQJ-irKMyfXuyxTQRDY+9sDbrqxr4w@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Subject: Re: [dpdk-dev] [RFC PATCH] bus/pci: avoid depending on private
value in kernel source
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Wed, Jul 03, 2019 at 09:36:26AM +0200, David Marchand wrote:
> On Wed, Jul 3, 2019 at 9:35 AM Tiwei Bie <tiwei.bie@intel.com> wrote:
>
> Hi David,
>
> On Wed, Jul 03, 2019 at 09:02:59AM +0200, David Marchand wrote:
> > Hello,
> >
> > On Wed, Jul 3, 2019 at 7:47 AM Tiwei Bie <tiwei.bie@intel.com> wrote:
> >
> > The value 40 used in VFIO_GET_REGION_ADDR() is a private value
> > (VFIO_PCI_OFFSET_SHIFT) defined in Linux kernel source [1]. It
> > is not part of VFIO API, and we should not depend on it.
> >
> > [1] https://github.com/torvalds/linux/blob/6fbc7275c7a9/drivers/vfio/
> pci/
> > vfio_pci_private.h#L19
> >
> >
> >
> > I did not follow linux kernel changes, is there something that would
> change
> > this offset?
> > It looks like a cleanup (did not look into the details yet), do we need
> this
> > now?
>
> In VFIO/mdev [1], the offset can be something different. It depends
> on the parent device. It's not just a cleanup. It's a preparation
> for the mdev support in DPDK.
>
> [1] https://github.com/torvalds/linux/blob/master/Documentation/
> vfio-mediated-device.txt
>
>
>
> Ok, thanks.
> So we can wait for mdev to be ready before working on this.
What do you mean by "mdev to be ready"? RFC ready? I don't see
anything blocking the discussion on this now.
PS. I already sent a RFC series of the mdev support in DPDK
to the mailing list 3 month ago.
Thanks,
Tiwei
>
>
> --
> David Marchand