From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1C224A0487 for ; Thu, 4 Jul 2019 04:18:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DB8AB1F28; Thu, 4 Jul 2019 04:18:19 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30043.outbound.protection.outlook.com [40.107.3.43]) by dpdk.org (Postfix) with ESMTP id BE4782BE5 for ; Thu, 4 Jul 2019 04:18:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IAvCu1I+OsigcBCslBFJC3eXvz9n7Zx/kOIEDlqvR/g=; b=PAVwAkmxAVJSnR6RByaULujmbU8APFt+DYWXiz8JaCBRru1pDS151sDH75cotJ+nGd0oQSX65aafPxvugYRVIkAJQ/QcKgncYux5Z/zpwN55iRO7BifkjZ95jRfjlQLzLaSRDEN6c+Oqez4p4ta0+F+EMKU3JvW6ZfnZvK8aS74= Received: from AM6PR05MB6567.eurprd05.prod.outlook.com (20.179.6.215) by AM6PR05MB5441.eurprd05.prod.outlook.com (20.177.118.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2052.17; Thu, 4 Jul 2019 02:18:15 +0000 Received: from AM6PR05MB6567.eurprd05.prod.outlook.com ([fe80::496b:bd1c:863a:ed47]) by AM6PR05MB6567.eurprd05.prod.outlook.com ([fe80::496b:bd1c:863a:ed47%3]) with mapi id 15.20.2052.010; Thu, 4 Jul 2019 02:18:15 +0000 From: Jack Min To: Thomas Monjalon CC: Adrien Mazarguil , "dev@dpdk.org" , Ori Kam , John McNamara , Marko Kovacevic , Ferruh Yigit , Andrew Rybchenko Thread-Topic: [dpdk-dev] [PATCH v4 1/4] ethdev: add GRE key field to flow API Thread-Index: AQHVMLsEQ9YEwcX+4E+uhJAXb6ifX6a4738AgADMd4A= Date: Thu, 4 Jul 2019 02:18:15 +0000 Message-ID: <20190704021805.bcei4jom3prm5kau@mellanox.com> References: <20190624154018.128379-1-jackmin@mellanox.com> <2841769.YOq82iQ06o@xps> In-Reply-To: <2841769.YOq82iQ06o@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HK0P153CA0003.APCP153.PROD.OUTLOOK.COM (2603:1096:203:18::15) To AM6PR05MB6567.eurprd05.prod.outlook.com (2603:10a6:20b:bc::23) authentication-results: spf=none (sender IP is ) smtp.mailfrom=jackmin@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [139.226.40.4] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 96deb104-68f3-406f-2134-08d70025decc x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM6PR05MB5441; x-ms-traffictypediagnostic: AM6PR05MB5441: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0088C92887 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(366004)(376002)(396003)(39860400002)(136003)(189003)(199004)(86362001)(386003)(6506007)(6486002)(6436002)(6246003)(229853002)(3846002)(6116002)(68736007)(81166006)(26005)(81156014)(25786009)(8676002)(186003)(8936002)(478600001)(53936002)(6512007)(1076003)(99286004)(14454004)(7736002)(2906002)(305945005)(102836004)(2616005)(486006)(476003)(66066001)(54906003)(446003)(11346002)(36756003)(4326008)(73956011)(66946007)(66476007)(66556008)(64756008)(66446008)(316002)(6916009)(71200400001)(52116002)(76176011)(5660300002)(71190400001)(14444005)(4744005)(256004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR05MB5441; H:AM6PR05MB6567.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 43L9C4UynZ7uzWYyvSOdny6EX306vuub8FdPT4bLxlDh10aoWnjUMOOCTbINb3+G+lXSlHcvzKmjTgQ/1PNzjcp7YJoVNU5R38lIqLvl/UmNKzCBzRkDSD4d+pNiArNI35nM8DrBx+EVewlhinQOsDptbIbqza6ziorsIVxDaPxFFZAbY5ikye4nUQ20cfcwnFuPxpEQs8g1FQFKPPGiOUqrg3JlpTlgak+7WVawxg9SjOZY1ONg0QTvkUcNSalV3KKbR9popP8JsfC5vZGEjC4lm3KeeZl37JTT4wMyqMA8UROIeSE5zkOXz4NM6+cB36b2hsE9dpvZWjmJlXj01iM1pP7nkubskhFaLyFlXZmPUhN3V1cG5EpbI4ICFkL0cElLUxXZW7z7ps9qtlw+HTf2jhlZWUN3KjrnO0bGGCE= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 96deb104-68f3-406f-2134-08d70025decc X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jul 2019 02:18:15.1442 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jackmin@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB5441 Subject: Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add GRE key field to flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 19-07-03, 16:06, Thomas Monjalon wrote: > 02/07/2019 11:45, Xiaoyu Min: > > + /** > > + * Matches a GRE optional key field. > > + * > > + * The value should a big-endian 32bit integer. > > + */ > > + RTE_FLOW_ITEM_TYPE_GRE_KEY, >=20 > We probably want to use the same format as in Dekel's patch > for doxygen documentation of the action value: >=20 OK, I'll update it accordingly. Thanks ~ > /** > * Increase sequence number in the outermost TCP header. > * > * Action configuration specifies the value to increase > * TCP sequence number as a big-endian 32 bit integer. > * > * @p conf type: > * @code rte_be32_t * @endcode > * > * Using this action on non-matching traffic will result in > * undefined behavior. > */ > RTE_FLOW_ACTION_TYPE_INC_TCP_SEQ, >=20 >=20 >=20