From: <kkanas@marvell.com>
To: <dev@dpdk.org>, <ferruh.yigit@intel.com>,
"John W. Linville" <linville@tuxdriver.com>
Cc: Krzysztof Kanas <kkanas@marvell.com>
Subject: [dpdk-dev] [PATCH] net/af_packet: append system error to error msgs
Date: Thu, 4 Jul 2019 16:39:05 +0200 [thread overview]
Message-ID: <20190704143905.8704-1-kkanas@marvell.com> (raw)
From: Krzysztof Kanas <kkanas@marvell.com>
Print system error to make easier diagnosis of errors with af_packet.
Signed-off-by: Krzysztof Kanas <kkanas@marvell.com>
---
drivers/net/af_packet/rte_eth_af_packet.c | 47 ++++++++++++-----------
1 file changed, 24 insertions(+), 23 deletions(-)
diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c
index f396f8b22a55..94ae4b13398d 100644
--- a/drivers/net/af_packet/rte_eth_af_packet.c
+++ b/drivers/net/af_packet/rte_eth_af_packet.c
@@ -13,7 +13,9 @@
#include <rte_malloc.h>
#include <rte_kvargs.h>
#include <rte_bus_vdev.h>
+#include <rte_errno.h>
+#include <errno.h>
#include <linux/if_ether.h>
#include <linux/if_packet.h>
#include <arpa/inet.h>
@@ -605,8 +607,8 @@ rte_pmd_init_internals(struct rte_vdev_device *dev,
}
if (ioctl(sockfd, SIOCGIFINDEX, &ifr) == -1) {
PMD_LOG(ERR,
- "%s: ioctl failed (SIOCGIFINDEX)",
- name);
+ "%s: ioctl failed (SIOCGIFINDEX):%s",
+ name, rte_strerror(errno));
return -1;
}
(*internals)->if_name = strdup(pair->value);
@@ -616,8 +618,8 @@ rte_pmd_init_internals(struct rte_vdev_device *dev,
if (ioctl(sockfd, SIOCGIFHWADDR, &ifr) == -1) {
PMD_LOG(ERR,
- "%s: ioctl failed (SIOCGIFHWADDR)",
- name);
+ "%s: ioctl failed (SIOCGIFHWADDR):%s",
+ name, rte_strerror(errno));
return -1;
}
memcpy(&(*internals)->eth_addr, ifr.ifr_hwaddr.sa_data, ETH_ALEN);
@@ -640,8 +642,8 @@ rte_pmd_init_internals(struct rte_vdev_device *dev,
qsockfd = socket(AF_PACKET, SOCK_RAW, htons(ETH_P_ALL));
if (qsockfd == -1) {
PMD_LOG(ERR,
- "%s: could not open AF_PACKET socket",
- name);
+ "%s: could not open AF_PACKET socket: %s",
+ name, rte_strerror(errno));
return -1;
}
@@ -650,8 +652,8 @@ rte_pmd_init_internals(struct rte_vdev_device *dev,
&tpver, sizeof(tpver));
if (rc == -1) {
PMD_LOG(ERR,
- "%s: could not set PACKET_VERSION on AF_PACKET socket for %s",
- name, pair->value);
+ "%s: could not set PACKET_VERSION on AF_PACKET socket for %s:%s",
+ name, pair->value, rte_strerror(errno));
goto error;
}
@@ -660,8 +662,8 @@ rte_pmd_init_internals(struct rte_vdev_device *dev,
&discard, sizeof(discard));
if (rc == -1) {
PMD_LOG(ERR,
- "%s: could not set PACKET_LOSS on AF_PACKET socket for %s",
- name, pair->value);
+ "%s: could not set PACKET_LOSS on AF_PACKET socket for %s:%s",
+ name, pair->value, rte_strerror(errno));
goto error;
}
@@ -670,8 +672,8 @@ rte_pmd_init_internals(struct rte_vdev_device *dev,
&qdisc_bypass, sizeof(qdisc_bypass));
if (rc == -1) {
PMD_LOG(ERR,
- "%s: could not set PACKET_QDISC_BYPASS on AF_PACKET socket for %s",
- name, pair->value);
+ "%s: could not set PACKET_QDISC_BYPASS on AF_PACKET socket for %s:%s",
+ name, pair->value, rte_strerror(errno));
goto error;
}
#else
@@ -681,8 +683,8 @@ rte_pmd_init_internals(struct rte_vdev_device *dev,
rc = setsockopt(qsockfd, SOL_PACKET, PACKET_RX_RING, req, sizeof(*req));
if (rc == -1) {
PMD_LOG(ERR,
- "%s: could not set PACKET_RX_RING on AF_PACKET socket for %s",
- name, pair->value);
+ "%s: could not set PACKET_RX_RING on AF_PACKE socket for %s:%s",
+ name, pair->value, rte_strerror(errno));
goto error;
}
@@ -690,7 +692,8 @@ rte_pmd_init_internals(struct rte_vdev_device *dev,
if (rc == -1) {
PMD_LOG(ERR,
"%s: could not set PACKET_TX_RING on AF_PACKET "
- "socket for %s", name, pair->value);
+ "socket for %s:%s", name, pair->value,
+ rte_strerror(errno));
goto error;
}
@@ -702,8 +705,8 @@ rte_pmd_init_internals(struct rte_vdev_device *dev,
qsockfd, 0);
if (rx_queue->map == MAP_FAILED) {
PMD_LOG(ERR,
- "%s: call to mmap failed on AF_PACKET socket for %s",
- name, pair->value);
+ "%s: call to mmap failed on AF_PACKET socket for %s:%s",
+ name, pair->value, rte_strerror(errno));
goto error;
}
@@ -738,9 +741,8 @@ rte_pmd_init_internals(struct rte_vdev_device *dev,
rc = bind(qsockfd, (const struct sockaddr*)&sockaddr, sizeof(sockaddr));
if (rc == -1) {
- PMD_LOG(ERR,
- "%s: could not bind AF_PACKET socket to %s",
- name, pair->value);
+ PMD_LOG(ERR, "%s: could not bind AF_PACKET socket to %s:%s",
+ name, pair->value, rte_strerror(errno));
goto error;
}
@@ -748,9 +750,8 @@ rte_pmd_init_internals(struct rte_vdev_device *dev,
rc = setsockopt(qsockfd, SOL_PACKET, PACKET_FANOUT,
&fanout_arg, sizeof(fanout_arg));
if (rc == -1) {
- PMD_LOG(ERR,
- "%s: could not set PACKET_FANOUT on AF_PACKET socket "
- "for %s", name, pair->value);
+ PMD_LOG(ERR, "%s: could not set PACKET_FANOUT on AF_PACKET socket for %s:%s",
+ name, pair->value, rte_strerror(errno));
goto error;
}
#endif
--
2.21.0
next reply other threads:[~2019-07-04 14:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-04 14:39 kkanas [this message]
2019-07-04 18:59 ` Ferruh Yigit
2019-07-05 9:35 ` [dpdk-dev] [EXT] " Krzysztof Kanas
2019-07-08 18:04 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190704143905.8704-1-kkanas@marvell.com \
--to=kkanas@marvell.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).