From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 564E5A0487
	for <public@inbox.dpdk.org>; Fri,  5 Jul 2019 16:25:17 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 2CB721B9B3;
	Fri,  5 Jul 2019 16:25:17 +0200 (CEST)
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id D1B421B9AD
 for <dev@dpdk.org>; Fri,  5 Jul 2019 16:25:15 +0200 (CEST)
Received: from lfbn-lil-1-176-160.w90-45.abo.wanadoo.fr ([90.45.26.160]
 helo=droids-corp.org)
 by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.89) (envelope-from <olivier.matz@6wind.com>)
 id 1hjPCH-0004yv-9B; Fri, 05 Jul 2019 16:28:22 +0200
Received: by droids-corp.org (sSMTP sendmail emulation);
 Fri, 05 Jul 2019 16:25:13 +0200
Date: Fri, 5 Jul 2019 16:25:13 +0200
From: Olivier Matz <olivier.matz@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Rami Rosen <ramirose@gmail.com>,
 Andrew Rybchenko <arybchenko@solarflare.com>
Message-ID: <20190705142513.c5u5w45ttdt2q3mv@platinum>
References: <20190516180427.17270-1-stephen@networkplumber.org>
 <20190702221247.28391-1-stephen@networkplumber.org>
 <20190702221247.28391-2-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190702221247.28391-2-stephen@networkplumber.org>
User-Agent: NeoMutt/20170113 (1.7.2)
Subject: Re: [dpdk-dev] [PATCH v7 01/12] net/rte_ether: deinline
 non-critical functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Jul 02, 2019 at 03:12:36PM -0700, Stephen Hemminger wrote:
> Formatting Ethernet address and getting a random value are
> not in critical path so they should not be inlined.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Acked-by: Rami Rosen <ramirose@gmail.com>
> Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>

just a nit in the title: net/ether instead of net/rte_ether for
consistency with other patches

Acked-by: Olivier Matz <olivier.matz@6wind.com>

Thanks