From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 5E708A0487
	for <public@inbox.dpdk.org>; Fri,  5 Jul 2019 16:46:56 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 252CC1B9A8;
	Fri,  5 Jul 2019 16:46:54 +0200 (CEST)
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id DA69D1B993
 for <dev@dpdk.org>; Fri,  5 Jul 2019 16:46:52 +0200 (CEST)
Received: from lfbn-lil-1-176-160.w90-45.abo.wanadoo.fr ([90.45.26.160]
 helo=droids-corp.org)
 by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.89) (envelope-from <olivier.matz@6wind.com>)
 id 1hjPXC-00053T-BS; Fri, 05 Jul 2019 16:49:59 +0200
Received: by droids-corp.org (sSMTP sendmail emulation);
 Fri, 05 Jul 2019 16:46:50 +0200
Date: Fri, 5 Jul 2019 16:46:50 +0200
From: Olivier Matz <olivier.matz@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Message-ID: <20190705144650.ftx2c7erlbcqtjrq@platinum>
References: <20190516180427.17270-1-stephen@networkplumber.org>
 <20190702221247.28391-1-stephen@networkplumber.org>
 <20190702221247.28391-7-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190702221247.28391-7-stephen@networkplumber.org>
User-Agent: NeoMutt/20170113 (1.7.2)
Subject: Re: [dpdk-dev] [PATCH v7 06/12] cmdline: use new ethernet address
 parser
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Jul 02, 2019 at 03:12:41PM -0700, Stephen Hemminger wrote:
> Now that there is a version of ether_aton in rte_ether, it can
> be used by the cmdline ethernet address parser.
> 
> Note: ether_aton_r can not be used in cmdline because
> the old code would accept either bytes XX:XX:XX:XX:XX:XX
> or words XXXX:XXXX:XXXX and we need to keep compatiablity.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Acked-by: Olivier Matz <olivier.matz@6wind.com>

Thanks!

BTW, I noticed that it also fixes a more serious bug: the previous
commandline parser was using a static buffer, making it thread-unsafe.
I didn't see any places that could have been impacted.