From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0721DA0487 for ; Fri, 5 Jul 2019 19:17:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7D7071BE45; Fri, 5 Jul 2019 19:16:51 +0200 (CEST) Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by dpdk.org (Postfix) with ESMTP id 9F5C71BE0A for ; Fri, 5 Jul 2019 19:16:42 +0200 (CEST) Received: by mail-pl1-f193.google.com with SMTP id 9so4885816ple.5 for ; Fri, 05 Jul 2019 10:16:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=i8sEf2BqVxRRW7Hf5r4EMIM/xDPKtZVL0Pik8O21io8=; b=kGZYQUZDMMY1GEjzaZlvo1eXwhFDM+CkJWUzShfbxP5UPXA9gubJWX1r6BMDij0jtc QFLotFCVCALr+Tq/swwku6ubuyp+qtCvQ6xmxRK6tcp0SNVqFBf76cV8ygxE/dmYFVzI HFWGuAPCMKN42K/rGg+pe8MGhJ2dwbBC6Yxz7/X1wKGEQvCQ7tZd4dGviUABuT5yKoS9 zAC4aR+cNs9urIXAmpGFD81iWI4nFllqMQMKqadHdPxNWsgSWrWlvG+cl3ob0j1spxYU 57Sg4bL6MjTBoCePs1dBYfEGMiFbEji/LeB6D2ozsUI/X4qTAzynMthqGyK9H4cdBC9c 1Sqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=i8sEf2BqVxRRW7Hf5r4EMIM/xDPKtZVL0Pik8O21io8=; b=UIfp9+IEzxIP/t6HMhQhu7aRvQqJniqAgQynEEjMYmXP1xobSAQsf773vhxbiI84MR eUg6Xh8H8aTbh40MOj490qzkMyOVAlFZmPYDWvc5oytkxyeeKyOoX73gj9nhrsAs5o5i bSO+8MwYya7/svSx9lkR0kT7WnjszjLPwBt7zKHp6IRVtWb7F8SH8xDJffUtk3ItKNnA EZhkltMDSWfDoI37bUaGFpfv+A0rZN/4GVoyEyQpcuJ15ov0ZUyAfShkIpRSKpqLWNvZ h8vL5gpqJNjYIgHc/IDMVcnAlkU8FWlnTjO44ZaBE0a0+KST3Lhjn7GvHnPEZYyrZIr3 Ivrw== X-Gm-Message-State: APjAAAV2YzUKYwvm4WI5DAGyj47uq7dIQOZ6av4F6e5q7eMFC5EPFzEi awEDRRgIZGsYRxHZzm3e2u7o/ppCiM0= X-Google-Smtp-Source: APXvYqyyex3jsZugPR3oGOR/8FZdHsrESG4/avGvvrDTbQI8cABwECjad2hlfjX2p9At3JhWN+Mqtg== X-Received: by 2002:a17:902:b612:: with SMTP id b18mr6842918pls.8.1562347001635; Fri, 05 Jul 2019 10:16:41 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id 21sm8991014pjh.25.2019.07.05.10.16.40 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 05 Jul 2019 10:16:40 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Fri, 5 Jul 2019 10:16:21 -0700 Message-Id: <20190705171626.13448-7-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190705171626.13448-1-stephen@networkplumber.org> References: <20190516180427.17270-1-stephen@networkplumber.org> <20190705171626.13448-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v8 06/11] net/bonding: use new ethernet address parser X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The cmdline library used to be the only way to parse a mac address. Now there is rte_ether_unformat_addr. Signed-off-by: Stephen Hemminger --- drivers/net/bonding/Makefile | 2 +- drivers/net/bonding/meson.build | 2 +- drivers/net/bonding/rte_eth_bond_args.c | 6 +----- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/net/bonding/Makefile b/drivers/net/bonding/Makefile index 1893e3cad313..26c1782554cd 100644 --- a/drivers/net/bonding/Makefile +++ b/drivers/net/bonding/Makefile @@ -12,7 +12,7 @@ CFLAGS += -DALLOW_EXPERIMENTAL_API CFLAGS += -O3 CFLAGS += $(WERROR_FLAGS) LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring -LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs -lrte_cmdline +LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs LDLIBS += -lrte_pci -lrte_bus_pci LDLIBS += -lrte_bus_vdev diff --git a/drivers/net/bonding/meson.build b/drivers/net/bonding/meson.build index 00374edb2a9d..6267210adf5f 100644 --- a/drivers/net/bonding/meson.build +++ b/drivers/net/bonding/meson.build @@ -8,6 +8,6 @@ sources = files('rte_eth_bond_api.c', 'rte_eth_bond_pmd.c', 'rte_eth_bond_flow.c 'rte_eth_bond_args.c', 'rte_eth_bond_8023ad.c', 'rte_eth_bond_alb.c') deps += 'sched' # needed for rte_bitmap.h -deps += ['ip_frag', 'cmdline'] +deps += ['ip_frag'] install_headers('rte_eth_bond.h', 'rte_eth_bond_8023ad.h') diff --git a/drivers/net/bonding/rte_eth_bond_args.c b/drivers/net/bonding/rte_eth_bond_args.c index 01bbb06c1a84..936440fb8491 100644 --- a/drivers/net/bonding/rte_eth_bond_args.c +++ b/drivers/net/bonding/rte_eth_bond_args.c @@ -7,9 +7,6 @@ #include #include -#include -#include - #include "rte_eth_bond.h" #include "rte_eth_bond_private.h" @@ -281,8 +278,7 @@ bond_ethdev_parse_bond_mac_addr_kvarg(const char *key __rte_unused, return -1; /* Parse MAC */ - return cmdline_parse_etheraddr(NULL, value, extra_args, - sizeof(struct rte_ether_addr)); + return rte_ether_unformat_addr(value, extra_args); } int -- 2.20.1