From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2843DA00E6 for ; Tue, 9 Jul 2019 17:03:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 547DF1B9A8; Tue, 9 Jul 2019 17:03:05 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 219281B951 for ; Tue, 9 Jul 2019 17:03:02 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jul 2019 08:03:02 -0700 X-IronPort-AV: E=Sophos;i="5.63,470,1557212400"; d="scan'208";a="159473122" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jul 2019 08:03:00 -0700 Date: Tue, 9 Jul 2019 16:02:57 +0100 From: Bruce Richardson To: Stephen Hemminger Cc: dev@dpdk.org, thomas@monjalon.net, olivier.matz@6wind.com Message-ID: <20190709150257.GB497@bricha3-MOBL.ger.corp.intel.com> References: <20190709145836.43493-1-bruce.richardson@intel.com> <20190709075953.3118d965@hermes.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190709075953.3118d965@hermes.lan> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH] doc: deprecation notice for change of ether struct alignment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jul 09, 2019 at 07:59:53AM -0700, Stephen Hemminger wrote: > On Tue, 9 Jul 2019 15:58:36 +0100 > Bruce Richardson wrote: > > > The ethernet address structure alignment will be changed to 2B alignment in > > 19.11. Flag this to users. > > > > Impact is expected to be minimal for this change since ethernet addresses > > are generally 2B aligned anyway. > > > > Signed-off-by: Bruce Richardson > > --- > > doc/guides/rel_notes/deprecation.rst | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > > index a7796f49b..7a04b9b09 100644 > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_notes/deprecation.rst > > @@ -11,6 +11,11 @@ API and ABI deprecation notices are to be posted here. > > Deprecation Notices > > ------------------- > > > > +* net: The alignment of the ethernet address structure in DPDK, > > + ``rte_ether_addr`` will be increased to two, i.e. 16-bit aligned, in the > > + 19.11 release. This will only affect any data structures where an ethernet > > + address is currently aligned on a single byte boundary. > > + > > * meson: The minimum supported version of meson for configuring and building > > DPDK will be increased to v0.47.1 (from 0.41) from DPDK 19.05 onwards. For > > those users with a version earlier than 0.47.1, an updated copy of meson > > We should also take the packed off of ether_header and ether_addr. > Packed is meaningless on ether_addr anyway. Agreed. However, I don't think that needs to be called out here as it's a code change with zero impact. The user-impacting change is the alignment one. /Bruce