From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3F0BFA00E6 for ; Wed, 10 Jul 2019 19:49:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9AE472F42; Wed, 10 Jul 2019 19:49:27 +0200 (CEST) Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by dpdk.org (Postfix) with ESMTP id 3B3412E81 for ; Wed, 10 Jul 2019 19:49:26 +0200 (CEST) Received: by mail-pg1-f171.google.com with SMTP id s27so1600016pgl.2 for ; Wed, 10 Jul 2019 10:49:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=33mVwedMggxVEuS8WzBZusbj+2vhPUWY1FcXDCuQ/0U=; b=IGeTe2htW2w+pO1FrFidsYBBhkGskArZKMc2XPJVAzW6e5BGUka7auOuq4qZBDeV0v hiwuCL3S/8g1J0B+wExcGQr5UYTeqFME/o18/6e3dVRhKoxD+IdCN3OYH0Cx/X+y2W2S tl6TsIVsb15rjTXzm7vQOdHcAL1MuGSHw9gBrgj71nH6vRIOsq0PRyI6CTMRVFfhYp82 PT0+OUILtieNQjrrWEygjOK9nJMJJpSdCYBM5WqarpkVvm+scM3zgIiMK/qsM0fDCdF8 d0E+EZsL7ij4k+YWj7VFoTXAG5t0bdD9M0PgIVad2hfYBmD+vAC965Wxhv3UloHZ9vPq Zs3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=33mVwedMggxVEuS8WzBZusbj+2vhPUWY1FcXDCuQ/0U=; b=B501KsmOveIPyey05CivpM4VWevfw5PB5lHhq8CtZBZdHNBlI9enAg/FFqWUTv2U9H WSAZ7sX7+DWY55NQQ671nZEU3DrmpK7mWdjGmfTsTvLwqJeHYc1adSw9zqEQLDhK9d3l gbd5JvXJ6AQrdwPZXQvjNokgPA5JfaHrjCYrax0DZ1+xbnEMKXW7BHqAnRf9gvU6NK47 Vv5Ax7n0ciHZqYwBT2M5/Y7Oru0bkZ921pDCwaQHNerEFX0T8VNQl906dx3CWh9uryrx AWrPW/A+ty583BhiqcabcQjAPw4XZ3bfpOnlfCTwq5d+fHMArVm0Thj5vs6WyJG8Bhfk L8mA== X-Gm-Message-State: APjAAAVfPiqINyndpmHTuAl87OqU6mc/Y7glNsCOmHSrQq6BF9G6j5Cn kom/ptQGXFMlcaZmxYF7WuAD/NNUEwE= X-Google-Smtp-Source: APXvYqz0yDgX9IwvUuw7W15nzJbsRAUiRiF3xXk6xGZAQgBzvA+FcHwS6/7U4hDJD96HiKZtYm8ZVg== X-Received: by 2002:a63:c70d:: with SMTP id n13mr23632757pgg.171.1562780965099; Wed, 10 Jul 2019 10:49:25 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id q36sm2704113pgl.23.2019.07.10.10.49.24 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 10 Jul 2019 10:49:24 -0700 (PDT) Date: Wed, 10 Jul 2019 10:49:17 -0700 From: Stephen Hemminger To: Olivier Matz Cc: dev@dpdk.org Message-ID: <20190710104917.73bc9201@hermes.lan> In-Reply-To: <20190710092907.5565-1-olivier.matz@6wind.com> References: <20190710092907.5565-1-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC] mbuf: support dynamic fields and flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 10 Jul 2019 11:29:07 +0200 Olivier Matz wrote: > /** > * Indicate that the metadata field in the mbuf is in use. > @@ -738,6 +741,8 @@ struct rte_mbuf { > */ > struct rte_mbuf_ext_shared_info *shinfo; > > + uint64_t dynfield1; /**< Reserved for dynamic fields. */ > + uint64_t dynfield2; /**< Reserved for dynamic fields. */ > } __rte_cache_aligned; Growing mbuf is a fundamental ABI break and this needs higher level approval. Why not one pointer? It looks like you are creating something like FreeBSD m_tag. Why not use that?