DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jack Min <jackmin@mellanox.com>
To: Slava Ovsiienko <viacheslavo@mellanox.com>
Cc: Raslan Darawsheh <rasland@mellanox.com>,
	Shahaf Shuler <shahafs@mellanox.com>,
	Yongseok Koh <yskoh@mellanox.com>,
	John McNamara <john.mcnamara@intel.com>,
	Marko Kovacevic <marko.kovacevic@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [Suspected-Phishing][PATCH v3] net/mlx5: support IP-in-IP tunnel
Date: Wed, 10 Jul 2019 14:40:03 +0000	[thread overview]
Message-ID: <20190710143953.75ilbcsllze4texd@mellanox.com> (raw)
In-Reply-To: <AM4PR05MB3265AF4B7816038A3DA7F6D3D2F00@AM4PR05MB3265.eurprd05.prod.outlook.com>

On Wed, 19-07-10, 22:35, Slava Ovsiienko wrote:
> Regarding point 2) - it is OK, there is common flags update in the item validation loop.
> So, after update point 1) - you can add my Acked-by to the patch, thanks.
Great! thank you~
I'll update it soon.

> 
> WBR,
> Slava
> 
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Slava Ovsiienko
> > Sent: Wednesday, July 10, 2019 17:20
> > To: Jack Min <jackmin@mellanox.com>; Raslan Darawsheh
> > <rasland@mellanox.com>; Shahaf Shuler <shahafs@mellanox.com>;
> > Yongseok Koh <yskoh@mellanox.com>; John McNamara
> > <john.mcnamara@intel.com>; Marko Kovacevic
> > <marko.kovacevic@intel.com>
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [Suspected-Phishing][PATCH v3] net/mlx5: support
> > IP-in-IP tunnel
> > 
> > Hi, Xiaoyu
> > 
> > There is a couple of small points to note:
> > 1) It would be good to have the testpmd flow create command sample with
> > new tunnels in commit log.
> > 2) is it OK: "mlx5_flow_tunnel_ip_check(items, &last_item); " ?
> >     It looks like a bug, should the second parameter be "&item_flags" ? (if so -
> > please, fix all
> >    calls of mlx5_flow_tunnel_ip_check())
> > 
> > WBR,
> > Slava
> > 
> > > -----Original Message-----
> > > From: Xiaoyu Min <jackmin@mellanox.com>
> > > Sent: Wednesday, July 10, 2019 13:15
> > > To: Raslan Darawsheh <rasland@mellanox.com>; Slava Ovsiienko
> > > <viacheslavo@mellanox.com>; Shahaf Shuler <shahafs@mellanox.com>;
> > > Yongseok Koh <yskoh@mellanox.com>; John McNamara
> > > <john.mcnamara@intel.com>; Marko Kovacevic
> > <marko.kovacevic@intel.com>
> > > Cc: dev@dpdk.org
> > > Subject: [Suspected-Phishing][PATCH v3] net/mlx5: support IP-in-IP
> > > tunnel
> > >
> > > Enabled IP-in-IP tunnel type support on DV/DR flow engine.
> > > This includes the following combination:
> > >  - IPv4 over IPv4
> > >  - IPv4 over IPv6
> > >  - IPv6 over IPv4
> > >  - IPv6 over IPv6
> > >
> > > MLX5 NIC supports IP-in-IP tunnel via FLEX Parser so need to make sure
> > > fw using FLEX Paser profile 0.
> > >
> > >   mlxconfig -d <mst device> -y set FLEX_PARSER_PROFILE_ENABLE=0
> > >
> > > Signed-off-by: Xiaoyu Min <jackmin@mellanox.com>
> > > ---
> > > v2:
> > >   * updated release note
> > > v3:
> > >   * rebased on 19.08-rc1
> > > ---
> > >  doc/guides/nics/mlx5.rst               | 15 ++++++++++-
> > >  doc/guides/rel_notes/release_19_08.rst |  1 +
> > >  drivers/net/mlx5/mlx5_flow.c           | 35 ++++++++++++++++++++++++
> > >  drivers/net/mlx5/mlx5_flow.h           |  6 ++++-
> > >  drivers/net/mlx5/mlx5_flow_dv.c        | 37 ++++++++++++++++++++++++++
> > >  5 files changed, 92 insertions(+), 2 deletions(-)
> > >

  reply	other threads:[~2019-07-10 14:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-28  2:04 [dpdk-dev] [PATCH] " Xiaoyu Min
2019-07-02  5:51 ` [dpdk-dev] [PATCH v2] " Xiaoyu Min
2019-07-10 10:15 ` [dpdk-dev] [PATCH v3] " Xiaoyu Min
2019-07-10 14:19   ` [dpdk-dev] [Suspected-Phishing][PATCH " Slava Ovsiienko
2019-07-10 14:35     ` Slava Ovsiienko
2019-07-10 14:40       ` Jack Min [this message]
2019-07-10 14:59 ` [dpdk-dev] [PATCH v4] " Xiaoyu Min
2019-07-14 12:26   ` [dpdk-dev] [Suspected-Phishing][PATCH " Raslan Darawsheh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190710143953.75ilbcsllze4texd@mellanox.com \
    --to=jackmin@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=john.mcnamara@intel.com \
    --cc=marko.kovacevic@intel.com \
    --cc=rasland@mellanox.com \
    --cc=shahafs@mellanox.com \
    --cc=viacheslavo@mellanox.com \
    --cc=yskoh@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).