From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B9EEFA00E6 for ; Thu, 11 Jul 2019 10:12:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B07654C8E; Thu, 11 Jul 2019 10:12:55 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 83033397D; Thu, 11 Jul 2019 10:12:54 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x6B8AXGH018318; Thu, 11 Jul 2019 01:12:53 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=pfpt0818; bh=HTC8E2qiSwYoC+07lFC25hB/9DKEido4bRZTWJUkyG0=; b=ekrpBXgvBBRwdsjVEdjzpBOQglsajuHRM6zpaOY1A9SRzUdqXB/e3Xd/5LVuYMeT19rf Cbt/ohE4Rvcy+nmbwufSJ5A/mxQBe8X4Fct5nSnZLQPa0PKOjiyY/+Uhx1LwNNyu0+8n qul/XXokw2uXsgsjOEapB/ohV3m4gvkMYADOLbEJ/O8H8/UDcEZ/UUB4zcZEpoeQxmhx rfrD4OC3sdZY7kiUzO1KjTPSCn++I6Lw8WZwmhjr6BDruN8+C7Wa1UJzhITrracmL1dT 5IeOP4MDq0ULnMw4YleUI5tiHxJ2TU0UxH1RgHq7H+yAleP1uO9/8zt3J5Wlce2y+Xs8 UQ== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0b-0016f401.pphosted.com with ESMTP id 2tnq21a5wu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 11 Jul 2019 01:12:53 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 11 Jul 2019 01:12:51 -0700 Received: from NAM03-CO1-obe.outbound.protection.outlook.com (104.47.40.56) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 11 Jul 2019 01:12:50 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HTC8E2qiSwYoC+07lFC25hB/9DKEido4bRZTWJUkyG0=; b=GdwN3w6//vvAVnc74IQBlTlTWMCu0NPse9bfZSSreARvkB3J+3Nrl2mG9o2o1qsJQodC5pWQNdMI04Jre3SjxZ/YGUkFe/l3HwXRzu+mG/HrSwr2CWlvb9DFxg2xuAlL4PQ+eUtZEON3uv00qjWS20YbsJlrscm90bMYiZAQMI0= Received: from MN2PR18MB2848.namprd18.prod.outlook.com (20.179.21.149) by MN2PR18MB3263.namprd18.prod.outlook.com (10.255.237.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2052.18; Thu, 11 Jul 2019 08:12:47 +0000 Received: from MN2PR18MB2848.namprd18.prod.outlook.com ([fe80::4447:9459:5386:2e18]) by MN2PR18MB2848.namprd18.prod.outlook.com ([fe80::4447:9459:5386:2e18%7]) with mapi id 15.20.2073.008; Thu, 11 Jul 2019 08:12:47 +0000 From: Harman Kalra To: Thomas Monjalon CC: "stable@dpdk.org" , "remy.horton@intel.com" , "reshma.pattan@intel.com" , "anatoly.burakov@intel.com" , "marko.kovacevic@intel.com" , "john.mcnamara@intel.com" , "dev@dpdk.org" , Jerin Jacob Kollanukkaran Thread-Topic: [dpdk-stable] [PATCH v3 1/2] metrics: new API to deinitialise metrics library Thread-Index: AQHVNw2ctHUWJ3GdU0SJVls0OwunjqbEac6AgACo2wA= Date: Thu, 11 Jul 2019 08:12:47 +0000 Message-ID: <20190711081229.GA131264@outlook.office365.com> References: <3AEA2BF9852C6F48A459DA490692831F2A4881E7@irsmsx110.ger.corp.intel.com> <1562755934-13358-1-git-send-email-hkalra@marvell.com> <4424857.lkIZ7qNV9V@xps> In-Reply-To: <4424857.lkIZ7qNV9V@xps> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BM1PR01CA0131.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:40::25) To MN2PR18MB2848.namprd18.prod.outlook.com (2603:10b6:208:3e::21) x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a1a0997b-2df0-4864-766c-08d705d78ede x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:MN2PR18MB3263; x-ms-traffictypediagnostic: MN2PR18MB3263: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0095BCF226 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(39860400002)(346002)(366004)(376002)(136003)(43544003)(199004)(189003)(4326008)(81166006)(81156014)(71200400001)(14454004)(71190400001)(476003)(68736007)(11346002)(446003)(478600001)(6116002)(3846002)(305945005)(256004)(7736002)(486006)(14444005)(1076003)(25786009)(5660300002)(2906002)(6486002)(66946007)(76176011)(9686003)(66476007)(53936002)(66556008)(64756008)(66066001)(66446008)(8936002)(107886003)(229853002)(8676002)(6436002)(55236004)(6246003)(316002)(52116002)(102836004)(386003)(99286004)(26005)(54906003)(6512007)(6916009)(86362001)(33656002)(186003)(6506007); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB3263; H:MN2PR18MB2848.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 5W4XK2JLPo5o8QpsQralNsCmSaeAavyVz0T5qduNynWpqSStC3z9kjWbGoRL+yjBbndg7jriReemrsr+vyr3LZnKvxf9bGylN/3Mvv1ky8XE87I+r3odQD7xELJNCXt2nqPKWlssAdpbHu0Jm4/Evu4LEJzw672z4WZW8bygh77enBlYK4uWKXgvtxURRT3q2EOQUxA3kBquT4ODBTuFh7z8EK+mAnAXgMdgPJEodYS0+hgwQHz1BXGuyI2EUZgd3BZ1POJuDp3JtCp9soiu0OWDxyvFPIYGS8CES+fM61IpyE/YmxLjhQHA/Q3pEPUJK8EYLxpOURrvtlB4E1cT2zakL2mql5clOKtD5v1mPYjCUqPTo3s6CuzOrzRIQh4NX3Oa8U5YqopWtJPgrHmGntnj/OV9ihVcYfzDOZ0gp8Q= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: a1a0997b-2df0-4864-766c-08d705d78ede X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jul 2019 08:12:47.2014 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hkalra@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3263 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-07-11_01:, , signatures=0 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/2] metrics: new API to deinitialise metrics library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 11, 2019 at 12:08:09AM +0200, Thomas Monjalon wrote: > 10/07/2019 12:52, Harman Kalra: > > Once the library usage is over, it must be deinitialized which > > will free the shared memory reserved during initialization. > >=20 > > Observed an issue while running 'metrics_autotest' continuously > > without quiting. For the first run 'metrics_autotest' passes > > all test cases but second run onwards first test case fails > > because metrics library is already initialized during first run. > >=20 > > Cc: stable@dpdk.org > >=20 > > Signed-off-by: Harman Kalra > > --- > > v2: > > * Adding stable@dpdk.org into cc as this patch falls between bug fix > > and new feature. > > v3: > > * Fixed check-git-log.sh and make doc-guides-html issues. >=20 > Why don't you take our comments into account? Sorry, I did not know that I have to copy ACKs and other tags. Will surely take care from next time onwards. >=20 > Reminder 1: > " > I was waiting for an ack on this patch, > and realized that there was one already on v1. > When sending v2, you should have reported the Ack. > " >=20 > Reminder 2: > " > Tested-by : Reshma Pattan > Reviewed-by: Reshma Pattan > Acked-by: Reshma Pattan >=20 > Please keep these tags for next versions. > " Will include these in version 4. >=20 > Reminder 3: > " > I would vote for not backporting this new API. > " >=20 > In case it is not clear, this comment means you should not Cc stable@dpdk= .org I added CC because of the following comment from Remy: " On Mon, Feb 25, 2019 at 12:21:21PM +0000, Remy Horton wrote: > External Email >=20 > ---------------------------------------------------------------------- > This patchset is in that grey area between new feature and bugfix so > it > might need to be CC'd to stable@dpdk.org " Shall I remove it now? >=20 >=20 >=20