From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 7BC8AA00E6
	for <public@inbox.dpdk.org>; Thu, 11 Jul 2019 16:18:56 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 29D6F7CBC;
	Thu, 11 Jul 2019 16:18:55 +0200 (CEST)
Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com
 [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id 407EA5680
 for <dev@dpdk.org>; Thu, 11 Jul 2019 16:18:54 +0200 (CEST)
Received: from core.dev.6wind.com (unknown [10.0.0.1])
 by proxy.6wind.com (Postfix) with ESMTPS id 23CD02E57F3;
 Thu, 11 Jul 2019 16:18:54 +0200 (CEST)
Received: from [10.16.0.195] (helo=6wind.com)
 by core.dev.6wind.com with smtp (Exim 4.84_2)
 (envelope-from <olivier.matz@6wind.com>)
 id 1hlZuP-0001d8-30; Thu, 11 Jul 2019 16:18:54 +0200
Received: by 6wind.com (sSMTP sendmail emulation);
 Thu, 11 Jul 2019 16:18:53 +0200
Date: Thu, 11 Jul 2019 16:18:53 +0200
From: Olivier Matz <olivier.matz@6wind.com>
To: "Musatescu, Flavia" <flavia.musatescu@intel.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
 David Marchand <david.marchand@redhat.com>,
 Bruce Richardson <bruce.richardson@intel.com>
Message-ID: <20190711141852.mk4b6yr6uswzksja@glumotte.dev.6wind.com>
References: <20190523074318.29044-1-olivier.matz@6wind.com>
 <20190705135822.1797-1-olivier.matz@6wind.com>
 <a7bff252-a6d6-e3b5-6a9e-0aa3e2870a63@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <a7bff252-a6d6-e3b5-6a9e-0aa3e2870a63@intel.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Subject: Re: [dpdk-dev] [PATCH v2] devtools: better freebsd support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

On Tue, Jul 09, 2019 at 12:05:59PM +0100, Musatescu, Flavia wrote:
> 
> On 05/07/2019 14:58, Olivier Matz wrote:
> > - As "readlink -e" and "readlink -m" do not exist on freebsd,
> >    use "readlink -f", it should not have any impact in these cases.
> > - "sed -ri" is invalid on freebsd and should be replaced by
> >    "sed -ri=''"
> > - Use gmake instead of make.
> > 
> > This fixes the following command:
> >    SYSDIR=/usr/src/sys ./devtools/test-build.sh \
> >      -j4 x86_64-native-freebsd-gcc
> > 
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>

(...)

> The example applications are being built in a wrong location when using the
> test-build.sh script on FreeBSD (“/app_name/x86_64-native-freebsd-gcc/”
> instead of “$(dpdk_path)/x86_64-native-freebsd-gcc/examples/app_name/x86_64-native-freebsd-gcc/”.
> 
> 
> The output build directory for the example applications is specified by
> O=$(readlink -f $dir/examples) variable inside the test-build.sh script. On
> FreeBSD "readlink -f" prints nothing when the file path doesn't exist, so
> the output build directory for each application ends up being configured to
> "/./app_name/x86_64-native-freebsd-gcc" (this is done inside the
> mk/rte.extsubdir.mk file).
> 
> A possible solution for this could be to modify the output directory to
> O=$(readlink -f $dir)/examples.

Thanks for spotting this. I will send a v3.