From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 958A8A00E6 for ; Fri, 12 Jul 2019 09:55:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 22B9C1B9A7; Fri, 12 Jul 2019 09:55:51 +0200 (CEST) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 3453A4C8E for ; Fri, 12 Jul 2019 09:55:49 +0200 (CEST) Received: by mail-wm1-f67.google.com with SMTP id w9so8632663wmd.1 for ; Fri, 12 Jul 2019 00:55:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:mime-version:content-disposition :content-transfer-encoding:user-agent; bh=+JSEWCEHnsTAkRRO2fujTctEJGaN9KxjyT0sURmsP44=; b=M2mCDf+asMtFhoJaXZIh42DazjrDTb0+3zIRR/DSl5pAtxT0KlaQqxv/r1/pG5AjVc VuINhGxBCThu6PKkO805ggaH6JC+vONI3cRlm+rQLB7EwQ0o5MpJ4bd26PtQAHuFr2EJ ig3ZEv3Sj/oKiyLCoizzd12keTDQt6RAYa5clC6pw1yY4W0u8Zls+eMXMVbt9R4aSRtt 69dla8PyBdjWSHNaFxFGo0BANxp3lQAMXliOgk9ZeOLhQWmAj7rQ8bDDUhB3L8wx/Lom YtPVLHEHIHzr5bP2uxZ6ERCGtsV9tD88AE+vUDGjL49XXIFshfUAbEpCOUxBN8XtNYSa h17w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:content-transfer-encoding:user-agent; bh=+JSEWCEHnsTAkRRO2fujTctEJGaN9KxjyT0sURmsP44=; b=DGjcjKPk0K2ZkFqsCinYX539nxaurEd45/RvAGOEC/f1YlJflbwNTO1h/3Q4ga40f6 1m28Nf0TuOr2urjDygytPu2hK0nXhw6hVKT/sweh0EmV4ZDueE+blNWsBrZDNHeRVnxj tButAQtBBkxPtxy4tn+lu7LEgUQTcCA/DBP7et0JIh47mbwjnER4Y32ydCDgg2qAE18D ySaUZ4v5arN87U1yd49MBfzcjjgD81FR1b5F32g0JIwTseoEF7b2sXuYvwear1xSpTXf qkImRI3w4+MOjkmBfU0MtgS9cXqhVSehhAAqMUbY07kPWaD0hW2hnYDDJ/nAkgWow+r8 cgUw== X-Gm-Message-State: APjAAAX6JrtSuMSHuvqIFeMnOXP7u2CXrmsDI5FqqUHo4lD2LBZ2uMku Ex6WAA2Qjesm7b6kXIx7J9NCb2Gf X-Google-Smtp-Source: APXvYqxdvsP+f1zojYlHlvjkytwOKN7gftmJ0NDlOTZLjWWlocj/a3BIa2NwvVhoTHdkK3onQ3Gmhw== X-Received: by 2002:a7b:c651:: with SMTP id q17mr7720267wmk.136.1562918148580; Fri, 12 Jul 2019 00:55:48 -0700 (PDT) Received: from localhost.localdomain (81.89.53.154.host.vnet.sk. [81.89.53.154]) by smtp.gmail.com with ESMTPSA id w23sm8053135wmi.45.2019.07.12.00.55.47 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 12 Jul 2019 00:55:48 -0700 (PDT) Date: Fri, 12 Jul 2019 09:55:46 +0200 From: =?iso-8859-1?Q?J=FAlius?= Milan To: dev@dpdk.org, xiaolong.ye@intel.com, qi.z.zhang@intel.com, david.marchand@redhat.com Message-ID: <20190712075546.GA20880@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.12.0 (2019-05-25) Subject: [dpdk-dev] [PATCH] net/af_xdp: fix xdp_get_channels_info return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Procedure xdp_get_channels_info was returning error code -1 in case of ioctl command SIOCETHTOOL was not supported. This patch sets return value back to 0 as it is valid case. Fixes: 339b88c6a9 ("net/af_xdp: support multi-queue") Signed-off-by: Július Milan --- drivers/net/af_xdp/rte_eth_af_xdp.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c index ff8e90589..33352e10a 100644 --- a/drivers/net/af_xdp/rte_eth_af_xdp.c +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c @@ -852,9 +852,13 @@ xdp_get_channels_info(const char *if_name, int *max_queues, ifr.ifr_data = (void *)&channels; strncpy(ifr.ifr_name, if_name, IFNAMSIZ); ret = ioctl(fd, SIOCETHTOOL, &ifr); - if (ret && errno != EOPNOTSUPP) { - ret = -errno; - goto out; + if (ret) { + if (errno == EOPNOTSUPP) { + ret = 0; + } else { + ret = -errno; + goto out; + } } if (channels.max_combined == 0 || errno == EOPNOTSUPP) { -- 2.21.0