From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39666A0471 for ; Mon, 15 Jul 2019 17:48:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 702C94CE4; Mon, 15 Jul 2019 17:48:50 +0200 (CEST) Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id 529E62E81 for ; Mon, 15 Jul 2019 17:48:49 +0200 (CEST) Received: by mail-pf1-f193.google.com with SMTP id p184so7603940pfp.7 for ; Mon, 15 Jul 2019 08:48:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vC+YGKxGAz2lCLE4uTNnGVQ03JkDqjMce75Nl3j4N7A=; b=ZfOZwLn+9kQ/E02WXo5X3oaIRTlafDPJMVylMcTs+tlMJy3HXehezdKlnwZJd6qS2s GVzVN1h30AYyHlJgT5/lz4DCU+MO6gOSimkG+c4Cqo4HMK1+84gU+pBRVsIgA112ERqk HwOJubVXZoJ58yBvk/mKNxMHMdw2Ks9Ex84bFBRzXMc1L2A9GckBy8qHQQiD+513VW7V cTuWMX6sXcA9LTMPPUgEsAvQXUWiR9BZpTmtc2D361rA0NmyjUMLBFgg67eaeoP6Gu17 ZivCKeOCVxmPMJq83agfnWvFH7hPv1hwV9qu7TnU71mYNs8baQKxXl9v2kRnS3DGTfwz VBgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vC+YGKxGAz2lCLE4uTNnGVQ03JkDqjMce75Nl3j4N7A=; b=goZRtWO/Puy/uErU9+8UGo8QlX2wIakpT1GXoXU4TQOcSKRZBDWrOxhqP5mXvRLACt M9OTHaCzACYnx3kuDdfXIdpwESVKKDqseEmY65eDWf8bciiB+f91zCF/W+Yi0vAG6PAe x7KbhudEWy1XLw23sm6+XPveQeyvqXdvKqWV1T+nQo60EroGp9LoO1C93jhOnFsVcbHl T/XqVaf+c4XYFdIVXQLCEcp+Z7ony9cbwigFbntwhLucb+5igVOVKyPZXCyR0DCbYu8h ZrjuWp4ehoPHUON2oCPxGp+lqquJ9mlf6E/xuV+kwThwDD/VybdxHhX9sNKFCT5+yU7q jTcQ== X-Gm-Message-State: APjAAAXk22ZyZboRtZigjUiFDG+qpNKTVkRxzxKiJZevfGFBIASPvzkE 2YyXuKOB8bisBcRwfCJzhw4= X-Google-Smtp-Source: APXvYqwh16ZjqaUTC8aX22bIxfLfdulpZziryRHoFm9TWhrdelsPlChgxLBXVEggCEbEaAhjGwLh2g== X-Received: by 2002:a63:ed06:: with SMTP id d6mr27654624pgi.267.1563205728221; Mon, 15 Jul 2019 08:48:48 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id s15sm17839524pfd.183.2019.07.15.08.48.47 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 15 Jul 2019 08:48:48 -0700 (PDT) Date: Mon, 15 Jul 2019 08:48:41 -0700 From: Stephen Hemminger To: Erik Gabriel Carrillo Cc: thomas@monjalon.net, dev@dpdk.org, stable@dpdk.org Message-ID: <20190715084841.4f6baebf@hermes.lan> In-Reply-To: <1563205172-352-2-git-send-email-erik.g.carrillo@intel.com> References: <1563205172-352-1-git-send-email-erik.g.carrillo@intel.com> <1563205172-352-2-git-send-email-erik.g.carrillo@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/2] timer: fix null pointer dereference X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 15 Jul 2019 10:39:31 -0500 Erik Gabriel Carrillo wrote: > If the timer subsystem is not initialized before rte_timer_manage (for > example) is invoked, a pointer to a shared hugepage memory region will > still be null and dereferenced when it is checked for validity; handle > this case. > > Fixes: c0749f7096c7 ("timer: allow management in shared memory") > Cc: stable@dpdk.org > > Signed-off-by: Erik Gabriel Carrillo I have mixed feelings about this patch. Any calls to rte_timer before rte_timer_subsystem_init is not a valid usage. Better to kill the application.