From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E43CA0471 for ; Tue, 16 Jul 2019 02:16:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 415A02C23; Tue, 16 Jul 2019 02:16:26 +0200 (CEST) Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by dpdk.org (Postfix) with ESMTP id 6241B2C23 for ; Tue, 16 Jul 2019 02:16:24 +0200 (CEST) Received: by mail-pl1-f196.google.com with SMTP id az7so9119675plb.5 for ; Mon, 15 Jul 2019 17:16:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BI9E6QvUMqRxjBMLJx8Kgh1Z2meOiqiUPXn+CWwp+uk=; b=1TMkbF84yS1S9cip1qjZU95JYPeZ2k85zNtRo6SsRGnF2Eyx4qOb2btiImqAmJ8QNQ bQyAzXbLe66oPK7CoCJR0RAV07HihUT86WDAHIoLwL8iIRGBJAhMzElTabk/poe1TFQz qDCdOyKy1irz52bU4caAsKe8ttmnTR87x9IIWiK8PuQlGL5M+ca6Zwk9LOPZM4wcIUUh EYtnTj2Qk5TsoKGJAg6+QNiVZvNnZgxVV4M3nqjRlWSnT0dFcsTY6B/8RJbKhvqRC+un p9CjM13+Q5FZNPCm7Oo32Lit3F+NVv0SWQ5mCZabJwt8lsZ8fqVeiCMZ5kWIZ11TLNSE BP2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BI9E6QvUMqRxjBMLJx8Kgh1Z2meOiqiUPXn+CWwp+uk=; b=XT2wLqlFl3CJPODwTkRnOzXkDYx1/qg9xuFUMVeeGOEMPbFg+0y2ylS+ENez06rvWb Vil6QKQIrQEy7ZyNejVv1omVR0cNednRQixnn3rU1egKqMtAHT959wnA4Rx4awnO2OiN XbjlyoPKXWhfyuGKzLvaPZCNTUskUTs/ym6Tp/qdeaThmBlF3WBJAXY430pVQCTKRbsE QNcAByqBUGSPQv5kx2uNWZdNlAI8fUGC5Ghf6ANznjIXwCDnDkjPvyZxGbvtGDA5W60J gGwX1DTMiXziHCf5lAlKzewXy+WqT7CAJF4D/vSw6QXiXz7MsXPqqjuhhUeT58sZ/igl LP5g== X-Gm-Message-State: APjAAAUlRGnw2joFRnpUVb6LZWURu/ciIIzCwj73W4hZtkX7IxDzXBYu lo3v27lxs5Hz9eF75HETRSM= X-Google-Smtp-Source: APXvYqzKj1uJP3yRjVpvgSVt+4n5qn7tKZ+pptRF/kTlFKyq62n57RbDYG3qGGg6iOFjFeESd6/feA== X-Received: by 2002:a17:902:290b:: with SMTP id g11mr30928980plb.26.1563236183512; Mon, 15 Jul 2019 17:16:23 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id q36sm16354957pgl.23.2019.07.15.17.16.23 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 15 Jul 2019 17:16:23 -0700 (PDT) Date: Mon, 15 Jul 2019 17:16:16 -0700 From: Stephen Hemminger To: thomas@monjalon.net Cc: dev@dpdk.org, stable@dpdk.org Message-ID: <20190715171616.74012e40@hermes.lan> In-Reply-To: <20190715234136.3526-1-stephen@networkplumber.org> References: <20190715234136.3526-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] pci: fix missing pci bus with shared library build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 15 Jul 2019 16:41:36 -0700 Stephen Hemminger wrote: > If DPDK is built as a shared library, then any application linked > with rte.app.mk will not find any PCI devices. When the application > is started no ethernet devices are found. > > This is because the link order of libraries on the command line matters. > And PCI is before EAL. That causes there to be no dependency on PCI > so linker ignores linking the library. > Swapping the order fixes this. > > Fixes: c752998b5e2e ("pci: introduce library and driver") > Cc: stable@dpdk.org > Signed-off-by: Stephen Hemminger > --- > mk/rte.app.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mk/rte.app.mk b/mk/rte.app.mk > index a277c808ed8e..470b92e4d73e 100644 > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -90,8 +90,8 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_STACK) += -lrte_stack > _LDLIBS-$(CONFIG_RTE_DRIVER_MEMPOOL_RING) += -lrte_mempool_ring > _LDLIBS-$(CONFIG_RTE_LIBRTE_OCTEONTX2_MEMPOOL) += -lrte_mempool_octeontx2 > _LDLIBS-$(CONFIG_RTE_LIBRTE_RING) += -lrte_ring > -_LDLIBS-$(CONFIG_RTE_LIBRTE_PCI) += -lrte_pci > _LDLIBS-$(CONFIG_RTE_LIBRTE_EAL) += -lrte_eal > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PCI) += -lrte_pci > _LDLIBS-$(CONFIG_RTE_LIBRTE_CMDLINE) += -lrte_cmdline > _LDLIBS-$(CONFIG_RTE_LIBRTE_REORDER) += -lrte_reorder > _LDLIBS-$(CONFIG_RTE_LIBRTE_SCHED) += -lrte_sched This only seems to happen on 18.11 and if configuration is reduced.