From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 72793A0471 for ; Tue, 16 Jul 2019 22:06:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 369682BF5; Tue, 16 Jul 2019 22:06:20 +0200 (CEST) Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id 01D762BAB for ; Tue, 16 Jul 2019 22:06:18 +0200 (CEST) Received: by mail-pg1-f194.google.com with SMTP id w10so9966664pgj.7 for ; Tue, 16 Jul 2019 13:06:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QR2MQOGTSE90tqygkZMLdFs1baOL95v/RZKIW1axruk=; b=Ab01lduh6UwvqCUUJd2PhsJFnVVS0WjljLkOyq54RVbd1bvsOPkTcZ8GqJXBQm8CeU +JjGRoktBnqw4TyNoT43dR5uL8utazzYdEH27logY+TpXFaDBmYY6c51suHgqlUzciQc l0BYW8uQbWVjJwjjOSolqYJERlOnMAu52UWTahp+G3pHCAjXzVPiGSJ37WyJiKyV1dW6 Z84blo3fs0fyzIvQv8sUvOzk3ESybG+th3X+PQG6O/oLG06G0hXHoryE8lo0G1SEbEFf S3jLWBDkCylymYbUlwB6BRJVDTrSLiPGlcr5xgiVsldmpf24KrNuyp0HkJ4XaBF1xc2O tRyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QR2MQOGTSE90tqygkZMLdFs1baOL95v/RZKIW1axruk=; b=RicwCHrM4VCKnFjg9hP6+8o70YYf5a64KP8MTsxz2q9cy45hCy0Ro3qqKtcjULcmT5 KUR/kS3EQ+5TitYDTO2r3lIR2al9Am2gylv/F4fQTH4Irs1FnyKeIuSUuXQ7rt62Nixl LkUJhVK/0Xj7y58lWMEQVtVUYY7J8/VpPP+2zSTNQEc5OSBVfYLX4m+O0CFb0y2vZsDc zXfKi/SCagWkavFVli2Q0pBJxAeLdpLbbLvj/TVXBw+nw6+pd8Z63ygBvqfyXlNe/9+Y SF0GXBCwqVgR3hqBfcT3jBwqjJTnT7UAFwEr6ntd8/mC+R9vDZyI90RIU14HY6gTA1p8 +emw== X-Gm-Message-State: APjAAAWgUpmrBVENN57ouDWy59AVOE7Ab8K8QZ8HTLem+mm/Oehr675P wuZN4zXmB0HT0HURoHPBQjY= X-Google-Smtp-Source: APXvYqw+NnT6iVFdtK7tx5Us454hVsN9oprIjvjras0VZ6wXA3tbxbNIF4iefnxItEpVZmcFcinInQ== X-Received: by 2002:a17:90a:2343:: with SMTP id f61mr39472580pje.130.1563307578011; Tue, 16 Jul 2019 13:06:18 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id a3sm10207993pfc.70.2019.07.16.13.06.17 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 16 Jul 2019 13:06:17 -0700 (PDT) Date: Tue, 16 Jul 2019 13:06:11 -0700 From: Stephen Hemminger To: Nithin Dabilpuram Cc: Hyong Youb Kim , David Marchand , Thomas Monjalon , "Ferruh Yigit" , Anatoly Burakov , , John Daley , Shahed Shaikh , Message-ID: <20190716130611.5e41d124@hermes.lan> In-Reply-To: <20190716164424.16776-1-ndabilpuram@marvell.com> References: <20190716164424.16776-1-ndabilpuram@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC PATCH v3 1/3] vfio: revert change that does intr eventfd setup at probe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 16 Jul 2019 22:14:22 +0530 Nithin Dabilpuram wrote: > This reverts commit 89aac60e0be9ed95a87b16e3595f102f9faaffb4. > "vfio: fix interrupts race condition" > > The above mentioned commit moves the interrupt's eventfd setup > to probe time but only enables one interrupt for all types of > interrupt handles i.e VFIO_MSI, VFIO_LEGACY, VFIO_MSIX, UIO. > It works fine with default case but breaks below cases specifically > for MSIX based interrupt handles. > > * Applications like l3fwd-power that request rxq interrupts > while ethdev setup. > * Drivers that need > 1 MSIx interrupts to be configured for > functionality to work. > > VFIO PCI for MSIx expects all the possible vectors to be setup up > when using VFIO_IRQ_SET_ACTION_TRIGGER so that they can be > allocated from kernel pci subsystem. Only way to increase the number > of vectors later is first free all by using VFIO_IRQ_SET_DATA_NONE > with action trigger and then enable new vector count. > > Above commit changes the behavior of rte_intr_[enable|disable] to > only mask and unmask unlike earlier behavior and thereby > breaking above two scenarios. > > Fixes: 89aac60e0be9 ("vfio: fix interrupts race condition") > Cc: david.marchand@redhat.com > > Signed-off-by: Nithin Dabilpuram This fixes the problem I am seeing with MSI-X. Even with testpmd... EAL: Error enabling MSI-X interrupts for fd 39 Tested-by: Stephen Hemminger