DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/pcap: fix single iface support
@ 2019-07-16 14:26 A.McLoughlin
  2019-07-16 14:31 ` Ferruh Yigit
  0 siblings, 1 reply; 3+ messages in thread
From: A.McLoughlin @ 2019-07-16 14:26 UTC (permalink / raw)
  To: Ferruh Yigit; +Cc: dev, A.McLoughlin, cian.ferriter

Because of the commit mentioned below the default case was changed and
this broke single_iface support. This patch adds a check to fix
single_iface support.

Fixes: a3f5252e5cbd ("net/pcap: enable infinitely Rx a pcap file")
Cc: cian.ferriter@intel.com

Signed-off-by: A.McLoughlin <aideen.mcloughlin@intel.com>
---
 drivers/net/pcap/rte_eth_pcap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c
index 26e85183e..941e54c76 100644
--- a/drivers/net/pcap/rte_eth_pcap.c
+++ b/drivers/net/pcap/rte_eth_pcap.c
@@ -1322,7 +1322,7 @@ eth_from_pcaps(struct rte_vdev_device *vdev,
 	/* Assign tx ops. */
 	if (devargs_all->is_tx_pcap)
 		eth_dev->tx_pkt_burst = eth_pcap_tx_dumper;
-	else if (devargs_all->is_tx_iface)
+	else if (devargs_all->is_tx_iface || single_iface)
 		eth_dev->tx_pkt_burst = eth_pcap_tx;
 	else
 		eth_dev->tx_pkt_burst = eth_tx_drop;
-- 
2.17.1

--------------------------------------------------------------
Intel Research and Development Ireland Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263


This e-mail and any attachments may contain confidential material for the sole
use of the intended recipient(s). Any review or distribution by others is
strictly prohibited. If you are not the intended recipient, please contact the
sender and delete all copies.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] net/pcap: fix single iface support
  2019-07-16 14:26 [dpdk-dev] [PATCH] net/pcap: fix single iface support A.McLoughlin
@ 2019-07-16 14:31 ` Ferruh Yigit
  2019-07-16 18:18   ` Ferruh Yigit
  0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2019-07-16 14:31 UTC (permalink / raw)
  To: A.McLoughlin; +Cc: dev, cian.ferriter

On 7/16/2019 3:26 PM, A.McLoughlin wrote:
> Because of the commit mentioned below the default case was changed and
> this broke single_iface support. This patch adds a check to fix
> single_iface support.
> 
> Fixes: a3f5252e5cbd ("net/pcap: enable infinitely Rx a pcap file")
> Cc: cian.ferriter@intel.com
> 
> Signed-off-by: A.McLoughlin <aideen.mcloughlin@intel.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] net/pcap: fix single iface support
  2019-07-16 14:31 ` Ferruh Yigit
@ 2019-07-16 18:18   ` Ferruh Yigit
  0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2019-07-16 18:18 UTC (permalink / raw)
  To: A.McLoughlin; +Cc: dev, cian.ferriter

On 7/16/2019 3:31 PM, Ferruh Yigit wrote:
> On 7/16/2019 3:26 PM, A.McLoughlin wrote:
>> Because of the commit mentioned below the default case was changed and
>> this broke single_iface support. This patch adds a check to fix
>> single_iface support.
>>
>> Fixes: a3f5252e5cbd ("net/pcap: enable infinitely Rx a pcap file")
>> Cc: cian.ferriter@intel.com
>>
>> Signed-off-by: A.McLoughlin <aideen.mcloughlin@intel.com>
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 

Applied to dpdk-next-net/master, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-07-16 18:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-16 14:26 [dpdk-dev] [PATCH] net/pcap: fix single iface support A.McLoughlin
2019-07-16 14:31 ` Ferruh Yigit
2019-07-16 18:18   ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).