From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81367A0471 for ; Thu, 18 Jul 2019 16:37:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C54D21B94E; Thu, 18 Jul 2019 16:36:52 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 2ED2E1B953 for ; Thu, 18 Jul 2019 16:36:51 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jul 2019 07:36:50 -0700 X-IronPort-AV: E=Sophos;i="5.64,278,1559545200"; d="scan'208";a="162088685" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jul 2019 07:36:49 -0700 Date: Thu, 18 Jul 2019 15:36:45 +0100 From: Bruce Richardson To: Stephen Hemminger Cc: dev@dpdk.org Message-ID: <20190718143645.GA1641@bricha3-MOBL.ger.corp.intel.com> References: <20190716172741.21399-1-stephen@networkplumber.org> <20190718004822.25431-1-stephen@networkplumber.org> <20190718004822.25431-3-stephen@networkplumber.org> <20190718083111.GA1325@bricha3-MOBL.ger.corp.intel.com> <20190718073459.3004bb39@hermes.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190718073459.3004bb39@hermes.lan> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH v2 2/3] cfgfile: use RTE_LOG for errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 18, 2019 at 07:34:59AM -0700, Stephen Hemminger wrote: > On Thu, 18 Jul 2019 09:31:11 +0100 > Bruce Richardson wrote: > > > On Wed, Jul 17, 2019 at 05:48:21PM -0700, Stephen Hemminger wrote: > > > In general, DPDK libraries to not print error messages to > > > stdout because that is often redirected to /dev/null for daemons. > > > This patch changes cfgfile library to use RTE_LOG with its > > > own type. > > > > > > Signed-off-by: Stephen Hemminger > > > --- > > > lib/librte_cfgfile/Makefile | 1 + > > > lib/librte_cfgfile/rte_cfgfile.c | 38 +++++++++++++++++++++++--------- > > > 2 files changed, 29 insertions(+), 10 deletions(-) > > > > > > diff --git a/lib/librte_cfgfile/Makefile b/lib/librte_cfgfile/Makefile > > > index d9512565e559..4fc711778699 100644 > > > --- a/lib/librte_cfgfile/Makefile > > > +++ b/lib/librte_cfgfile/Makefile > > > @@ -11,6 +11,7 @@ LIB = librte_cfgfile.a > > > CFLAGS += -O3 > > > CFLAGS += $(WERROR_FLAGS) > > > CFLAGS += -I$(SRCDIR)/../librte_eal/common/include > > > +LDFLAGS += -lrte_log > > > > > Where does this come from, there is no separate log library in DPDK? > > I saw a build failure with previous patch about rte_log not being > present. I can believe that, it's just how does this help? What does the linker pick up when you pass this?