From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A40FA0471 for ; Fri, 19 Jul 2019 12:57:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5FF562BA8; Fri, 19 Jul 2019 12:57:23 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 0A7263DC for ; Fri, 19 Jul 2019 12:57:20 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jul 2019 03:57:20 -0700 X-IronPort-AV: E=Sophos;i="5.64,282,1559545200"; d="scan'208";a="159072010" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jul 2019 03:57:19 -0700 Date: Fri, 19 Jul 2019 11:57:16 +0100 From: Bruce Richardson To: Stephen Hemminger Cc: dev@dpdk.org Message-ID: <20190719105716.GA1647@bricha3-MOBL.ger.corp.intel.com> References: <20190709150257.GB497@bricha3-MOBL.ger.corp.intel.com> <20190718220910.8248-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190718220910.8248-1-stephen@networkplumber.org> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH] doc: add deprecation notice about changes to ethernet structures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 18, 2019 at 03:09:10PM -0700, Stephen Hemminger wrote: > Tell users about upcoming changes to rte_ether_addr and > rte_ether_header. > > Signed-off-by: Stephen Hemminger > --- > doc/guides/rel_notes/deprecation.rst | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index a7796f49b9fe..9c20a47b3e4c 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -82,3 +82,12 @@ Deprecation Notices > to set new power environment if power environment was already initialized. > In this case the function will return -1 unless the environment is unset first > (using ``rte_power_unset_env``). Other function usage scenarios will not change. > + > +* net: the Ethernet address and header defintions will change attributes. > + The Ethernet address struct will no longer be marked as packed since > + since the packed attribute is meaningless on a byte array. > + The Etherne header will be marked as aligned on a 2 byte boundary (and > + no longer packed). This allows for efficient access on all CPU's. > + These changes should not impact normal usage drivers naturally > + align the Ethernet header on receive, and almost every encapsulation > + preserves the alignment. > -- > 2.17.1 More comprehensive deprecation notice than mine, so: Acked-by: Bruce Richardson One suggested change, rather than "almost every encapsulation" can we put it down as "all known encapsulations". If there is even a single public spec, in-real-use encapsulation that is used that does not preserve alignment, we should not do this. Saying "almost every" implies that we know of ones that don't, which I don't believe is the case. /Bruce