* [dpdk-dev] [PATCH 1/3] bus/dpaa: fix to remove err print for non-dpaa devices
@ 2019-07-22 6:54 Hemant Agrawal
2019-07-22 6:54 ` [dpdk-dev] [PATCH 2/3] bus/fslmc: fix to remove err print for non-fslmc devices Hemant Agrawal
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Hemant Agrawal @ 2019-07-22 6:54 UTC (permalink / raw)
To: dev, ferruh.yigit
This patch removes the unneccessary err prints when using
non-dpaa devices.
Fixes: e79df833d3f6 ("bus/dpaa: support hotplug ops")
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
drivers/bus/dpaa/dpaa_bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c
index c2563cc26..07cc5c667 100644
--- a/drivers/bus/dpaa/dpaa_bus.c
+++ b/drivers/bus/dpaa/dpaa_bus.c
@@ -699,7 +699,7 @@ dpaa_bus_dev_iterate(const void *start, const char *str,
/* Expectation is that device would be name=device_name */
if (strncmp(str, "name=", 5) != 0) {
- DPAA_BUS_ERR("Invalid device string (%s)\n", str);
+ DPAA_BUS_DEBUG("Invalid device string (%s)\n", str);
return NULL;
}
--
2.17.1
^ permalink raw reply [flat|nested] 8+ messages in thread* [dpdk-dev] [PATCH 2/3] bus/fslmc: fix to remove err print for non-fslmc devices
2019-07-22 6:54 [dpdk-dev] [PATCH 1/3] bus/dpaa: fix to remove err print for non-dpaa devices Hemant Agrawal
@ 2019-07-22 6:54 ` Hemant Agrawal
2019-07-22 6:54 ` [dpdk-dev] [PATCH 3/3] bus/fslmc: fix the compliation err with ppc64 compiler Hemant Agrawal
2019-07-22 10:03 ` [dpdk-dev] [PATCH v2 1/3] bus/dpaa: fix to remove err print for non-dpaa devices Hemant Agrawal
2 siblings, 0 replies; 8+ messages in thread
From: Hemant Agrawal @ 2019-07-22 6:54 UTC (permalink / raw)
To: dev, ferruh.yigit
This patch removes the unneccessary err prints when using
non-dpaa2 devices.
Fixes: e67a61614d0b ("bus/fslmc: support device iteration")
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
drivers/bus/fslmc/fslmc_bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c
index 9e4146aba..a2f482516 100644
--- a/drivers/bus/fslmc/fslmc_bus.c
+++ b/drivers/bus/fslmc/fslmc_bus.c
@@ -601,7 +601,7 @@ fslmc_bus_dev_iterate(const void *start, const char *str,
/* Expectation is that device would be name=device_name */
if (strncmp(str, "name=", 5) != 0) {
- DPAA2_BUS_ERR("Invalid device string (%s)\n", str);
+ DPAA2_BUS_DEBUG("Invalid device string (%s)\n", str);
return NULL;
}
--
2.17.1
^ permalink raw reply [flat|nested] 8+ messages in thread* [dpdk-dev] [PATCH 3/3] bus/fslmc: fix the compliation err with ppc64 compiler
2019-07-22 6:54 [dpdk-dev] [PATCH 1/3] bus/dpaa: fix to remove err print for non-dpaa devices Hemant Agrawal
2019-07-22 6:54 ` [dpdk-dev] [PATCH 2/3] bus/fslmc: fix to remove err print for non-fslmc devices Hemant Agrawal
@ 2019-07-22 6:54 ` Hemant Agrawal
2019-07-22 8:16 ` Thomas Monjalon
2019-07-22 10:03 ` [dpdk-dev] [PATCH v2 1/3] bus/dpaa: fix to remove err print for non-dpaa devices Hemant Agrawal
2 siblings, 1 reply; 8+ messages in thread
From: Hemant Agrawal @ 2019-07-22 6:54 UTC (permalink / raw)
To: dev, ferruh.yigit
fslmc_vfio.c:387:36: note: format string is defined here
DPAA2_BUS_DEBUG("VFIO dmamap 0x%llx:0x%llx, size 0x%llx\n",
format ‘%llx’ expects argument of type ‘long long unsigned int’
argument 6 has type ‘__u64 {aka long unsigned int}’
Fixes: 2b5fa25708cf ("mempool/dpaa2: map external memory with VFIO")
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
drivers/bus/fslmc/fslmc_vfio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/fslmc/fslmc_vfio.c b/drivers/bus/fslmc/fslmc_vfio.c
index 247b2a4a1..564bef9cb 100644
--- a/drivers/bus/fslmc/fslmc_vfio.c
+++ b/drivers/bus/fslmc/fslmc_vfio.c
@@ -384,7 +384,7 @@ rte_fslmc_vfio_mem_dmamap(uint64_t vaddr, uint64_t iova, uint64_t size)
dma_map.vaddr = vaddr;
dma_map.iova = iova;
- DPAA2_BUS_DEBUG("VFIO dmamap 0x%llx:0x%llx, size 0x%llx\n",
+ DPAA2_BUS_DEBUG("VFIOdmamap 0x%"PRIx64":0x%"PRIx64",size 0x%"PRIx64"\n",
dma_map.vaddr, dma_map.iova, dma_map.size);
ret = ioctl(group->container->fd, VFIO_IOMMU_MAP_DMA,
&dma_map);
--
2.17.1
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [PATCH 3/3] bus/fslmc: fix the compliation err with ppc64 compiler
2019-07-22 6:54 ` [dpdk-dev] [PATCH 3/3] bus/fslmc: fix the compliation err with ppc64 compiler Hemant Agrawal
@ 2019-07-22 8:16 ` Thomas Monjalon
0 siblings, 0 replies; 8+ messages in thread
From: Thomas Monjalon @ 2019-07-22 8:16 UTC (permalink / raw)
To: Hemant Agrawal; +Cc: dev, ferruh.yigit
22/07/2019 08:54, Hemant Agrawal:
> fslmc_vfio.c:387:36: note: format string is defined here
> DPAA2_BUS_DEBUG("VFIO dmamap 0x%llx:0x%llx, size 0x%llx\n",
>
> format ‘%llx’ expects argument of type ‘long long unsigned int’
> argument 6 has type ‘__u64 {aka long unsigned int}’
>
> Fixes: 2b5fa25708cf ("mempool/dpaa2: map external memory with VFIO")
>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
> --- a/drivers/bus/fslmc/fslmc_vfio.c
> +++ b/drivers/bus/fslmc/fslmc_vfio.c
> - DPAA2_BUS_DEBUG("VFIO dmamap 0x%llx:0x%llx, size 0x%llx\n",
> + DPAA2_BUS_DEBUG("VFIOdmamap 0x%"PRIx64":0x%"PRIx64",size 0x%"PRIx64"\n",
> dma_map.vaddr, dma_map.iova, dma_map.size);
It gives this error:
drivers/bus/fslmc/fslmc_logs.h:18:44: error:
format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘__u64’
I don't understand what happens. Where is the '%lx'?
^ permalink raw reply [flat|nested] 8+ messages in thread
* [dpdk-dev] [PATCH v2 1/3] bus/dpaa: fix to remove err print for non-dpaa devices
2019-07-22 6:54 [dpdk-dev] [PATCH 1/3] bus/dpaa: fix to remove err print for non-dpaa devices Hemant Agrawal
2019-07-22 6:54 ` [dpdk-dev] [PATCH 2/3] bus/fslmc: fix to remove err print for non-fslmc devices Hemant Agrawal
2019-07-22 6:54 ` [dpdk-dev] [PATCH 3/3] bus/fslmc: fix the compliation err with ppc64 compiler Hemant Agrawal
@ 2019-07-22 10:03 ` Hemant Agrawal
2019-07-22 10:03 ` [dpdk-dev] [PATCH v2 2/3] bus/fslmc: fix to remove err print for non-fslmc devices Hemant Agrawal
` (2 more replies)
2 siblings, 3 replies; 8+ messages in thread
From: Hemant Agrawal @ 2019-07-22 10:03 UTC (permalink / raw)
To: dev, ferruh.yigit
This patch removes the unnecessary err prints when using
non-dpaa devices.
Fixes: e79df833d3f6 ("bus/dpaa: support hotplug ops")
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
drivers/bus/dpaa/dpaa_bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c
index c2563cc26..07cc5c667 100644
--- a/drivers/bus/dpaa/dpaa_bus.c
+++ b/drivers/bus/dpaa/dpaa_bus.c
@@ -699,7 +699,7 @@ dpaa_bus_dev_iterate(const void *start, const char *str,
/* Expectation is that device would be name=device_name */
if (strncmp(str, "name=", 5) != 0) {
- DPAA_BUS_ERR("Invalid device string (%s)\n", str);
+ DPAA_BUS_DEBUG("Invalid device string (%s)\n", str);
return NULL;
}
--
2.17.1
^ permalink raw reply [flat|nested] 8+ messages in thread* [dpdk-dev] [PATCH v2 2/3] bus/fslmc: fix to remove err print for non-fslmc devices
2019-07-22 10:03 ` [dpdk-dev] [PATCH v2 1/3] bus/dpaa: fix to remove err print for non-dpaa devices Hemant Agrawal
@ 2019-07-22 10:03 ` Hemant Agrawal
2019-07-22 10:03 ` [dpdk-dev] [PATCH v2 3/3] bus/fslmc: fix the compliation err with ppc64 compiler Hemant Agrawal
2019-07-22 14:14 ` [dpdk-dev] [PATCH v2 1/3] bus/dpaa: fix to remove err print for non-dpaa devices Thomas Monjalon
2 siblings, 0 replies; 8+ messages in thread
From: Hemant Agrawal @ 2019-07-22 10:03 UTC (permalink / raw)
To: dev, ferruh.yigit
This patch removes the unnecessary err prints when using
non-dpaa2 devices.
Fixes: e67a61614d0b ("bus/fslmc: support device iteration")
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
drivers/bus/fslmc/fslmc_bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c
index 9e4146aba..a2f482516 100644
--- a/drivers/bus/fslmc/fslmc_bus.c
+++ b/drivers/bus/fslmc/fslmc_bus.c
@@ -601,7 +601,7 @@ fslmc_bus_dev_iterate(const void *start, const char *str,
/* Expectation is that device would be name=device_name */
if (strncmp(str, "name=", 5) != 0) {
- DPAA2_BUS_ERR("Invalid device string (%s)\n", str);
+ DPAA2_BUS_DEBUG("Invalid device string (%s)\n", str);
return NULL;
}
--
2.17.1
^ permalink raw reply [flat|nested] 8+ messages in thread* [dpdk-dev] [PATCH v2 3/3] bus/fslmc: fix the compliation err with ppc64 compiler
2019-07-22 10:03 ` [dpdk-dev] [PATCH v2 1/3] bus/dpaa: fix to remove err print for non-dpaa devices Hemant Agrawal
2019-07-22 10:03 ` [dpdk-dev] [PATCH v2 2/3] bus/fslmc: fix to remove err print for non-fslmc devices Hemant Agrawal
@ 2019-07-22 10:03 ` Hemant Agrawal
2019-07-22 14:14 ` [dpdk-dev] [PATCH v2 1/3] bus/dpaa: fix to remove err print for non-dpaa devices Thomas Monjalon
2 siblings, 0 replies; 8+ messages in thread
From: Hemant Agrawal @ 2019-07-22 10:03 UTC (permalink / raw)
To: dev, ferruh.yigit
fslmc_vfio.c:387:36: note: format string is defined here
DPAA2_BUS_DEBUG("VFIO dmamap 0x%llx:0x%llx, size 0x%llx\n",
format ‘%llx’ expects argument of type ‘long long unsigned int’
argument 6 has type ‘__u64 {aka long unsigned int}’
Fixes: 2b5fa25708cf ("mempool/dpaa2: map external memory with VFIO")
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
drivers/bus/fslmc/fslmc_vfio.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/bus/fslmc/fslmc_vfio.c b/drivers/bus/fslmc/fslmc_vfio.c
index 247b2a4a1..9658fd84d 100644
--- a/drivers/bus/fslmc/fslmc_vfio.c
+++ b/drivers/bus/fslmc/fslmc_vfio.c
@@ -384,8 +384,9 @@ rte_fslmc_vfio_mem_dmamap(uint64_t vaddr, uint64_t iova, uint64_t size)
dma_map.vaddr = vaddr;
dma_map.iova = iova;
- DPAA2_BUS_DEBUG("VFIO dmamap 0x%llx:0x%llx, size 0x%llx\n",
- dma_map.vaddr, dma_map.iova, dma_map.size);
+ DPAA2_BUS_DEBUG("VFIOdmamap 0x%"PRIx64":0x%"PRIx64",size 0x%"PRIx64"\n",
+ (uint64_t)dma_map.vaddr, (uint64_t)dma_map.iova,
+ (uint64_t)dma_map.size);
ret = ioctl(group->container->fd, VFIO_IOMMU_MAP_DMA,
&dma_map);
if (ret) {
--
2.17.1
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [PATCH v2 1/3] bus/dpaa: fix to remove err print for non-dpaa devices
2019-07-22 10:03 ` [dpdk-dev] [PATCH v2 1/3] bus/dpaa: fix to remove err print for non-dpaa devices Hemant Agrawal
2019-07-22 10:03 ` [dpdk-dev] [PATCH v2 2/3] bus/fslmc: fix to remove err print for non-fslmc devices Hemant Agrawal
2019-07-22 10:03 ` [dpdk-dev] [PATCH v2 3/3] bus/fslmc: fix the compliation err with ppc64 compiler Hemant Agrawal
@ 2019-07-22 14:14 ` Thomas Monjalon
2 siblings, 0 replies; 8+ messages in thread
From: Thomas Monjalon @ 2019-07-22 14:14 UTC (permalink / raw)
To: Hemant Agrawal; +Cc: dev, ferruh.yigit
22/07/2019 12:03, Hemant Agrawal:
> This patch removes the unnecessary err prints when using
> non-dpaa devices.
> Fixes: e79df833d3f6 ("bus/dpaa: support hotplug ops")
>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Series applied, thanks
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-07-22 14:14 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-22 6:54 [dpdk-dev] [PATCH 1/3] bus/dpaa: fix to remove err print for non-dpaa devices Hemant Agrawal
2019-07-22 6:54 ` [dpdk-dev] [PATCH 2/3] bus/fslmc: fix to remove err print for non-fslmc devices Hemant Agrawal
2019-07-22 6:54 ` [dpdk-dev] [PATCH 3/3] bus/fslmc: fix the compliation err with ppc64 compiler Hemant Agrawal
2019-07-22 8:16 ` Thomas Monjalon
2019-07-22 10:03 ` [dpdk-dev] [PATCH v2 1/3] bus/dpaa: fix to remove err print for non-dpaa devices Hemant Agrawal
2019-07-22 10:03 ` [dpdk-dev] [PATCH v2 2/3] bus/fslmc: fix to remove err print for non-fslmc devices Hemant Agrawal
2019-07-22 10:03 ` [dpdk-dev] [PATCH v2 3/3] bus/fslmc: fix the compliation err with ppc64 compiler Hemant Agrawal
2019-07-22 14:14 ` [dpdk-dev] [PATCH v2 1/3] bus/dpaa: fix to remove err print for non-dpaa devices Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).