* [dpdk-dev] [PATCH] app/testpmd: fix MAC addr parser for flow
@ 2019-07-22 16:58 Ferruh Yigit
2019-07-22 17:02 ` Ferruh Yigit
0 siblings, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2019-07-22 16:58 UTC (permalink / raw)
To: Adrien Mazarguil, Wenzhuo Lu, Jingjing Wu, Bernard Iremonger
Cc: dev, Raslan Darawsheh, Stephen Hemminger
MAC address parsing was causing failure [1],
this patch partially reverts the commit
commit b5ddce8959b2 ("app/testpmd: use new ethernet address parser")
[1]
testpmd> flow validate 0 priority 2 ingress group 0 pattern eth dst
is 98:03:9B:5C:D9:00 / end actions queue index 0 / end
Bad arguments
Fixes: b5ddce8959b2 ("app/testpmd: use new ethernet address parser")
Reported-by: Raslan Darawsheh <rasland@mellanox.com>
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: Stephen Hemminger <stephen@networkplumber.org>
---
app/test-pmd/cmdline_flow.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index d08f016be..495871394 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -18,6 +18,7 @@
#include <rte_ethdev.h>
#include <rte_byteorder.h>
#include <cmdline_parse.h>
+#include <cmdline_parse_etheraddr.h>
#include <rte_flow.h>
#include "testpmd.h"
@@ -4978,8 +4979,8 @@ parse_mac_addr(struct context *ctx, const struct token *token,
/* Only network endian is supported. */
if (!arg->hton)
goto error;
- ret = rte_ether_unformat_addr(str, &tmp);
- if (ret < 0)
+ ret = cmdline_parse_etheraddr(NULL, str, &tmp, size);
+ if (ret < 0 || (unsigned int)ret != len)
goto error;
if (!ctx->object)
return len;
--
2.21.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: fix MAC addr parser for flow
2019-07-22 16:58 [dpdk-dev] [PATCH] app/testpmd: fix MAC addr parser for flow Ferruh Yigit
@ 2019-07-22 17:02 ` Ferruh Yigit
2019-07-22 17:17 ` Ferruh Yigit
2019-07-22 17:20 ` Stephen Hemminger
0 siblings, 2 replies; 6+ messages in thread
From: Ferruh Yigit @ 2019-07-22 17:02 UTC (permalink / raw)
To: Adrien Mazarguil, Wenzhuo Lu, Jingjing Wu, Bernard Iremonger
Cc: dev, Raslan Darawsheh, Stephen Hemminger
On 7/22/2019 5:58 PM, Ferruh Yigit wrote:
> MAC address parsing was causing failure [1],
> this patch partially reverts the commit
> commit b5ddce8959b2 ("app/testpmd: use new ethernet address parser")
>
> [1]
> testpmd> flow validate 0 priority 2 ingress group 0 pattern eth dst
> is 98:03:9B:5C:D9:00 / end actions queue index 0 / end
> Bad arguments
>
> Fixes: b5ddce8959b2 ("app/testpmd: use new ethernet address parser")
>
> Reported-by: Raslan Darawsheh <rasland@mellanox.com>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: Stephen Hemminger <stephen@networkplumber.org>
If there is no objection, or more proper fix, till tomorrow morning (europe
time), I am planning to merge this one, fyi.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: fix MAC addr parser for flow
2019-07-22 17:02 ` Ferruh Yigit
@ 2019-07-22 17:17 ` Ferruh Yigit
2019-07-22 17:20 ` Stephen Hemminger
1 sibling, 0 replies; 6+ messages in thread
From: Ferruh Yigit @ 2019-07-22 17:17 UTC (permalink / raw)
To: Adrien Mazarguil, Wenzhuo Lu, Jingjing Wu, Bernard Iremonger
Cc: dev, Raslan Darawsheh, Stephen Hemminger, Thomas Monjalon
On 7/22/2019 6:02 PM, Ferruh Yigit wrote:
> On 7/22/2019 5:58 PM, Ferruh Yigit wrote:
>> MAC address parsing was causing failure [1],
>> this patch partially reverts the commit
>> commit b5ddce8959b2 ("app/testpmd: use new ethernet address parser")
>>
>> [1]
>> testpmd> flow validate 0 priority 2 ingress group 0 pattern eth dst
>> is 98:03:9B:5C:D9:00 / end actions queue index 0 / end
>> Bad arguments
>>
>> Fixes: b5ddce8959b2 ("app/testpmd: use new ethernet address parser")
>>
>> Reported-by: Raslan Darawsheh <rasland@mellanox.com>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>> Cc: Stephen Hemminger <stephen@networkplumber.org>
>
> If there is no objection, or more proper fix, till tomorrow morning (europe
> time), I am planning to merge this one, fyi.
>
+cc Thomas
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: fix MAC addr parser for flow
2019-07-22 17:02 ` Ferruh Yigit
2019-07-22 17:17 ` Ferruh Yigit
@ 2019-07-22 17:20 ` Stephen Hemminger
2019-07-23 6:39 ` Raslan Darawsheh
1 sibling, 1 reply; 6+ messages in thread
From: Stephen Hemminger @ 2019-07-22 17:20 UTC (permalink / raw)
To: Ferruh Yigit
Cc: Adrien Mazarguil, Wenzhuo Lu, Jingjing Wu, Bernard Iremonger,
dev, Raslan Darawsheh
On Mon, 22 Jul 2019 18:02:09 +0100
Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> On 7/22/2019 5:58 PM, Ferruh Yigit wrote:
> > MAC address parsing was causing failure [1],
> > this patch partially reverts the commit
> > commit b5ddce8959b2 ("app/testpmd: use new ethernet address parser")
> >
> > [1]
> > testpmd> flow validate 0 priority 2 ingress group 0 pattern eth dst
> > is 98:03:9B:5C:D9:00 / end actions queue index 0 / end
> > Bad arguments
> >
> > Fixes: b5ddce8959b2 ("app/testpmd: use new ethernet address parser")
> >
> > Reported-by: Raslan Darawsheh <rasland@mellanox.com>
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > ---
> > Cc: Stephen Hemminger <stephen@networkplumber.org>
>
> If there is no objection, or more proper fix, till tomorrow morning (europe
> time), I am planning to merge this one, fyi.
Works for me, testpmd always has the cmdline library anyway.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: fix MAC addr parser for flow
2019-07-22 17:20 ` Stephen Hemminger
@ 2019-07-23 6:39 ` Raslan Darawsheh
2019-07-23 10:42 ` Ferruh Yigit
0 siblings, 1 reply; 6+ messages in thread
From: Raslan Darawsheh @ 2019-07-23 6:39 UTC (permalink / raw)
To: Stephen Hemminger, Ferruh Yigit
Cc: Adrien Mazarguil, Wenzhuo Lu, Jingjing Wu, Bernard Iremonger, dev
Tested-by: Raslan Darawsheh <rasland@mellanox.com>
Seems OK for me,
Kindest regards,
Raslan Darawsheh
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Monday, July 22, 2019 8:20 PM
> To: Ferruh Yigit <ferruh.yigit@intel.com>
> Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>; Wenzhuo Lu
> <wenzhuo.lu@intel.com>; Jingjing Wu <jingjing.wu@intel.com>; Bernard
> Iremonger <bernard.iremonger@intel.com>; dev@dpdk.org; Raslan
> Darawsheh <rasland@mellanox.com>
> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix MAC addr parser for flow
>
> On Mon, 22 Jul 2019 18:02:09 +0100
> Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> > On 7/22/2019 5:58 PM, Ferruh Yigit wrote:
> > > MAC address parsing was causing failure [1], this patch partially
> > > reverts the commit commit b5ddce8959b2 ("app/testpmd: use new
> > > ethernet address parser")
> > >
> > > [1]
> > > testpmd> flow validate 0 priority 2 ingress group 0 pattern eth
> > > testpmd> dst
> > > is 98:03:9B:5C:D9:00 / end actions queue index 0 / end Bad
> > > arguments
> > >
> > > Fixes: b5ddce8959b2 ("app/testpmd: use new ethernet address parser")
> > >
> > > Reported-by: Raslan Darawsheh <rasland@mellanox.com>
> > > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > > ---
> > > Cc: Stephen Hemminger <stephen@networkplumber.org>
> >
> > If there is no objection, or more proper fix, till tomorrow morning
> > (europe time), I am planning to merge this one, fyi.
>
> Works for me, testpmd always has the cmdline library anyway.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: fix MAC addr parser for flow
2019-07-23 6:39 ` Raslan Darawsheh
@ 2019-07-23 10:42 ` Ferruh Yigit
0 siblings, 0 replies; 6+ messages in thread
From: Ferruh Yigit @ 2019-07-23 10:42 UTC (permalink / raw)
To: Raslan Darawsheh, Stephen Hemminger
Cc: Adrien Mazarguil, Wenzhuo Lu, Jingjing Wu, Bernard Iremonger, dev
On 7/23/2019 7:39 AM, Raslan Darawsheh wrote:
> Tested-by: Raslan Darawsheh <rasland@mellanox.com>
> Seems OK for me,
>
> Kindest regards,
> Raslan Darawsheh
>
>> -----Original Message-----
>> From: Stephen Hemminger <stephen@networkplumber.org>
>> Sent: Monday, July 22, 2019 8:20 PM
>> To: Ferruh Yigit <ferruh.yigit@intel.com>
>> Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>; Wenzhuo Lu
>> <wenzhuo.lu@intel.com>; Jingjing Wu <jingjing.wu@intel.com>; Bernard
>> Iremonger <bernard.iremonger@intel.com>; dev@dpdk.org; Raslan
>> Darawsheh <rasland@mellanox.com>
>> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix MAC addr parser for flow
>>
>> On Mon, 22 Jul 2019 18:02:09 +0100
>> Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>
>>> On 7/22/2019 5:58 PM, Ferruh Yigit wrote:
>>>> MAC address parsing was causing failure [1], this patch partially
>>>> reverts the commit commit b5ddce8959b2 ("app/testpmd: use new
>>>> ethernet address parser")
>>>>
>>>> [1]
>>>> testpmd> flow validate 0 priority 2 ingress group 0 pattern eth
>>>> testpmd> dst
>>>> is 98:03:9B:5C:D9:00 / end actions queue index 0 / end Bad
>>>> arguments
>>>>
>>>> Fixes: b5ddce8959b2 ("app/testpmd: use new ethernet address parser")
>>>>
>>>> Reported-by: Raslan Darawsheh <rasland@mellanox.com>
>>>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>>> ---
>>>> Cc: Stephen Hemminger <stephen@networkplumber.org>
>>>
>>> If there is no objection, or more proper fix, till tomorrow morning
>>> (europe time), I am planning to merge this one, fyi.
>>
>> Works for me, testpmd always has the cmdline library anyway.
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-07-23 10:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-22 16:58 [dpdk-dev] [PATCH] app/testpmd: fix MAC addr parser for flow Ferruh Yigit
2019-07-22 17:02 ` Ferruh Yigit
2019-07-22 17:17 ` Ferruh Yigit
2019-07-22 17:20 ` Stephen Hemminger
2019-07-23 6:39 ` Raslan Darawsheh
2019-07-23 10:42 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).