From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 208EBA046B for ; Mon, 22 Jul 2019 19:20:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 188491BE4E; Mon, 22 Jul 2019 19:20:06 +0200 (CEST) Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id 67F3E1BE4D for ; Mon, 22 Jul 2019 19:20:05 +0200 (CEST) Received: by mail-pg1-f194.google.com with SMTP id t132so17962498pgb.9 for ; Mon, 22 Jul 2019 10:20:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1/D+cCQCj9UhfQba5M7icL1WnX1/h3wAu2BCJpP604k=; b=HzVx1xyKotieEWJnKGFJsQbw36zL073JnpvljlBdGkbsxtaSVHdldexzW4FvkGZT7L da56syFy7u0H9hSAcoIIaInUufwrAzVgLkuYFrX89ers3Ho+fY2MnP1smcOjxNSPV48o ShU2s2hVAWZ1wlbopcXrZivDgb2xSOGCD0Ktx6I6Dwo2oFDNkk9inbn2WRQ0jzgWKxez bZmSByNOF2uSsmLokjKpy3DhDLZjqjtAQlAguukH3i6hR6yGQQBvv+4DpHuWfcWYySb4 AcYHZf/E5Faipz71g8othxE9vq/zBwvu5oFAhtf7hnWPBI5yq94Oofmbj/Sj+0YwsY4a bmbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1/D+cCQCj9UhfQba5M7icL1WnX1/h3wAu2BCJpP604k=; b=qk5UAYSHtnz4/NNyCJD6H95FJZXGAHtrC8zfHqjjPqDskkJX0hZMJ1sqEU903hAXRo AuK2kJgoPggvDqD0M9kWmLxmGQkAuVRF47oKe0QUhyC8P7kZ2HEimtfHOMSTRbt8j1sJ m5myDa+S61TXaI9W8wkWRV3jw5/6vrqGWCw3omka2Qv+tnSOn4O8Acl7HCoHLzvdSqA7 FPvFiHR44KOs3urLEydwENeYkSuhJHAuf3dE9dYV0J0Gq4zOXt+zlhkpish8rSsx0Cim 2URcCh75WU1X/FdQSbPKCRRm3XfY4Nwfq6NUcbnWGN9hY+MrYDcCMA8J5xFyy0kz4aM+ CPyA== X-Gm-Message-State: APjAAAWm6X1IYu1g/RtwZpV0vChLZTNGnNd7ccmJpyljplpgDCHr3AuT 5lTHf7PqiYpREIiTIygkFCY= X-Google-Smtp-Source: APXvYqzvyCa5kyEKnlxAnl+Q2Ld0Y5LsAyVpCPnIRH+q4HuVHESfn7CL6KwT/yA564xLzXtQHLkckg== X-Received: by 2002:a17:90a:208d:: with SMTP id f13mr75729233pjg.68.1563816004542; Mon, 22 Jul 2019 10:20:04 -0700 (PDT) Received: from xps13 ([167.220.105.181]) by smtp.gmail.com with ESMTPSA id s15sm39689088pfd.183.2019.07.22.10.20.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 22 Jul 2019 10:20:04 -0700 (PDT) Date: Mon, 22 Jul 2019 10:20:02 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: Adrien Mazarguil , Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , dev@dpdk.org, Raslan Darawsheh Message-ID: <20190722102002.300f2640@xps13> In-Reply-To: <6167ab0b-c37e-fef5-5fdf-3162e58f69ee@intel.com> References: <20190722165832.38054-1-ferruh.yigit@intel.com> <6167ab0b-c37e-fef5-5fdf-3162e58f69ee@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix MAC addr parser for flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 22 Jul 2019 18:02:09 +0100 Ferruh Yigit wrote: > On 7/22/2019 5:58 PM, Ferruh Yigit wrote: > > MAC address parsing was causing failure [1], > > this patch partially reverts the commit > > commit b5ddce8959b2 ("app/testpmd: use new ethernet address parser") > > > > [1] > > testpmd> flow validate 0 priority 2 ingress group 0 pattern eth dst > > is 98:03:9B:5C:D9:00 / end actions queue index 0 / end > > Bad arguments > > > > Fixes: b5ddce8959b2 ("app/testpmd: use new ethernet address parser") > > > > Reported-by: Raslan Darawsheh > > Signed-off-by: Ferruh Yigit > > --- > > Cc: Stephen Hemminger > > If there is no objection, or more proper fix, till tomorrow morning (europe > time), I am planning to merge this one, fyi. Works for me, testpmd always has the cmdline library anyway.