From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CEA6BA046B for ; Mon, 22 Jul 2019 15:53:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7F8751BE82; Mon, 22 Jul 2019 15:53:25 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 101BC1BE70 for ; Mon, 22 Jul 2019 15:53:22 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Jul 2019 06:53:22 -0700 X-IronPort-AV: E=Sophos;i="5.64,295,1559545200"; d="scan'208";a="169258167" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Jul 2019 06:53:19 -0700 Date: Mon, 22 Jul 2019 14:53:17 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: "Parthasarathy, JananeeX M" , dev@dpdk.org, Michael Santana Francisco , Aaron Conole , Hari Kumar Vemula , "Pattan, Reshma" , "Mcnamara, John" , "Kovacevic, Marko" , David Marchand Message-ID: <20190722135316.GC289@bricha3-MOBL.ger.corp.intel.com> References: <1549103306-9644-1-git-send-email-hari.kumarx.vemula@intel.com> <7AE31235A30B41498D1C31348DC858BD67B6A60E@IRSMSX103.ger.corp.intel.com> <6911600.pdS3C77OGP@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6911600.pdS3C77OGP@xps> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH v6] doc: add meson ut info in prog guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jul 22, 2019 at 02:53:34PM +0200, Thomas Monjalon wrote: > 22/07/2019 14:39, Parthasarathy, JananeeX M: > >From: Michael Santana Francisco [mailto:msantana@redhat.com] > > >On Mon, Jul 8, 2019 at 4:18 PM Aaron Conole wrote: > > >> Thomas Monjalon writes: > > >> >> +Building and running the unit tests > > >> >> +----------------------------------- > > >> >> + > > >> >> +* Create the meson build output folder using the following command:: > > >> >> + > > >> >> + $ meson > > >> >> + > > >> >> +* Enter into build output folder, which was created by above command:: > > >> >> + > > >> >> + $ cd build > > >> > > > >> > Should be the same as above: > > > > Will change accordingly. > > > > >> > > > >> >> + > > >> >> +* Compile DPDK using command:: > > >> >> + > > >> >> + $ ninja > > >> > > > >> > Do we really need to repeat above basic steps? > > >> > Would be easier to just reference another guide about meson. > > >> > I think doc/build-sdk-meson.txt should be moved to .rst. > > >> > > >> +1 > > > > This doc helps to run UT, having basic steps in same page will help user to go through together and execute the same. > > Just for few lines moving back and forth to different pages might be bit confusing. > > Anyway still if you would prefer to remove these then only 2 sections will be available in this doc. > > Please let us know if it is ok. > > I think it is better to avoid repetition. > > > > >> >> +* Multiple paths:: > > >> >> + > > >> >> + $ CFLAGS=-I/path1 -I/path2 meson build > > >> > > > >> > Some quotes are missing to set multiple paths. > > > > Is meant here? > > I am just saying that space-separated value require some quotes. > > > >> >> +Below are some examples that show how to export libraries and > > >> >> +their header paths. > > >> >> + > > >> >> +To specify a single library at a time:: > > >> >> + > > >> >> + $ export LIBRARY_PATH=/root/wireless_libs/zuc/ > > >> >> + $ CFLAGS=-I/root/wireless_libs/zuc/include meson build > > >> >> + > > >> >> +To specify multiple libraries at a time:: > > >> >> + > > >> >> + $ export LIBRARY_PATH=/path/zuc/:/path/libsso_kasumi/build/ > > >> >> + $ CFLAGS=-I/path/zuc/include \ > > >> >> + -I/path/libsso_kasumi/include \ > > >> >> + meson build > > >> > > > >> > Why export is used for LIBRARY_PATH and not CFLAGS? > > >> > I think both variables can be exported or prepend the meson command? > > > > CFLAGS given in meson command works and also CFLAGS can be exported. > > LIBRARY_PATH cannot be prepended to meson command. We tried but it is not reflecting the required values. > > Environment variables set using export is considered and not as command line args of meson command. > > Please we need to understand why LIBRARY_PATH is not working > when preprended in the meson command. > Do you have more informations? > Rather than using the environment, one can also use "-Dc_args='...' -Dc_link_args='...'" when calling meson. Otherwise, I agree with Thomas, we should find out why the LIBRARY_PATH doesn't work when passed in directly. I'm not aware of any reason it shouldn't work. /Bruce