From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2305DA046B for ; Mon, 22 Jul 2019 18:55:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 069141BF3F; Mon, 22 Jul 2019 18:55:13 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 4CA4E1BF35 for ; Mon, 22 Jul 2019 18:55:11 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 0744F4F1; Mon, 22 Jul 2019 12:55:09 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 22 Jul 2019 12:55:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=mesmtp; bh=cb23nS61pL F+DkbV5Ubl7Z+O38YlBvbhojNsmGDzDZg=; b=J4hJvnvJGDttyF27u7/PQXxEKo dnqcX1PxG5KC8ZJWw9I8vMaSNrkbdO+tS/6Ifyy3A6dhPTy8hiQ1vNxa159b6c2M jFezGkaWuvLkHGX8zP3n4pFix6tlMIJi6PIwu9G9vYCfuqXJOh2LYdpMijmE/b0h iN6yr8fVjq0pxD9s8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=cb23nS61pLF+DkbV5Ubl7Z+O38YlBvbhojNsmGDzDZg=; b=pkiJ23wW DR2u6uNpqPEYY0dMdPaGdDcLHWStNKwUTagA2Q6+NwI3m73sDKCm/cJj2mXkidaD PIPB7YJVPVcpSxYuwBft8liIOPd/f5hdi4vUY3hn8gERSjFnvYAQxK3851qEguak +PMyuoqLlofTO2+SULuc73y0QJSIh4NfUNcIof03V11lv0sn9mOd2HfDaiYTnA0n V44ct6oeJlMnMjhT8/+jwscUiY9BHQxKJiIub5Ro4jwPi6aPMAD1ckec7PVG/Z77 SfQt1uM+oY7snYGqGyk7yotyuvNSc4/J4OyazLlG0nwVcAuqPZwPQYyS+y88+/eW oiyKzNyRtoS7Fw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrjeeggddutdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgjfhgggfestdekre dtredttdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshes mhhonhhjrghlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtdefrddukeegnecurf grrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecu vehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id AE2DD8005B; Mon, 22 Jul 2019 12:55:08 -0400 (EDT) From: Thomas Monjalon To: anatoly.burakov@intel.com Cc: dev@dpdk.org Date: Mon, 22 Jul 2019 18:55:05 +0200 Message-Id: <20190722165505.14745-1-thomas@monjalon.net> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190718093432.14092-1-thomas@monjalon.net> References: <20190718093432.14092-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2] eal: warn on legacy memory allocation requirement X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When using --no-huge mode, dynamic allocation is not supported. Because of this limitation, the option --legacy-mem is implied and -m may be needed to specify the amount of memory to allocate. Otherwise the default amount MEMSIZE_IF_NO_HUGE_PAGE will be allocated. Signed-off-by: Thomas Monjalon --- v2: - user-oriented message - trigger warning on any legacy mem option --- lib/librte_eal/common/eal_common_options.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c index 24e36cf23..5e489041a 100644 --- a/lib/librte_eal/common/eal_common_options.c +++ b/lib/librte_eal/common/eal_common_options.c @@ -1592,6 +1592,10 @@ eal_check_common_options(struct internal_config *internal_cfg) "with --"OPT_MATCH_ALLOCATIONS"\n"); return -1; } + if (internal_cfg->legacy_mem && internal_cfg->memory == 0) { + RTE_LOG(NOTICE, EAL, "Selected memory layout is static, " + "allocation can be increased with the option -m\n"); + } return 0; } -- 2.21.0