From: Krzysztof Kanas <kkanas@marvell.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: Krzysztof Kanas <kkanas@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Thomas Monjalon <thomas@monjalon.net>,
"reshma.pattan@intel.com" <reshma.pattan@intel.com>
Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] mk: disable flag for no packet member warning
Date: Tue, 23 Jul 2019 09:05:50 +0000 [thread overview]
Message-ID: <20190723090548.GA32530@kk-box-0> (raw)
In-Reply-To: <20190722134416.GB289@bricha3-MOBL.ger.corp.intel.com>
On 19-07-22 14:44, Bruce Richardson wrote:
> External Email
>
> ----------------------------------------------------------------------
> On Mon, Jul 22, 2019 at 02:39:59PM +0200, kkanas@marvell.com wrote:
> > From: Krzysztof Kanas <kkanas@marvell.com>
> >
> > gcc prior 9 don't will add additional warning for unrecognized command
> > line option, but only when there is some other warning in the code, e.g
> > unused variable.
> >
> I don't think this behaviour has changed in gcc 9. I just did a test
> compile with gcc 9.1, and no warning was printed for flag
> "-Wno-random-warnings". The online docs also make no mention of this
> behaviour being conditional on GCC version [1].
GCC changelog show that from 9.0 -Waddress-of-packed-member was added
[1].
Test shows me that GCC prior to 9.0 won't complain about this flag, but
in case of other warnings in file GCC will complain, e.g.,
cat > a.c
int main(int argc, char **argv)
{
int a;
return 0;
}
# gcc -Wall -Wno-address-of-packed-member a.c
a.c: In function ‘main’:
a.c:3:6: warning: unused variable ‘a’ [-Wunused-variable]
int a;
^
a.c: At top level:
cc1: warning: unrecognized command line option ‘-Wno-address-of-packed-member’
But when line `int a;' is removed then no warning is issued.
Also I detected this, due to difference with meson build. Meson checks
if compiler supports this flag and will not issue
-Wno-address-of-packed-member to compiler.
>
> /Bruce
>
> [1] https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html
[1] https://gcc.gnu.org/gcc-9/changes.html
--
-
Regards,
Krzysztof(Chris) Kanas
next prev parent reply other threads:[~2019-07-23 9:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 12:39 [dpdk-dev] " kkanas
2019-07-22 13:44 ` Bruce Richardson
2019-07-23 9:05 ` Krzysztof Kanas [this message]
2019-07-23 13:18 ` [dpdk-dev] [EXT] " Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190723090548.GA32530@kk-box-0 \
--to=kkanas@marvell.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=reshma.pattan@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).